From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by sourceware.org (Postfix) with ESMTPS id 2B1C63858C27 for ; Mon, 4 Jan 2021 07:40:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B1C63858C27 Received: by mail-qt1-x835.google.com with SMTP id b9so17962691qtr.2 for ; Sun, 03 Jan 2021 23:40:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oMKS/BZ3kdBPbcHEarFXgBqvEXDpIzfICLH3u1x6Y7k=; b=nyqOn9io/I8BDUkKMaqB5xcpX8+QMvfny7U1cqVH+EER+/ke57LA0z67gT/LYeQ5Yl RTVRtJu8A3TloPQofY4mfIO3TuA6MU2Jkjvs772Ia/3tdYyyH0eWG9M15WpeLKkV5H2v G6Q7vBlD6mq+UlmsaHQgU5k1fShrCPDKxou7JoFyjhZNoe/+vSdhLocRk4GSG/FDnavr JIaDAN+inKKOJTo843dkhnn9dom8i4prmBLnAYCyeE0ZQEOQVSBJm84CQ3sT9DSdkbOi lJDNqWaHxFJiO+BgdjWqeoGM/q6u0oh2+RzVG9E6L1EHWvBUFhw6V1dNRVkvuWQL7Hqp pu2Q== X-Gm-Message-State: AOAM5325ZaUb0cZ9w1dN5Trmeh8oQXRlOx5jONATYXazGmUv4NwJ2CX8 Wg11XOcjjd2l9+jk4h9pX7diglAkHY3X2bkwy6I= X-Google-Smtp-Source: ABdhPJz6/nWG2ZDDI52n3YI0zrXIkzqgKjYPaL2EiIIa5uT58d7uo+wRH0NTSTRlNujg21vj75Fg/Ydd8Q0L3kD5COo= X-Received: by 2002:ac8:3a63:: with SMTP id w90mr70521498qte.225.1609746039633; Sun, 03 Jan 2021 23:40:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Mon, 4 Jan 2021 08:40:28 +0100 Message-ID: Subject: Re: [PATCH]i386: Optimize pmovskb on zero_extend of subreg HI of the result [PR98461] To: Hongtao Liu Cc: GCC Patches , Kirill Yukhin , "H. J. Lu" , Jakub Jelinek Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 07:40:41 -0000 On Mon, Jan 4, 2021 at 6:54 AM Hongtao Liu wrote: > > Hi: > The following patch adds define_insn_and_split to optimize > > vpmovmskb %xmm0, %eax > - movzwl %ax, %eax > notl %eax > > Bootstrapped/regtested on x86_64-linux-gnu {,-m32}. > Ok for trunk? > > gcc/ChangeLog > PR target/98461 > * config/i386/sse.md (*sse2_pmovskb_zexthisi): New > define_insn_and_split for zero_extend of subreg HI of pmovskb > result. > > gcc/testsuite/ChangeLog > * gcc.target/i386/sse-pr98461-2.c: New test. > --- > gcc/config/i386/sse.md | 11 +++++++++++ > gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c | 13 +++++++++++++ > 2 files changed, 24 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > index d84103807ff..4ed6b9ae476 100644 > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -16099,6 +16099,17 @@ (define_insn "*sse2_pmovmskb_ext" > (set_attr "prefix" "maybe_vex") > (set_attr "mode" "SI")]) > > +(define_insn_and_split "*sse2_pmovskb_zexthisi" > + [(set (match_operand:SI 0 "register_operand") > + (zero_extend:SI (subreg:HI (unspec:SI > + [(match_operand:V16QI 1 "register_operand")] > + UNSPEC_MOVMSK) 0)))] > + "TARGET_SSE2" This needs ix86_pre_reload_split () in insn predicate. Uros. > + "#" > + "&& 1" > + [(set (match_dup 0) > + (unspec:SI [(match_dup 1)] UNSPEC_MOVMSK))]) > + > (define_split > [(set (match_operand:SI 0 "register_operand") > (unspec:SI > diff --git a/gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c > b/gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c > new file mode 100644 > index 00000000000..60fc1f3e9c1 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/sse2-pr98461-2.c > @@ -0,0 +1,13 @@ > +/* PR target/98461 */ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -msse2 -mno-sse3 -masm=att" } */ > +/* { dg-final { scan-assembler-times "\tpmovmskb\t" 1 } } */ > +/* { dg-final { scan-assembler-not "\tmovzwl" } } */ > +/* { dg-final { scan-assembler-times "\tnotl" 1 } } */ > + > +#include > + > +unsigned int movemask_not1(__m128i logical) { > + unsigned short res = (unsigned short)(_mm_movemask_epi8(logical)); > + return ~res; > +} > -- > 2.18.1 > > > -- > BR, > Hongtao