From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132])
	by sourceware.org (Postfix) with ESMTPS id 64A063858D37
	for <gcc-patches@gcc.gnu.org>; Mon, 10 Oct 2022 07:27:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64A063858D37
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-35ad0584879so93098127b3.7
        for <gcc-patches@gcc.gnu.org>; Mon, 10 Oct 2022 00:27:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=cqpldmxdRan6ZaaVOFXkc7d/j6TgwZY9YVC5i8dOxgo=;
        b=Gweluq8OQF5G9YDNNVSroV7eDzG6rdG04OS+FvchsazKmgXO0wskxtY72cwzMMqCix
         gl5pq0Z2kR0sxlON9raeeIJjrz4awrna6JWgI6zytGVDq0Bb+Uri+sEAppN0v5X3gU54
         /mxCwGv/WqlvqMQmU3fYkHYzLGyNPhfSVjRROZ0a3cCnqPaqyIwv2HLTpuAWBYwa3wGe
         jHGVczOGj8tYjVAMsPHHdM0/GOAhni1Smfw4AnmXTK+ijoFyf9Mon0ZEUwM+Fu+UnyT9
         HuTFRi6qs3NVHX0oUvnF7zbCF8K0fAMR0DEZfWJkt56U8swU3OwW564vVAro5Z52Te/T
         EyJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=cqpldmxdRan6ZaaVOFXkc7d/j6TgwZY9YVC5i8dOxgo=;
        b=qcBlznzvbX9lScsEDV6EXCzdIWewPEhPX6AAb1upXwGi4vRRiiOM2SqoQ6gMRtuT6q
         VU78XGIko0iY6b2La3extjVxUJ7GukVbDZKKx6NQV690aVVQP2bBvifr0JrknlHKtppt
         1J3zVv6CtXqQ6vcHvXk9C34z0TWEX10QjZ6GvIIcpCq5iCSsxNxPjRLH7YkbkK8GMwtF
         WFXfai5DxwJb4S0ufwf3X9KHUKeEPMKQEpT3KsVXfJuwKS3WSSYWhPqEVBbD8wbnjzJq
         1y3DbWvOTVinc0GAUJ5qOmGVC61c8WUU0Uk/Qow/94ZIztAHYavNbDkkM0KifsrXRYIC
         7dWw==
X-Gm-Message-State: ACrzQf0CSBZ9pKbEIjJJ1cdflbxOWgWLP8VO9mfZATJS6u3WvCu4J5hL
	nzoujmnwGktdvtzFxEIi0NMKBl4JtLbIvkZ3E4g=
X-Google-Smtp-Source: AMsMyM4d4AkoCny5pi92mSLBFtg7zDHXS1u0y4p/8W3cubbh6WUJs2TF84rMbZZCSDsviZrTgbT/BnUIk6wzJ71WRGc=
X-Received: by 2002:a81:a24e:0:b0:358:934b:980c with SMTP id
 z14-20020a81a24e000000b00358934b980cmr15683869ywg.383.1665386864602; Mon, 10
 Oct 2022 00:27:44 -0700 (PDT)
MIME-Version: 1.0
References: <20221010012601.2741373-1-hongtao.liu@intel.com>
In-Reply-To: <20221010012601.2741373-1-hongtao.liu@intel.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Mon, 10 Oct 2022 09:27:32 +0200
Message-ID: <CAFULd4ZR4DQ8jk4TsNALmKysuURS4-mr4cJODG2aixjc_8+8uw@mail.gmail.com>
Subject: Re: [PATCH] [x86] Fix unrecognizable insn of cvtss2si.
To: liuhongt <hongtao.liu@intel.com>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Mon, Oct 10, 2022 at 3:26 AM liuhongt via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Adjust lrintmn2 operand preidcates according to real instructions.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Ok as an obvious fix?
>
> gcc/ChangeLog:
>
>         PR target/107185
>         * config/i386/i386.md (lrint<MODEF:mode><SWI48:mode>2): Swap
>         predicate of operands[0] and operands[1].
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/i386/pr107185.c: New test.

OK.

Thanks,
Uros.

> ---
>  gcc/config/i386/i386.md                  | 4 ++--
>  gcc/testsuite/gcc.target/i386/pr107185.c | 8 ++++++++
>  2 files changed, 10 insertions(+), 2 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.target/i386/pr107185.c
>
> diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
> index 1be9b669909..947513701b9 100644
> --- a/gcc/config/i386/i386.md
> +++ b/gcc/config/i386/i386.md
> @@ -20145,8 +20145,8 @@ (define_insn "lrintxf<mode>2"
>     (set_attr "mode" "<MODE>")])
>
>  (define_expand "lrint<MODEF:mode><SWI48:mode>2"
> -  [(set (match_operand:SWI48 0 "nonimmediate_operand")
> -     (unspec:SWI48 [(match_operand:MODEF 1 "register_operand")]
> +  [(set (match_operand:SWI48 0 "register_operand")
> +     (unspec:SWI48 [(match_operand:MODEF 1 "nonimmediate_operand")]
>                    UNSPEC_FIX_NOTRUNC))]
>    "SSE_FLOAT_MODE_P (<MODEF:MODE>mode) && TARGET_SSE_MATH")
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr107185.c b/gcc/testsuite/gcc.target/i386/pr107185.c
> new file mode 100644
> index 00000000000..333191a9a89
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr107185.c
> @@ -0,0 +1,8 @@
> +/* { dg-do compile } */
> +/* { dg-options "-ffast-math" } */
> +
> +void
> +foo (float f)
> +{
> +  long p =  __builtin_lrintf (f);
> +}
> --
> 2.27.0
>