From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id DEBE6386F80A for ; Wed, 21 Jul 2021 15:59:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEBE6386F80A Received: by mail-qk1-x732.google.com with SMTP id bm6so2551643qkb.1 for ; Wed, 21 Jul 2021 08:59:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qiP7vda2HBz5QOsijFefJNNnZ8BUyH3tZcpf8pYNybQ=; b=ln9QAUe4jI5f6PLDTlP1axnOEn6suAc7I9eHBEdlxEnGB5apumtD4FSei+UeQo85Ob 79zSt4M/SbcsFhDGUFe+lRaDpbEtN7xSS4jM6mvB62roxqTMhR2NPaDRfVnhdr9SCDqX qQwSpdNtd6N7OrH2R26mQc8gTDZYjR9jHsbadkA1qFA3SxLmVcTvcvsYBmiIS8FIBd2T GBaQOYyDBTwx3v7Pd/dY+uHeeXRzZP8ZXFTumQDDh1KiSI2ZzlsJit07L+exe3U4DiR/ XJLYKPC0RseVqNOEZZHvuM/2V9yU3w1Q98IKekSb0xvHRqodhAs4JzGV+g4bwlv2sFIb irwA== X-Gm-Message-State: AOAM532312i/ZlfQTejip4xgmvs9PnOi6i2N4R2YDk6tBON5l93pYkaX xtPFb9k/DUQfg2Jeub4AbCTlqOoQTngftdIOl1A= X-Google-Smtp-Source: ABdhPJwHGXdPisec10vShQ/ZjsTKeVh2KGbYzCNuHeyHbeP8lYGTbVnjGbBDm9V7BZtY2u7t9ObD4yA5QfRUUofW+es= X-Received: by 2002:a05:620a:149c:: with SMTP id w28mr35808309qkj.127.1626883198089; Wed, 21 Jul 2021 08:59:58 -0700 (PDT) MIME-Version: 1.0 References: <20210721122315.55848-1-hjl.tools@gmail.com> In-Reply-To: <20210721122315.55848-1-hjl.tools@gmail.com> From: Uros Bizjak Date: Wed, 21 Jul 2021 17:59:46 +0200 Message-ID: Subject: Re: [PATCH] x86: Remove OPTION_MASK_ISA_SSE4_2 from CRC32 _builtin functions To: "H.J. Lu" Cc: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 16:00:00 -0000 V sre., 21. jul. 2021 14:23 je oseba H.J. Lu napisala: > Since > > commit 39671f87b2df6a1894cc11a161e4a7949d1ddccd > Author: H.J. Lu > Date: Thu Apr 15 05:59:48 2021 -0700 > > x86: Use crc32 target option for CRC32 intrinsics > > enabled OPTION_MASK_ISA_CRC32 for -msse4 and removed TARGET_SSE4_2 check > in sse4_2_crc32 pattens, remove OPTION_MASK_ISA_SSE4_2 from CRC32 > _builtin functions. > > gcc/ > > PR target/101549 > * config/i386/i386-builtin.def: Remove OPTION_MASK_ISA_SSE4_2 > from CRC32 _builtin functions. > > gcc/testsuite/ > > PR target/101549 > * gcc.target/i386/crc32-6.c: New test. > OK. Thanks, Uros. --- > gcc/config/i386/i386-builtin.def | 8 ++++---- > gcc/testsuite/gcc.target/i386/crc32-6.c | 13 +++++++++++++ > 2 files changed, 17 insertions(+), 4 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/crc32-6.c > > diff --git a/gcc/config/i386/i386-builtin.def > b/gcc/config/i386/i386-builtin.def > index 1cc0cc6968c..4b1ae0eb84c 100644 > --- a/gcc/config/i386/i386-builtin.def > +++ b/gcc/config/i386/i386-builtin.def > @@ -970,10 +970,10 @@ BDESC (OPTION_MASK_ISA_SSE4_1, 0, > CODE_FOR_sse4_1_ptestv2di, "__builtin_ia32_pte > > /* SSE4.2 */ > BDESC (OPTION_MASK_ISA_SSE4_2, 0, CODE_FOR_nothing, > "__builtin_ia32_pcmpgtq", IX86_BUILTIN_PCMPGTQ, UNKNOWN, (int) > V2DI_FTYPE_V2DI_V2DI) > -BDESC (OPTION_MASK_ISA_SSE4_2 | OPTION_MASK_ISA_CRC32, 0, > CODE_FOR_sse4_2_crc32qi, "__builtin_ia32_crc32qi", IX86_BUILTIN_CRC32QI, > UNKNOWN, (int) UINT_FTYPE_UINT_UCHAR) > -BDESC (OPTION_MASK_ISA_SSE4_2 | OPTION_MASK_ISA_CRC32, 0, > CODE_FOR_sse4_2_crc32hi, "__builtin_ia32_crc32hi", IX86_BUILTIN_CRC32HI, > UNKNOWN, (int) UINT_FTYPE_UINT_USHORT) > -BDESC (OPTION_MASK_ISA_SSE4_2 | OPTION_MASK_ISA_CRC32, 0, > CODE_FOR_sse4_2_crc32si, "__builtin_ia32_crc32si", IX86_BUILTIN_CRC32SI, > UNKNOWN, (int) UINT_FTYPE_UINT_UINT) > -BDESC (OPTION_MASK_ISA_SSE4_2 | OPTION_MASK_ISA_CRC32 | > OPTION_MASK_ISA_64BIT, 0, CODE_FOR_sse4_2_crc32di, > "__builtin_ia32_crc32di", IX86_BUILTIN_CRC32DI, UNKNOWN, (int) > UINT64_FTYPE_UINT64_UINT64) > +BDESC (OPTION_MASK_ISA_CRC32, 0, CODE_FOR_sse4_2_crc32qi, > "__builtin_ia32_crc32qi", IX86_BUILTIN_CRC32QI, UNKNOWN, (int) > UINT_FTYPE_UINT_UCHAR) > +BDESC (OPTION_MASK_ISA_CRC32, 0, CODE_FOR_sse4_2_crc32hi, > "__builtin_ia32_crc32hi", IX86_BUILTIN_CRC32HI, UNKNOWN, (int) > UINT_FTYPE_UINT_USHORT) > +BDESC (OPTION_MASK_ISA_CRC32, 0, CODE_FOR_sse4_2_crc32si, > "__builtin_ia32_crc32si", IX86_BUILTIN_CRC32SI, UNKNOWN, (int) > UINT_FTYPE_UINT_UINT) > +BDESC (OPTION_MASK_ISA_CRC32 | OPTION_MASK_ISA_64BIT, 0, > CODE_FOR_sse4_2_crc32di, "__builtin_ia32_crc32di", IX86_BUILTIN_CRC32DI, > UNKNOWN, (int) UINT64_FTYPE_UINT64_UINT64) > > /* SSE4A */ > BDESC (OPTION_MASK_ISA_SSE4A, 0, CODE_FOR_sse4a_extrqi, > "__builtin_ia32_extrqi", IX86_BUILTIN_EXTRQI, UNKNOWN, (int) > V2DI_FTYPE_V2DI_UINT_UINT) > diff --git a/gcc/testsuite/gcc.target/i386/crc32-6.c > b/gcc/testsuite/gcc.target/i386/crc32-6.c > new file mode 100644 > index 00000000000..464e3444069 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/crc32-6.c > @@ -0,0 +1,13 @@ > +/* PR target/101549 */ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -msse4 -mno-crc32" } */ > + > +#include > + > +unsigned int > +test_mm_crc32_u8 (unsigned int CRC, unsigned char V) > +{ > + return _mm_crc32_u8 (CRC, V); > +} > + > +/* { dg-error "needs isa option -mcrc32" "" { target *-*-* } 0 } */ > -- > 2.31.1 > >