From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by sourceware.org (Postfix) with ESMTPS id 86396384385C for ; Fri, 24 Jun 2022 20:58:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 86396384385C Received: by mail-qv1-xf2f.google.com with SMTP id c1so6279338qvi.11 for ; Fri, 24 Jun 2022 13:58:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3k7akegN40hjpSF10oqxTqLbtOY6a1xQBan+CrRPH3Q=; b=JO7mqj4qGAsgeJ5BvEjfg6VnX12ibZG/S6vmflCNVl/Rs4/UFeKw7Y5PH3lFWDfmCV jnrzZhAbFFRb9xM4r2fcEaFENrROW3n8CHpIbnjD+o3zhkEZ5lGlUcTEobEJTPDW5bhk ZN6LV58buXdV39RMAVVvlANeo6ESELU+XkXWn1kpr/TewE8iftu75SYVeVOlxuI4bz7+ PXfnWdygemuzzbNtzamlInqhwcqgQoX9MvYS520m05NVmoFuq6qxVZ8z9QgNIrpQ84Si ZIwAFFD3bTpw4INI2gnkcXv9LpZpHo/ynkAI/94xBQq1ZEQN96tvz/Q1SZNg/2hgDSdA fpiA== X-Gm-Message-State: AJIora9BIRjTHQuyh79iNO2P21eZl7eFQTEi7bQ17JF9t6lX+SjATKr8 wrBs8eF7pcJI+O/jB0BY0WwBpvz3cBW6Ms1mG80= X-Google-Smtp-Source: AGRyM1sLgN1nwsxodHQsZlfCw2PruKMH4/oT2B8jn/wBy1lKsWnVKGRBYtAjps5TBVVPHGoIQtB6a3Pm7EQfcHnNrQg= X-Received: by 2002:a05:622a:5d4:b0:305:8ff:b558 with SMTP id d20-20020a05622a05d400b0030508ffb558mr771505qtb.569.1656104298703; Fri, 24 Jun 2022 13:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-9-dmalcolm@redhat.com> In-Reply-To: From: Uros Bizjak Date: Fri, 24 Jun 2022 22:58:23 +0200 Message-ID: Subject: Re: PING^2 : Re: [PATCH 08/10] i386: add 'final' and 'override' to scalar_chain vfunc impls To: David Malcolm Cc: "gcc-patches@gcc.gnu.org" , Jan Hubicka Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 20:58:21 -0000 On Fri, Jun 24, 2022 at 8:19 PM David Malcolm wrote: > > I'd like to ping this patch: > https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html > > OK for trunk? I have no idea what patch does, but if all other targets do the same, x86 shouldn't be left behind. So, rubber-stamping OK. Thanks, Uros. > > Thanks > Dave > > > On Mon, 2022-06-13 at 14:30 -0400, David Malcolm wrote: > > Ping for this patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html > > > > OK for trunk? > > > > Thanks > > Dave > > > > On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > > > gcc/ChangeLog: > > > * config/i386/i386-features.h: Add "final" and "override" to > > > scalar_chain vfunc implementations as appropriate. > > > > > > Signed-off-by: David Malcolm > > > --- > > > gcc/config/i386/i386-features.h | 16 ++++++++-------- > > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > > > diff --git a/gcc/config/i386/i386-features.h b/gcc/config/i386/i386- > > > features.h > > > index 5c307607ae5..f46a6d95b74 100644 > > > --- a/gcc/config/i386/i386-features.h > > > +++ b/gcc/config/i386/i386-features.h > > > @@ -169,18 +169,18 @@ class general_scalar_chain : public > > > scalar_chain > > > public: > > > general_scalar_chain (enum machine_mode smode_, enum machine_mode > > > vmode_); > > > ~general_scalar_chain (); > > > - int compute_convert_gain (); > > > + int compute_convert_gain () final override; > > > private: > > > hash_map defs_map; > > > bitmap insns_conv; > > > unsigned n_sse_to_integer; > > > unsigned n_integer_to_sse; > > > - void mark_dual_mode_def (df_ref def); > > > - void convert_insn (rtx_insn *insn); > > > + void mark_dual_mode_def (df_ref def) final override; > > > + void convert_insn (rtx_insn *insn) final override; > > > void convert_op (rtx *op, rtx_insn *insn); > > > void convert_reg (rtx_insn *insn, rtx dst, rtx src); > > > void make_vector_copies (rtx_insn *, rtx); > > > - void convert_registers (); > > > + void convert_registers () final override; > > > int vector_const_cost (rtx exp); > > > }; > > > > > > @@ -190,14 +190,14 @@ class timode_scalar_chain : public scalar_chain > > > timode_scalar_chain () : scalar_chain (TImode, V1TImode) {} > > > > > > /* Convert from TImode to V1TImode is always faster. */ > > > - int compute_convert_gain () { return 1; } > > > + int compute_convert_gain () final override { return 1; } > > > > > > private: > > > - void mark_dual_mode_def (df_ref def); > > > + void mark_dual_mode_def (df_ref def) final override; > > > void fix_debug_reg_uses (rtx reg); > > > - void convert_insn (rtx_insn *insn); > > > + void convert_insn (rtx_insn *insn) final override; > > > /* We don't convert registers to difference size. */ > > > - void convert_registers () {} > > > + void convert_registers () final override {} > > > }; > > > > > > } // anon namespace > > > >