From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-340083-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22503 invoked by alias); 18 Apr 2013 10:18:07 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 22493 invoked by uid 89); 18 Apr 2013 10:18:07 -0000
X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_AV,TW_VP autolearn=ham version=3.3.1
Received: from mail-oa0-f50.google.com (HELO mail-oa0-f50.google.com) (209.85.219.50)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Apr 2013 10:18:06 +0000
Received: by mail-oa0-f50.google.com with SMTP id n1so2605654oag.9        for <gcc-patches@gcc.gnu.org>; Thu, 18 Apr 2013 03:18:05 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.105.227 with SMTP id gp3mr4907746obb.81.1366280284877; Thu, 18 Apr 2013 03:18:04 -0700 (PDT)
Received: by 10.182.49.68 with HTTP; Thu, 18 Apr 2013 03:18:04 -0700 (PDT)
In-Reply-To: <CACysShgUi8LT-hiBV4xnzoiTTpHAZmLc3FhB_D21b2PhNQTYfw@mail.gmail.com>
References: <CACysShgf2tV1yid9qG1=nfmNGvWhSj7M76Lt7RPaP7yRNpA1yw@mail.gmail.com>	<CAFiYyc32JaXAx3FcYbYNfLNvxpjTJaMnu4p_np7ptrcSNvjmpg@mail.gmail.com>	<CACysShgUi8LT-hiBV4xnzoiTTpHAZmLc3FhB_D21b2PhNQTYfw@mail.gmail.com>
Date: Thu, 18 Apr 2013 13:49:00 -0000
Message-ID: <CAFULd4ZbWKAVj4UVQZGYBFdF63PNFZLfZzxLxnZJ92iayrK6ww@mail.gmail.com>
Subject: Re: [testsuite, i386] Reimplementing array comparison in avx2-vpop-check.h
From: Uros Bizjak <ubizjak@gmail.com>
To: Alexander Ivchenko <aivchenk@gmail.com>
Cc: Richard Biener <richard.guenther@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-SW-Source: 2013-04/txt/msg01084.txt.bz2

On Thu, Apr 18, 2013 at 12:10 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> Yep, that also works.
>
> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index 64ffe8f..7efc3f1 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-04-18  Grigoriy Kraynov  <grigoriy.kraynov@intel.com>
> +
> +       * gcc.target/i386/avx2-vpop-check.h: volatility is casted away in
> +       memcmp().
> +
>  2013-04-18  Jakub Jelinek  <jakub@redhat.com>
>
>         PR tree-optimization/56984
> diff --git a/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
> b/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
> index 143b54da..02c879e 100644
> --- a/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
> +++ b/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
> @@ -47,7 +47,7 @@ avx2_test (void)
>        gen_pop ();
>        check_pop ();
>
> -      if (memcmp (c, c_ref, SIZE * sizeof (TYPE)))
> +      if (memcmp (c, (void *) c_ref, SIZE * sizeof (TYPE)))
>         abort();
>      }
>  }
>
>
> The fix is pretty obvious, but still.. is it OK for trunk?

Please add a short comment on the purpose of the cast.

OK with that change.

Thanks,
Uros.