From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-380149-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23470 invoked by alias); 10 Oct 2014 12:27:06 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 23459 invoked by uid 89); 10 Oct 2014 12:27:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-la0-f54.google.com
Received: from mail-la0-f54.google.com (HELO mail-la0-f54.google.com) (209.85.215.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 10 Oct 2014 12:27:04 +0000
Received: by mail-la0-f54.google.com with SMTP id gm9so3143549lab.27        for <gcc-patches@gcc.gnu.org>; Fri, 10 Oct 2014 05:27:01 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.152.36.130 with SMTP id q2mr4705859laj.42.1412944020913; Fri, 10 Oct 2014 05:27:00 -0700 (PDT)
Received: by 10.152.8.103 with HTTP; Fri, 10 Oct 2014 05:27:00 -0700 (PDT)
In-Reply-To: <CAOvf_xxXRSvjzRY-MnmBEgwmUhfqbqPjbVw8ZBjwvRheL8AZFA@mail.gmail.com>
References: <CAOvf_xxXRSvjzRY-MnmBEgwmUhfqbqPjbVw8ZBjwvRheL8AZFA@mail.gmail.com>
Date: Fri, 10 Oct 2014 12:34:00 -0000
Message-ID: <CAFULd4ZdrAfLVD58kOPaFPdXG_ry8p_w0ho+SqHk3Sotcy9TwQ@mail.gmail.com>
Subject: Re: [PATCH 2/X, i386, PR54232] Enable EBX for x86 in 32bits PIC code
From: Uros Bizjak <ubizjak@gmail.com>
To: Evgeny Stupachenko <evstupac@gmail.com>
Cc: Jeff Law <law@redhat.com>, Vladimir Makarov <vmakarov@redhat.com>, 	GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2014-10/txt/msg00924.txt.bz2

On Fri, Oct 10, 2014 at 9:43 AM, Evgeny Stupachenko <evstupac@gmail.com> wrote:
> i386 specific part of the patch:
>
> 2014-10-08  Ilya Enkovich  <ilya.enkovich@intel.com>
>             Vladimir Makarov  <vmakarov@redhat.com>
>         * gcc/config/i386/i386.c (ix86_use_pseudo_pic_reg): New.
>         (ix86_init_pic_reg): New.
>         (ix86_select_alt_pic_regnum): Add check on pseudo register.
>         (ix86_save_reg): Likewise.
>         (ix86_expand_prologue): Remove irrelevant code.

Please mention *which* code you removed here.

>         (ix86_output_function_epilogue): Add check on pseudo register.
>         (set_pic_reg_ever_alive): New.
>         (legitimize_pic_address): Replace df_set_regs_ever_live with new
>         set_pic_reg_ever_alive.
>         (legitimize_tls_address): Likewise.
>         (ix86_pic_register_p): New check.
>         (ix86_delegitimize_address): Add check on pseudo register.
>         (ix86_expand_call): Insert move from pseudo PIC register to ABI
>         defined REAL_PIC_OFFSET_TABLE_REGNUM.
>         (TARGET_INIT_PIC_REG): New.
>         (TARGET_USE_PSEUDO_PIC_REG): New.
>         (PIC_OFFSET_TABLE_REGNUM): New check.

This is not "New check", but changed one. Please mention *what* changed.

-      if (pic_offset_table_rtx)
+      if (pic_offset_table_rtx
+  && (!reload_completed || !ix86_use_pseudo_pic_reg ()))

Hm, can you please add a comment for this change?

Uros.