From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10159 invoked by alias); 16 Oct 2014 09:19:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10145 invoked by uid 89); 16 Oct 2014 09:19:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f169.google.com Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 09:19:51 +0000 Received: by mail-vc0-f169.google.com with SMTP id hy4so2376596vcb.0 for ; Thu, 16 Oct 2014 02:19:49 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.220.94.71 with SMTP id y7mr6198vcm.77.1413451189365; Thu, 16 Oct 2014 02:19:49 -0700 (PDT) Received: by 10.31.130.194 with HTTP; Thu, 16 Oct 2014 02:19:49 -0700 (PDT) Date: Thu, 16 Oct 2014 09:25:00 -0000 Message-ID: Subject: [RFC PATCH, i386]: Remove special PIC related __cpuid definitions from config/i386/cpuid.h From: Uros Bizjak To: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=047d7b5d43140cf5d3050586c05a X-SW-Source: 2014-10/txt/msg01517.txt.bz2 --047d7b5d43140cf5d3050586c05a Content-Type: text/plain; charset=UTF-8 Content-length: 907 Hello! Now that %ebx is also allocatable in PIC modes, we can cleanup config/i386/cpuid considerably. I propose to remove all PIC related specializations of __cpuid and __cpuid_count and protect the compilation with "#if __GNUC__ >= 5". The only drawback would be that non-bootstrapped build with gcc < 5.0 will ignore -march=native, but I think this should be acceptable. Bootstrapped build will still work as expected. 2014-10-16 Uros Bizjak * config/i386/cpuid.h (__cpuid): Remove definitions that handle %ebx register in a special way. (__cpuid_count): Ditto. * config/i386/driver-i386.h: Protect with #if __GNUC__ >= 5. (host_detect_local_cpu): Mention that GCC that is able to handle %ebx register in PIC and non-PIC modes is required to compile the function. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Any comments? Uros. --047d7b5d43140cf5d3050586c05a Content-Type: text/plain; charset=US-ASCII; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i1bwblxp0 Content-length: 4710 SW5kZXg6IGNvbmZpZy9pMzg2L2NwdWlkLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gY29uZmlnL2kzODYvY3B1aWQuaAkocmV2aXNpb24gMjE2Mjgy KQorKysgY29uZmlnL2kzODYvY3B1aWQuaAkod29ya2luZyBjb3B5KQpAQCAt MTQ2LDU2ICsxNDYsNyBAQAogI2RlZmluZSBzaWduYXR1cmVfVk9SVEVYX2Vj eAkweDQzNmY1MzIwCiAjZGVmaW5lIHNpZ25hdHVyZV9WT1JURVhfZWR4CTB4 MzYzODc4NjUKIAotI2lmIGRlZmluZWQoX19pMzg2X18pICYmIGRlZmluZWQo X19QSUNfXykKLS8qICVlYnggbWF5IGJlIHRoZSBQSUMgcmVnaXN0ZXIuICAq LwotI2lmIF9fR05VQ19fID49IDMKICNkZWZpbmUgX19jcHVpZChsZXZlbCwg YSwgYiwgYywgZCkJCQlcCi0gIF9fYXNtX18gKCJ4Y2hne2x9XHR7JSV9ZWJ4 LCAlazFcblx0IgkJCVwKLQkgICAiY3B1aWRcblx0IgkJCQkJXAotCSAgICJ4 Y2hne2x9XHR7JSV9ZWJ4LCAlazFcblx0IgkJCVwKLQkgICA6ICI9YSIgKGEp LCAiPSZyIiAoYiksICI9YyIgKGMpLCAiPWQiIChkKQlcCi0JICAgOiAiMCIg KGxldmVsKSkKLQotI2RlZmluZSBfX2NwdWlkX2NvdW50KGxldmVsLCBjb3Vu dCwgYSwgYiwgYywgZCkJCVwKLSAgX19hc21fXyAoInhjaGd7bH1cdHslJX1l YngsICVrMVxuXHQiCQkJXAotCSAgICJjcHVpZFxuXHQiCQkJCQlcCi0JICAg InhjaGd7bH1cdHslJX1lYngsICVrMVxuXHQiCQkJXAotCSAgIDogIj1hIiAo YSksICI9JnIiIChiKSwgIj1jIiAoYyksICI9ZCIgKGQpCVwKLQkgICA6ICIw IiAobGV2ZWwpLCAiMiIgKGNvdW50KSkKLSNlbHNlCi0vKiBIb3N0IEdDQ3Mg b2xkZXIgdGhhbiAzLjAgd2VyZW4ndCBzdXBwb3J0aW5nIEludGVsIGFzbSBz eW50YXgKLSAgIG5vciBhbHRlcm5hdGl2ZXMgaW4gaTM4NiBjb2RlLiAgKi8K LSNkZWZpbmUgX19jcHVpZChsZXZlbCwgYSwgYiwgYywgZCkJCQlcCi0gIF9f YXNtX18gKCJ4Y2hnbFx0JSVlYngsICVrMVxuXHQiCQkJXAotCSAgICJjcHVp ZFxuXHQiCQkJCQlcCi0JICAgInhjaGdsXHQlJWVieCwgJWsxXG5cdCIJCQlc Ci0JICAgOiAiPWEiIChhKSwgIj0mciIgKGIpLCAiPWMiIChjKSwgIj1kIiAo ZCkJXAotCSAgIDogIjAiIChsZXZlbCkpCi0KLSNkZWZpbmUgX19jcHVpZF9j b3VudChsZXZlbCwgY291bnQsIGEsIGIsIGMsIGQpCQlcCi0gIF9fYXNtX18g KCJ4Y2hnbFx0JSVlYngsICVrMVxuXHQiCQkJXAotCSAgICJjcHVpZFxuXHQi CQkJCQlcCi0JICAgInhjaGdsXHQlJWVieCwgJWsxXG5cdCIJCQlcCi0JICAg OiAiPWEiIChhKSwgIj0mciIgKGIpLCAiPWMiIChjKSwgIj1kIiAoZCkJXAot CSAgIDogIjAiIChsZXZlbCksICIyIiAoY291bnQpKQotI2VuZGlmCi0jZWxp ZiBkZWZpbmVkKF9feDg2XzY0X18pICYmIChkZWZpbmVkKF9fY29kZV9tb2Rl bF9tZWRpdW1fXykgfHwgZGVmaW5lZChfX2NvZGVfbW9kZWxfbGFyZ2VfXykp ICYmIGRlZmluZWQoX19QSUNfXykKLS8qICVyYnggbWF5IGJlIHRoZSBQSUMg cmVnaXN0ZXIuICAqLwotI2RlZmluZSBfX2NwdWlkKGxldmVsLCBhLCBiLCBj LCBkKQkJCVwKLSAgX19hc21fXyAoInhjaGd7cX1cdHslJX1yYngsICVxMVxu XHQiCQkJXAotCSAgICJjcHVpZFxuXHQiCQkJCQlcCi0JICAgInhjaGd7cX1c dHslJX1yYngsICVxMVxuXHQiCQkJXAotCSAgIDogIj1hIiAoYSksICI9JnIi IChiKSwgIj1jIiAoYyksICI9ZCIgKGQpCVwKLQkgICA6ICIwIiAobGV2ZWwp KQotCi0jZGVmaW5lIF9fY3B1aWRfY291bnQobGV2ZWwsIGNvdW50LCBhLCBi LCBjLCBkKQkJXAotICBfX2FzbV9fICgieGNoZ3txfVx0eyUlfXJieCwgJXEx XG5cdCIJCQlcCi0JICAgImNwdWlkXG5cdCIJCQkJCVwKLQkgICAieGNoZ3tx fVx0eyUlfXJieCwgJXExXG5cdCIJCQlcCi0JICAgOiAiPWEiIChhKSwgIj0m ciIgKGIpLCAiPWMiIChjKSwgIj1kIiAoZCkJXAotCSAgIDogIjAiIChsZXZl bCksICIyIiAoY291bnQpKQotI2Vsc2UKLSNkZWZpbmUgX19jcHVpZChsZXZl bCwgYSwgYiwgYywgZCkJCQlcCiAgIF9fYXNtX18gKCJjcHVpZFxuXHQiCQkJ CQlcCiAJICAgOiAiPWEiIChhKSwgIj1iIiAoYiksICI9YyIgKGMpLCAiPWQi IChkKQlcCiAJICAgOiAiMCIgKGxldmVsKSkKQEAgLTIwNCw4ICsxNTUsOCBA QAogICBfX2FzbV9fICgiY3B1aWRcblx0IgkJCQkJXAogCSAgIDogIj1hIiAo YSksICI9YiIgKGIpLCAiPWMiIChjKSwgIj1kIiAoZCkJXAogCSAgIDogIjAi IChsZXZlbCksICIyIiAoY291bnQpKQotI2VuZGlmCiAKKwogLyogUmV0dXJu IGhpZ2hlc3Qgc3VwcG9ydGVkIGlucHV0IHZhbHVlIGZvciBjcHVpZCBpbnN0 cnVjdGlvbi4gIGV4dCBjYW4KICAgIGJlIGVpdGhlciAweDAgb3IgMHg4MDAw MDAwIHRvIHJldHVybiBoaWdoZXN0IHN1cHBvcnRlZCB2YWx1ZSBmb3IKICAg IGJhc2ljIG9yIGV4dGVuZGVkIGNwdWlkIGluZm9ybWF0aW9uLiAgRnVuY3Rp b24gcmV0dXJucyAwIGlmIGNwdWlkCkluZGV4OiBjb25maWcvaTM4Ni9kcml2 ZXItaTM4Ni5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbmZpZy9p Mzg2L2RyaXZlci1pMzg2LmMJKHJldmlzaW9uIDIxNjI4MikKKysrIGNvbmZp Zy9pMzg2L2RyaXZlci1pMzg2LmMJKHdvcmtpbmcgY29weSkKQEAgLTI0LDcg KzI0LDcgQEAgYWxvbmcgd2l0aCBHQ0M7IHNlZSB0aGUgZmlsZSBDT1BZSU5H My4gIElmIG5vdCBzZWUKIAogY29uc3QgY2hhciAqaG9zdF9kZXRlY3RfbG9j YWxfY3B1IChpbnQgYXJnYywgY29uc3QgY2hhciAqKmFyZ3YpOwogCi0jaWZk ZWYgX19HTlVDX18KKyNpZiBfX0dOVUNfXyA+PSA1CiAjaW5jbHVkZSAiY3B1 aWQuaCIKIAogc3RydWN0IGNhY2hlX2Rlc2MKQEAgLTk0Miw5ICs5NDIsMTAg QEAgZG9uZToKIH0KICNlbHNlCiAKLS8qIElmIHdlIGFyZW4ndCBjb21waWxp bmcgd2l0aCBHQ0MgdGhlbiB0aGUgZHJpdmVyIHdpbGwganVzdCBpZ25vcmUK LSAgIC1tYXJjaCBhbmQgLW10dW5lICJuYXRpdmUiIHRhcmdldCBhbmQgd2ls bCBsZWF2ZSB0byB0aGUgbmV3bHkKLSAgIGJ1aWx0IGNvbXBpbGVyIHRvIGdl bmVyYXRlIGNvZGUgZm9yIGl0cyBkZWZhdWx0IHRhcmdldC4gICovCisvKiBJ ZiB3ZSBhcmVuJ3QgY29tcGlsaW5nIHdpdGggR0NDIHRoYXQgaXMgYWJsZSB0 byBoYW5kbGUgJUVCWAorICAgcmVnaXN0ZXIgaW4gUElDIGFuZCBub24tUElD IG1vZGVzLCB0aGVuIHRoZSBkcml2ZXIgd2lsbCBqdXN0CisgICBpZ25vcmUg LW1hcmNoIGFuZCAtbXR1bmUgIm5hdGl2ZSIgdGFyZ2V0IGFuZCB3aWxsIGxl YXZlIHRvIHRoZQorICAgbmV3bHkgYnVpbHQgY29tcGlsZXIgdG8gZ2VuZXJh dGUgY29kZSBmb3IgaXRzIGRlZmF1bHQgdGFyZ2V0LiAgKi8KIAogY29uc3Qg Y2hhciAqaG9zdF9kZXRlY3RfbG9jYWxfY3B1IChpbnQsIGNvbnN0IGNoYXIg KiopCiB7Cg== --047d7b5d43140cf5d3050586c05a--