From: Uros Bizjak <ubizjak@gmail.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [PATCH] Make wider use of "v" constraint in i386.md
Date: Fri, 17 Apr 2015 08:10:00 -0000 [thread overview]
Message-ID: <CAFULd4ZfsL6d2WN27frAgtVVAeJeuG=315X2FMkSCrDW4fnv_A@mail.gmail.com> (raw)
In-Reply-To: <20150319092404.GA73948@msticlxl7.ims.intel.com>
On Thu, Mar 19, 2015 at 10:24 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> Hi,
>
> There were some discussion about "x" constraints being too conservative
> for some patterns in i386.md.
> Patch below fixes it. This is probably stage1 material.
>
> ChangeLog:
>
> gcc/
>
> 2015-03-19 Ilya Tocar <ilya.tocar@intel.com>
>
> * config/i386/i386.h (EXT_SSE_REG_P): New.
> * config/i386/i386.md (*cmpi<FPCMP:unord><MODEF:mode>_mixed): Use "v"
> constraint.
> (*cmpi<FPCMP:unord><MODEF:mode>_sse): Ditto.
> (*movxi_internal_avx512f): Ditto.
> (define_split): Check for xmm16+, when splitting scalar float_extend.
> (*extendsfdf2_mixed): Use "v" constraint.
> (*extendsfdf2_sse): Ditto.
> (define_split): Check for xmm16+, when splitting scalar float_truncate.
> (*truncdfsf_fast_sse): Use "v" constraint.
> (fix_trunc<MODEF:mode><SWI48:mode>_sse): Ditto.
> (*float<SWI48:mode><MODEF:mode>2_sse): Ditto.
> (define_peephole2): Check for xmm16+, when converting scalar
> float_truncate.
> (define_peephole2): Check for xmm16+, when converting scalar
> float_extend.
> (*fop_<mode>_comm_mixed): Use "v" constraint.
> (*fop_<mode>_comm_sse): Ditto.
> (*fop_<mode>_1_mixed): Ditto.
> (*sqrt<mode>2_sse): Ditto.
> (*ieee_s<ieee_maxmin><mode>3): Ditto.
I wonder if there are also changes needed in mmx.md. There are a
couple of patterns that operate on xmm registers, so they should be
reviewed if they need to change their constraint to "v" to accept
extended xmm register set.
Uros.
next prev parent reply other threads:[~2015-04-17 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 9:24 Ilya Tocar
[not found] ` <20150323160222.GB10265@msticlxl7.ims.intel.com>
2015-03-24 13:43 ` Kirill Yukhin
2015-04-28 16:22 ` [PATCH, PR65915] Fix float conversion split Ilya Tocar
2015-04-28 16:59 ` H.J. Lu
2015-04-30 15:18 ` Ilya Tocar
2015-04-30 15:22 ` H.J. Lu
2015-05-04 8:08 ` Uros Bizjak
2015-05-05 13:03 ` Ilya Tocar
2015-05-05 13:13 ` Uros Bizjak
2015-04-17 8:10 ` Uros Bizjak [this message]
2015-04-27 15:28 ` [PATCH] Make wider use of "v" constraint in i386.md Ilya Tocar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4ZfsL6d2WN27frAgtVVAeJeuG=315X2FMkSCrDW4fnv_A@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kirill.yukhin@gmail.com \
--cc=tocarip.intel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).