public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: Evgeny Karpov <Evgeny.Karpov@microsoft.com>
Cc: "hubicka@ucw.cz" <hubicka@ucw.cz>,
	Richard Sandiford <richard.sandiford@arm.com>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	 "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
	 Radek Barton <radek.barton@microsoft.com>
Subject: Re: [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw
Date: Thu, 23 May 2024 10:41:38 +0200	[thread overview]
Message-ID: <CAFULd4ZfxOKroooe+NJtBmQqGTb9CDS0XAd6oEfjMn9AU10DTw@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4ap0bDH0MpAh5E-BNArESpVYv7bRKXb3N_bakmjBTOPdw@mail.gmail.com>

On Thu, May 23, 2024 at 10:35 AM Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Wed, May 22, 2024 at 4:32 PM Evgeny Karpov
> <Evgeny.Karpov@microsoft.com> wrote:
> >
> > Wednesday, May 22, 2024 1:06 PM
> > Richard Sandiford <richard.sandiford@arm.com> wrote:
> >
> > > This looks good to me apart from a couple of very minor comments below, but
> > > please get approval from the x86 maintainers as well.  In particular, they might
> > > prefer to handle ix86_legitimize_pe_coff_symbol in some other way.
> >
> > Thanks, Richard, for the review!
> > The suggestions will be addressed in the next version.
> >
> > Jan and Uros, could you please review x86 refactoring for mingw part? Thanks.
>
> Yes, perhaps legitimize_pe_coff_symbol should be handled similar to
> how machopic_legitimize_pic_address is handled.and just use "#if
> TARGET_PECOFF" at call sites when calling functions from the new
> winnt-dll.h. This would also allow us to remove  the early check for
> !TARGET_PECOFF in legitimize_pe_coff_symbol.

Maybe you should look how TARGET_MACHO is handled in config/i386/* files.

Uros.

  reply	other threads:[~2024-05-23  8:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 21:35 [PATCH v1 0/6] Add DLL import/export implementation to AArch64 Evgeny Karpov
2024-04-18 21:41 ` [PATCH v1 1/6] Move mingw_* declarations to the mingw folder Evgeny Karpov
2024-04-18 21:43 ` [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw Evgeny Karpov
2024-05-22 11:05   ` Richard Sandiford
2024-05-22 14:32     ` Evgeny Karpov
2024-05-23  8:35       ` Uros Bizjak
2024-05-23  8:41         ` Uros Bizjak [this message]
2024-05-23 17:53         ` Evgeny Karpov
2024-05-23 19:37           ` Uros Bizjak
2024-04-18 21:45 ` [PATCH v1 3/6] Rename functions for reuse in AArch64 Evgeny Karpov
2024-05-22 11:46   ` Richard Sandiford
2024-04-18 21:46 ` [PATCH v1 4/6] aarch64: Add selectany attribute handling Evgeny Karpov
2024-05-22 11:57   ` Richard Sandiford
2024-04-18 21:48 ` [PATCH v1 5/6] Adjust DLL import/export implementation for AArch64 Evgeny Karpov
2024-05-22 12:07   ` Richard Sandiford
2024-04-18 21:49 ` [PATCH v1 6/6] aarch64: Add DLL import/export to AArch64 target Evgeny Karpov
2024-06-04 20:10 ` [PATCH v1 0/6] Add DLL import/export implementation to AArch64 Evgeny Karpov
2024-06-05  6:01   ` Uros Bizjak
2024-06-05 23:41     ` Jonathan Yong
2024-06-06  9:23       ` Evgeny Karpov
2024-06-08  1:59         ` Jonathan Yong
2024-06-05  8:13   ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFULd4ZfxOKroooe+NJtBmQqGTb9CDS0XAd6oEfjMn9AU10DTw@mail.gmail.com \
    --to=ubizjak@gmail.com \
    --cc=Evgeny.Karpov@microsoft.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=radek.barton@microsoft.com \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).