From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 211B53858D33 for ; Thu, 23 May 2024 08:41:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 211B53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 211B53858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716453714; cv=none; b=C9wXJNubKbcCZ2UiMX+IKCuCsrPg7l8g3iHoiW6XhQ+lP5MzHwcuho9+xU7a26/zfAO2fYxRBrkL82tlSGwj74dkbjFKbiPIBAoodWYcUgVlCj8cu5VjUzde5Wres9gjkPcU/0JOL3FmJmG04tFfLkaNOZUMFBwSeh/WeqgUTXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716453714; c=relaxed/simple; bh=tgr8PMvBIoXy65QAo5hFmAFCVHmrO6E8aMTR2jh9rnM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=QWwlF1IUl7YA/M7bBPd+WhrbpXWAPxEAWpEe9+0zYm/i1MBpaIv3x50B6Y804blkoU9aN93dYOHBzZ5ihR16H5VVb3C31s4/PvFA2GomUIol53Hl6RiBT8BbIxXuf2KowIosTgsgVwo14CnPxLn3bSmY+uzQTdE6zOWgj7HiLg4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2e271acb015so96531321fa.1 for ; Thu, 23 May 2024 01:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716453710; x=1717058510; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MTJuO7ca+cX970BOimTEsRcY1CMBSnPZbfQ1u0pI0TM=; b=TxJ/3gCTyNnpj5hYkgsofUEYsCs0JdFMBkR/1mDcNQe9/NeUTS7kjhfDziuXL1w71v wt9mo6Wvb6bloKcwYFULls3Fhf/XEC7F9yXi6Ub0gCLle6SD5eXeA6x7w4jC+u53LuEq yU9jtOuA4dnvgWgl/65GoAAyX+q8lV4Oit3D2ULjeEBcEzrfL2bXGhh29cY+7KCHC4cM laYesm10P0Pb4jkm0OgmB02H9QD3UGAGD1pexT1mMDyphOF8EqSiDdciRweZ0+NAPmUn n7CBGO/uQG9dcEXbBkA330dVeiHcXSbQ5WS+jORU3rKSODc4yX+8uxHe4+plmoSKt1Zb FIMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716453710; x=1717058510; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MTJuO7ca+cX970BOimTEsRcY1CMBSnPZbfQ1u0pI0TM=; b=O/550F5HPYvuztHsJIFDFHrtzRmpmyDFOrOyOFbTIyudTyw4ye7390OYuGCFZD/muO aSAhs9i2O312hbRnzHY6SMDuZBYHlxydMzVvAKPPg6MFhG/8MFZVGI/mVPPOu+5n1RsO m+7zXbZ7okkAd6K7mxtsawksvIhZJ3uMIv9oT0nBKQMobOldMWQ6v8IAkyTO1Sqk47d4 OypxeK0J0XSBwd7pHq2sY6vpIB05q1mOGPKpwlk+BOyKPEMUQrxukaF9Fin8bHTfyG7V BI6kopzytmgOjpp31JSeh9S7tJrUng1JqABIDnEu6bk++xLnpD2vKFkbPYI83f2E8rDW 8asw== X-Forwarded-Encrypted: i=1; AJvYcCUb75CMnas7r3oqfdn73rcSzaH0rhd7Tj7/RI++JYvLnlaFU+9ADH2mx9bfANXxkKLhuKJmGcNroi5PpHatVuvza7Dr+myuUQ== X-Gm-Message-State: AOJu0YxkIDC/6YqfSs5dmCH3UWpTaDJOS2hliwOPttJWlNxW1P/Rcg2Y QQJyTFwdoUI+t2P7oP+zq5gq85IjagPUpEM3W8ByOoeE+cgTTE6Jd1JkOgbwfoaSV80OSeK9927 bI+DSP+u8dfGF+YrLGkthEa3mkUA= X-Google-Smtp-Source: AGHT+IFFCkyhWJlkTxPOs/3J/r3khcarPMFeWlwoCgpMnSITB2vhz1/xIdN86xlJP1cqCpPCLymVhNrXimB8aA9cu1s= X-Received: by 2002:a05:651c:11c6:b0:2df:907e:6de3 with SMTP id 38308e7fff4ca-2e949567269mr24868821fa.35.1716453710290; Thu, 23 May 2024 01:41:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Thu, 23 May 2024 10:41:38 +0200 Message-ID: Subject: Re: [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw To: Evgeny Karpov Cc: "hubicka@ucw.cz" , Richard Sandiford , "gcc-patches@gcc.gnu.org" , "Richard Earnshaw (lists)" , Maxim Kuvyrkov , Radek Barton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 23, 2024 at 10:35=E2=80=AFAM Uros Bizjak wr= ote: > > On Wed, May 22, 2024 at 4:32=E2=80=AFPM Evgeny Karpov > wrote: > > > > Wednesday, May 22, 2024 1:06 PM > > Richard Sandiford wrote: > > > > > This looks good to me apart from a couple of very minor comments belo= w, but > > > please get approval from the x86 maintainers as well. In particular,= they might > > > prefer to handle ix86_legitimize_pe_coff_symbol in some other way. > > > > Thanks, Richard, for the review! > > The suggestions will be addressed in the next version. > > > > Jan and Uros, could you please review x86 refactoring for mingw part? T= hanks. > > Yes, perhaps legitimize_pe_coff_symbol should be handled similar to > how machopic_legitimize_pic_address is handled.and just use "#if > TARGET_PECOFF" at call sites when calling functions from the new > winnt-dll.h. This would also allow us to remove the early check for > !TARGET_PECOFF in legitimize_pe_coff_symbol. Maybe you should look how TARGET_MACHO is handled in config/i386/* files. Uros.