public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: Don't enable -fprefetch-loop-arrays for TARGET_SOFTWARE_PREFETCHING_BENEFICIAL if -Os
Date: Fri, 10 Apr 2015 06:35:00 -0000	[thread overview]
Message-ID: <CAFULd4Zg_-UkbRFNRQKv=_YnyFUuv4UUWgv8Zc7Hq5XdPM_uuA@mail.gmail.com> (raw)

Hello!

> Testing an x86_64 toolchain configured for a processor with
> TARGET_SOFTWARE_PREFETCHING_BENEFICIAL produces failures
>
> FAIL: g++.dg/pr60518.C  -std=gnu++98 (test for excess errors)
> FAIL: g++.dg/pr60518.C  -std=gnu++11 (test for excess errors)
> FAIL: g++.dg/pr60518.C  -std=gnu++14 (test for excess errors)
>
> where the failure is from the message "pr60518.C:1:0: warning:
> -fprefetch-loop-arrays is not supported with -Os".
>
> Given that lack of support, it seems appropriate for the back end not
> to enable this option in the -Os case; this patch implements that.
>
> Bootstrapped with no regressions on x86_64-unknown-linux-gnu; tested
> for a cross to x86_64-linux-gnu --with-arch=btver2, where those test
> failures duly disappear.  OK to commit?
>
> 2015-04-09  Joseph Myers  <joseph@codesourcery.com>
>
>    * config/i386/i386.c (ix86_option_override_internal): Don't set
>    -fprefetch-loop-arrays if optimizing for size.

OK.

Thanks,
Uros.

             reply	other threads:[~2015-04-10  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  6:35 Uros Bizjak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-04-09 22:06 Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFULd4Zg_-UkbRFNRQKv=_YnyFUuv4UUWgv8Zc7Hq5XdPM_uuA@mail.gmail.com' \
    --to=ubizjak@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).