From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71159 invoked by alias); 10 Apr 2015 06:35:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71145 invoked by uid 89); 10 Apr 2015 06:35:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vn0-f48.google.com Received: from mail-vn0-f48.google.com (HELO mail-vn0-f48.google.com) (209.85.216.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 10 Apr 2015 06:35:15 +0000 Received: by vnbg7 with SMTP id g7so3157942vnb.11 for ; Thu, 09 Apr 2015 23:35:13 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.158.202 with SMTP id ww10mr96797oeb.18.1428647713368; Thu, 09 Apr 2015 23:35:13 -0700 (PDT) Received: by 10.60.168.19 with HTTP; Thu, 9 Apr 2015 23:35:13 -0700 (PDT) Date: Fri, 10 Apr 2015 06:35:00 -0000 Message-ID: Subject: Re: Don't enable -fprefetch-loop-arrays for TARGET_SOFTWARE_PREFETCHING_BENEFICIAL if -Os From: Uros Bizjak To: "gcc-patches@gcc.gnu.org" Cc: "Joseph S. Myers" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-04/txt/msg00431.txt.bz2 Hello! > Testing an x86_64 toolchain configured for a processor with > TARGET_SOFTWARE_PREFETCHING_BENEFICIAL produces failures > > FAIL: g++.dg/pr60518.C -std=gnu++98 (test for excess errors) > FAIL: g++.dg/pr60518.C -std=gnu++11 (test for excess errors) > FAIL: g++.dg/pr60518.C -std=gnu++14 (test for excess errors) > > where the failure is from the message "pr60518.C:1:0: warning: > -fprefetch-loop-arrays is not supported with -Os". > > Given that lack of support, it seems appropriate for the back end not > to enable this option in the -Os case; this patch implements that. > > Bootstrapped with no regressions on x86_64-unknown-linux-gnu; tested > for a cross to x86_64-linux-gnu --with-arch=btver2, where those test > failures duly disappear. OK to commit? > > 2015-04-09 Joseph Myers > > * config/i386/i386.c (ix86_option_override_internal): Don't set > -fprefetch-loop-arrays if optimizing for size. OK. Thanks, Uros.