From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Guenther <rguenther@suse.de>
Subject: [PATCH]: Increase MAX_ARTIFICIAL_LABEL_BYTES to 40
Date: Wed, 23 Aug 2017 16:35:00 -0000 [thread overview]
Message-ID: <CAFULd4Zgg1o=5uP1iNzuNxhjB5dJREkYNtnm4Jq21CTmnqCLPg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2826 bytes --]
Hello!
Recent changes caused bootstrap on alpha with:
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c: In function ‘void
init_sections_and_labels(bool)’:
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:27181:1: error:
‘%ld’ directive writing between 1 and 10 bytes into a region of size 8
[-Werror=format-overflow=]
init_sections_and_labels (bool early_lto_debug)
^~~~~~~~~~~~~~~~~~~~~~~~
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:27181:1: note:
directive argument in the range [0, 4294967295]
In file included from ./tm.h:25:0,
from /space/homedirs/uros/gcc-svn/trunk/gcc/target.h:52,
from /space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:61:
/space/homedirs/uros/gcc-svn/trunk/gcc/config/alpha/alpha.h:958:11:
note: ‘sprintf’ output between 24 and 33 bytes into a destination of
size 30
sprintf ((LABEL), "*$%s%ld", (PREFIX), (long)(NUM))
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:27207:4: note: in
expansion of macro ‘ASM_GENERATE_INTERNAL_LABEL’
ASM_GENERATE_INTERNAL_LABEL (debug_skeleton_line_section_label,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:27181:1: error:
‘%ld’ directive writing between 1 and 10 bytes into a region of size 6
[-Werror=format-overflow=]
init_sections_and_labels (bool early_lto_debug)
^~~~~~~~~~~~~~~~~~~~~~~~
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:27181:1: note:
directive argument in the range [0, 4294967295]
In file included from ./tm.h:25:0,
from /space/homedirs/uros/gcc-svn/trunk/gcc/target.h:52,
from /space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:61:
/space/homedirs/uros/gcc-svn/trunk/gcc/config/alpha/alpha.h:958:11:
note: ‘sprintf’ output between 26 and 35 bytes into a destination of
size 30
sprintf ((LABEL), "*$%s%ld", (PREFIX), (long)(NUM))
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/space/homedirs/uros/gcc-svn/trunk/gcc/dwarf2out.c:27226:4: note: in
expansion of macro ‘ASM_GENERATE_INTERNAL_LABEL’
ASM_GENERATE_INTERNAL_LABEL (debug_skeleton_abbrev_section_label,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
These new debug_skeleton_* section names are quite long, and together
with numerical value they don't fit anymore into the array with
MAX_ARTIFICIAL_LABEL_BYTES size.
The solution is to increase MAX_ARTIFICIAL_LABEL_BYTES value from 30 to 40.
The patch also removes unneeded definition from dwarf2cfi.c
2017-08-23 Uros Bizjak <ubizjak@gmail.com>
* dwarf2out.c (MAX_ARTIFICIAL_LABEL_BYTES): Increase to 40.
* dwarf2cfi.c (MAX_ARTIFICIAL_LABEL_BYTES): Remove.
Patch restores bootstrap on alphaev68-linux-gnu.
OK for mainline?
Uros.
[-- Attachment #2: a.diff.txt --]
[-- Type: text/plain, Size: 1001 bytes --]
Index: dwarf2cfi.c
===================================================================
--- dwarf2cfi.c (revision 251310)
+++ dwarf2cfi.c (working copy)
@@ -52,9 +52,6 @@
#ifndef INCOMING_RETURN_ADDR_RTX
#define INCOMING_RETURN_ADDR_RTX (gcc_unreachable (), NULL_RTX)
#endif
-
-/* Maximum size (in bytes) of an artificially generated label. */
-#define MAX_ARTIFICIAL_LABEL_BYTES 30
\f
/* A collected description of an entire row of the abstract CFI table. */
struct GTY(()) dw_cfi_row
Index: dwarf2out.c
===================================================================
--- dwarf2out.c (revision 251310)
+++ dwarf2out.c (working copy)
@@ -178,7 +178,7 @@
static GTY(()) section *debug_frame_section;
/* Maximum size (in bytes) of an artificially generated label. */
-#define MAX_ARTIFICIAL_LABEL_BYTES 30
+#define MAX_ARTIFICIAL_LABEL_BYTES 40
/* According to the (draft) DWARF 3 specification, the initial length
should either be 4 or 12 bytes. When it's 12 bytes, the first 4
next reply other threads:[~2017-08-23 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 16:35 Uros Bizjak [this message]
2017-08-23 16:59 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Zgg1o=5uP1iNzuNxhjB5dJREkYNtnm4Jq21CTmnqCLPg@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).