From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id 86C433949F28 for ; Mon, 5 Dec 2022 21:07:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 86C433949F28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-3704852322fso131557747b3.8 for ; Mon, 05 Dec 2022 13:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6NFHVtEFafPsR9FsSS7xf1vHCUqbNd1ACY39k40ywBQ=; b=VpE9oDMLR0r5BP7+2cT+oN/+Ayes9o+fTj+9lf6ihiTqgcwFp+BXvCKaUaOX6EHQPC i2dPkpLDTC5XK1dhON9okP5Xjyd6p85eztcyYTNJYMmkAsJaDH+TuS7j0BNaLOUSdcon 3lnm2FpXiexrwLlbOsnGH1d2+HBLyZ6fdd2Wq2aCpviRVsbguJRQLbMY9xHz5/J9uSgG +MIYZR7TcKarBrT9UFzpd4BSwWFfF7AgF8IJfqFFWvgbNWIEWvv+EePHhKtnBYQ4aphy vWz5EULcUxJKJC3ErUUxnjrqM1tLCmd3nS8r+IV1ODX7PHcYiQojGK8f62UpZdB7xGOa FoLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6NFHVtEFafPsR9FsSS7xf1vHCUqbNd1ACY39k40ywBQ=; b=i1fXlt1e7WA0DedDhCMh73R4Mx+n/JdFIb3e5MGXGwVns8eDoqO051GHWFUNrw7R7o 6NAGClL7scKqCAyOOSmplFzUcxDewVkklXVgJVrsJDXtTjuDhlRBMmwRzb2Z8ZQj8778 SckkZ8R9KOEbsDvXYn+ZDJQJVZ6zD/fUCx7FEWhvL0ZT+q90/6lm9oZ7FCYHkkxG9cJt i5WZikzegw/cOrkv/Q0p6Hcxh+D02Koqn3sTtsuya1gl2l1PMcBl/nj66LbD2Dbbh04d 2/WsgO2s4Yduow0B7vQKBI3CBo8l3fbILjHOq063dg7WvHesK80J1ZO26aT5mt2aG+lE pw+g== X-Gm-Message-State: ANoB5pkxx0OSr1/T3yxwn8i7J1wskUlC8TNUR7Oh3zALlnnCaxj7rZbn +sJ4PQ/JHMmrujVzzI0weGCNkKvCN/7AlYhfjCE= X-Google-Smtp-Source: AA0mqf52vvTP6XZ2zTnc9Y5H6wdtrEZhrmax1MouqLJvla+oWTWF4R6MC8D0vk30QbEaX41P/E5sfjtcUB0R3rRSItg= X-Received: by 2002:a0d:df49:0:b0:3e4:f2f8:4ada with SMTP id i70-20020a0ddf49000000b003e4f2f84adamr11232660ywe.429.1670274471602; Mon, 05 Dec 2022 13:07:51 -0800 (PST) MIME-Version: 1.0 References: <20221204115150.35508-1-iain@sandoe.co.uk> <47BE3C16-6C72-4F13-94D7-9754BD3DEE77@sandoe.co.uk> In-Reply-To: From: Uros Bizjak Date: Mon, 5 Dec 2022 22:07:40 +0100 Message-ID: Subject: Re: [PATCH] testsuite, X86, Darwin: Fix bf16 ABI tests for Mach-O/macOS ABI. To: Iain Sandoe Cc: GCC Patches , crazylht@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 5, 2022 at 3:54 PM Iain Sandoe wrote: > > Hi Uros, > > > On 5 Dec 2022, at 10:37, Uros Bizjak via Gcc-patches wrote: > > > > On Sun, Dec 4, 2022 at 9:30 PM Iain Sandoe wrote: > >> > > >> gcc/testsuite/ChangeLog: > >> > >> * gcc.target/x86_64/abi/bf16/args.h: Make xmm_regs, x87_regs ex= tern. > >> * gcc.target/x86_64/abi/bf16/m256bf16/args.h: Likewise. > >> * gcc.target/x86_64/abi/bf16/m512bf16/args.h: Likewise. > >> * gcc.target/x86_64/abi/bf16/asm-support.S: Add Mach-O variant. > >> * gcc.target/x86_64/abi/bf16/m256bf16/asm-support.S: Likewise. > >> * gcc.target/x86_64/abi/bf16/m512bf16/asm-support.S: Likewise. > > > > Please note that in other directories asm-support-darwin.s is > > introduced and included via .exp file. Is there a reason a different > > approach is introduced here? > > Since it seems that testcases get added and amended without considering a= ny > sub-target apart from x86_64-linux-gnu (even by very experienced contribu= tors), > I was hoping that the Darwin section might prompt folks to remember that = there > are several other sub-targets. > > However, the main thing is to fix the tests .. so here=E2=80=99s a versio= n using separate > files. extern void (*callthis)(void); extern unsigned long long rax,rbx,rcx,rdx,rsi,rdi,rsp,rbp,r8,r9,r10,r11,r12,r13,r14,r15; -XMM_T xmm_regs[16]; -X87_T x87_regs[8]; +extern XMM_T xmm_regs[16]; +extern X87_T x87_regs[8]; Do you still need this change? Existing test files are compiled without ext= ern. + .globl _callthis + .zerofill __DATA,__bss,_callthis,8,3 + .globl _rax + .zerofill __DATA,__bss,_rax,8,3 + .globl _rbx + .zerofill __DATA,__bss,_rbx,8,3 + .globl _rcx + .zerofill __DATA,__bss,_rcx,8,3 + .globl _rdx + .zerofill __DATA,__bss,_rdx,8,3 ... I wonder if the above approach is better than existing: .comm _callthis,8 .comm _rax,8 .comm _rbx,8 .comm _rcx,8 .comm _rdx,8 ... It is strange to have two different approaches for similar tests. If the new approach is better, we should also change existing asm-support files. Uros.