From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 1D8B43858D32 for ; Fri, 13 Jan 2023 06:58:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D8B43858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb36.google.com with SMTP id 20so2298752ybl.0 for ; Thu, 12 Jan 2023 22:58:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lnVptM5G156xQThap9cjpeFHOh1SJ1GBw0XtPB5uqvE=; b=gzCdL12eLvtxPGohXtbidgHxA6aDH5kH7xlv/EQ+znoftD+9jGqGHXgOArzsrUue9m kDmk1l/ftMvqHtIGkFUHJ0nzloWPjFJVNMPhqd/B+Hgqt0n40sPnSzSJVK8xgltetP1F uOhmMyH0QmDUn+kxSk1GMu27CDQV7DItmgDY0i+FAazvUGKO7u+/d8ydvDpJ1ydZ3gde atlPV1Q6B0FU6rUoeQJf1rflyJCKrssO2muspKZyQqPRBBmokYwbOxxg3ybGfaoGider 74DKnzIxyYtDj6bBj+kXdza5PRYePw3rnx/SLDmqURsjIk48paWFbgTse1ZA0+xAbKYn /vkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lnVptM5G156xQThap9cjpeFHOh1SJ1GBw0XtPB5uqvE=; b=ugVSeCl/4QryDIafoPmaAxWV2sjLqVNsQwtYnVMJgcMELuBFUazWrlsllvsmc7XX/Y wfywV0gcr8xTXVmrBE0dUDZPRUxSY6QV5JcK4aaDmNrucnBqe8pM3s1jrWLvU2yoqcHN vTtIiz1y0jXyRWb3M1l6xPbsSkSInWUskmCVtkx7PZQGexui08rj8RolLdNnPbsLjITp CtI09BgRU3tnG+/wMDGexj0AA4LGnYQeM+GJH9Em3ZARPpSvnnpZzrbOJUUwNoS1zXFp RCXj0QNhL659Gv58lLCg0qmjoO9C00nEz2gH1slB5VaAqBD7cQSnRiS3EgRsBbJ4sHTd IChQ== X-Gm-Message-State: AFqh2kqSUNeOKdOQ+px/K2iu/dq66sh+tK0oOn3mGPNcjfxW9KYi5QzP C87r1VN77fWTVzKPPnfPhbVT1/TK8uYUiKxXq96vSEoo0Pw= X-Google-Smtp-Source: AMrXdXszy/jbEJI2XoKTiPd1grNYxXKAM3Ggr9/qWUjSiqwCv4dUvEko1Fh5Jo/fvcNDviRzMw7MghZO+jfEkASs03c= X-Received: by 2002:a5b:ccc:0:b0:7b5:b5c6:9439 with SMTP id e12-20020a5b0ccc000000b007b5b5c69439mr2295006ybr.383.1673593098344; Thu, 12 Jan 2023 22:58:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Fri, 13 Jan 2023 07:58:07 +0100 Message-ID: Subject: Re: [PATCH] x86: Avoid -Wuninitialized warnings on _mm*_undefined_* in C++ [PR105593] To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 13, 2023 at 1:36 AM Jakub Jelinek wrote: > > Hi! > > In https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609844.html > I've posted a patch to allow ignoring -Winit-self using GCC diagnostic > pragmas, such that one can mark self-initialization as intentional > disabling of -Wuninitialized warnings. > > The following incremental patch uses that in the x86 intrinsic > headers. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk > if the above mentioned patch is approved/committed? > > 2023-01-13 Jakub Jelinek > > PR c++/105593 > gcc/ > * config/i386/xmmintrin.h (_mm_undefined_ps): Temporarily > disable -Winit-self using pragma GCC diagnostic ignored. > * config/i386/emmintrin.h (_mm_undefined_pd, _mm_undefined_si128): > Likewise. > * config/i386/avxintrin.h (_mm256_undefined_pd, _mm256_undefined_ps, > _mm256_undefined_si256): Likewise. > * config/i386/avx512fintrin.h (_mm512_undefined_pd, > _mm512_undefined_ps, _mm512_undefined_epi32): Likewise. > * config/i386/avx512fp16intrin.h (_mm_undefined_ph, > _mm256_undefined_ph, _mm512_undefined_ph): Likewise. > gcc/testsuite/ > * g++.target/i386/pr105593.C: New test. LGTM. Thanks, Uros. > > --- gcc/config/i386/xmmintrin.h.jj 2022-11-07 10:30:42.741629972 +0100 > +++ gcc/config/i386/xmmintrin.h 2023-01-12 15:33:21.685483809 +0100 > @@ -112,7 +112,10 @@ typedef float __v4sf __attribute__ ((__v > extern __inline __m128 __attribute__((__gnu_inline__, __always_inline__, __artificial__)) > _mm_undefined_ps (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m128 __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > --- gcc/config/i386/emmintrin.h.jj 2022-03-14 14:48:04.299055735 +0100 > +++ gcc/config/i386/emmintrin.h 2023-01-12 15:33:04.148735997 +0100 > @@ -99,7 +99,10 @@ _mm_setr_pd (double __W, double __X) > extern __inline __m128d __attribute__((__gnu_inline__, __always_inline__, __artificial__)) > _mm_undefined_pd (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m128d __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > @@ -785,7 +788,10 @@ _mm_move_epi64 (__m128i __A) > extern __inline __m128i __attribute__((__gnu_inline__, __always_inline__, __artificial__)) > _mm_undefined_si128 (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m128i __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > --- gcc/config/i386/avxintrin.h.jj 2022-01-11 23:11:21.763298965 +0100 > +++ gcc/config/i386/avxintrin.h 2023-01-12 15:34:15.395711408 +0100 > @@ -1207,21 +1207,30 @@ _mm256_movemask_ps (__m256 __A) > extern __inline __m256d __attribute__((__gnu_inline__, __always_inline__, __artificial__)) > _mm256_undefined_pd (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m256d __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > extern __inline __m256 __attribute__((__gnu_inline__, __always_inline__, __artificial__)) > _mm256_undefined_ps (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m256 __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > extern __inline __m256i __attribute__((__gnu_inline__, __always_inline__, __artificial__)) > _mm256_undefined_si256 (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m256i __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > --- gcc/config/i386/avx512fintrin.h.jj 2022-04-25 13:54:38.277309716 +0200 > +++ gcc/config/i386/avx512fintrin.h 2023-01-12 15:35:09.868928035 +0100 > @@ -185,7 +185,10 @@ extern __inline __m512 > __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > _mm512_undefined_ps (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m512 __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > @@ -195,7 +198,10 @@ extern __inline __m512d > __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > _mm512_undefined_pd (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m512d __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > @@ -203,7 +209,10 @@ extern __inline __m512i > __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > _mm512_undefined_epi32 (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m512i __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > --- gcc/config/i386/avx512fp16intrin.h.jj 2022-11-21 10:28:24.284544313 +0100 > +++ gcc/config/i386/avx512fp16intrin.h 2023-01-12 15:35:41.070479329 +0100 > @@ -204,7 +204,10 @@ extern __inline __m128h > __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > _mm_undefined_ph (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m128h __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > @@ -212,7 +215,10 @@ extern __inline __m256h > __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > _mm256_undefined_ph (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m256h __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > @@ -220,7 +226,10 @@ extern __inline __m512h > __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > _mm512_undefined_ph (void) > { > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Winit-self" > __m512h __Y = __Y; > +#pragma GCC diagnostic pop > return __Y; > } > > --- gcc/testsuite/g++.target/i386/pr105593.C.jj 2023-01-12 15:58:59.668363504 +0100 > +++ gcc/testsuite/g++.target/i386/pr105593.C 2023-01-12 16:01:17.785377769 +0100 > @@ -0,0 +1,20 @@ > +// PR c++/105593 > +// { dg-do compile { target c++14 } } > +// { dg-options "-mavx512fp16 -W -Wall -O2" } > + > +#include > + > +auto f1 () { return _mm_undefined_pd (); } > +auto f2 () { return _mm_undefined_ps (); } > +auto f3 () { return _mm_undefined_si128 (); } > +auto f4 () { return _mm_undefined_ph (); } > +auto f5 () { return _mm256_undefined_pd (); } > +auto f6 () { return _mm256_undefined_ps (); } > +auto f7 () { return _mm256_undefined_si256 (); } > +auto f8 () { return _mm256_undefined_ph (); } > +auto f9 () { return _mm512_undefined_pd (); } > +auto f10 () { return _mm512_undefined_ps (); } > +auto f11 () { return _mm512_undefined_epi32 (); } > +auto f12 () { return _mm512_undefined_ph (); } > + > +// { dg-bogus "is used uninitialized" "" { target *-*-* } 0 } > > Jakub >