From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by sourceware.org (Postfix) with ESMTPS id 266113858D20 for ; Wed, 31 May 2023 07:45:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 266113858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-6261cb1208eso3725636d6.0 for ; Wed, 31 May 2023 00:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685519127; x=1688111127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R1FCFna0gLzc+Kf4Ky3L2LXNoDpISdQPtsqpIdgp5Mg=; b=YaJmZcn+1jqbpGWnstfXOHwGLgojyMkm8QB3awkT86EPafHnCN9ZClZQh74QMx3JsZ yq6ghsLsXg7MMyGLLBbXJnD1Mttp7KOs1hBJayih6d0F2xmsODjDuGak3DipJ7Zq3CDH CxM47PZ/yMtq8O5PECNJKqGvwo28aQUG7qgIKEMd3vs5if/R3+9A/qER+V7PDJmHqJOk YC7dDyIgzdEBTpRnjLp2Fs0S8COg8Ve7HPrbAi3BX+tjXZHdIqVDo+Ygb4eZbW1XYA7o wUwVrWohEI3AVnWuv7JZ7hrZcfmZMYdEY9I0bKLxaLcoy98FHQVlYBTKPFA8pNqLVvFs igfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519127; x=1688111127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R1FCFna0gLzc+Kf4Ky3L2LXNoDpISdQPtsqpIdgp5Mg=; b=dWbsj7p/JadktzHvSZjybK3SMX+IkuRSkm6MHOAk0QDZiMTw874VErlAXLA+pMi6yX 68YAOd0zuteOCFBF+RTDma8lDiovZbAX0GF1imZMB76Tpl655/NrslwBDirTRiyVFb1s zWe4WZpzcqwF26qKrtX15c65S4K1qgSv6U+0UAHxZMKZ4XLU1teQbREaarUydxwkqhQq 4JRJyxhIcKXC3tK+zyUyhPFJ+WYn0mXl8wxXAZ531sApSae1ygZF8zDEc9z/xAqGdD6D O4oaqNS8UAVOmbs7+e8CEK2dzJmzn0N8MLc7EAqa8MOMOxPyhtVBDS6LEBMPTS2Ahxgz 96gA== X-Gm-Message-State: AC+VfDz+zInZuUkGDistuX0sewWvCatyw6oLzZlG/ZEbS0BE0Q5GdmBR YiXE6cFuv38O8q3ExjpH6aFuJT/y4WFkvb/wf0w= X-Google-Smtp-Source: ACHHUZ6Eo3Sl8ZVXRD+hPCwuumthNA00BhCzduvngqz2ixDdl/bDzEd8E/YTKmp13xhZc/ag/GIP4oWEQ6k/40qezA0= X-Received: by 2002:a05:6214:4018:b0:623:9a41:ea00 with SMTP id kd24-20020a056214401800b006239a41ea00mr4501760qvb.22.1685519127357; Wed, 31 May 2023 00:45:27 -0700 (PDT) MIME-Version: 1.0 References: <050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com> <86d73007-692c-51b4-d6a6-fc9265187141@linux.ibm.com> <8a1e58f9-6154-65c1-2785-dbe90d401a3b@linux.ibm.com> In-Reply-To: <8a1e58f9-6154-65c1-2785-dbe90d401a3b@linux.ibm.com> From: Uros Bizjak Date: Wed, 31 May 2023 09:45:15 +0200 Message-ID: Subject: Re: [PATCH] libgcc: Use initarray section type for .init_stack To: "Kewen.Lin" Cc: Andreas Krebbel , ian@airs.com, GCC Patches , Ian Lance Taylor Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 31, 2023 at 9:40=E2=80=AFAM Kewen.Lin wro= te: > > Hi Andreas, > > on 2023/5/25 15:25, Andreas Krebbel wrote: > > On 3/20/23 07:33, Kewen.Lin wrote: > >> Hi, > >> > >> One of my workmates found there is a warning like: > >> > >> libgcc/config/rs6000/morestack.S:402: Warning: ignoring > >> incorrect section type for .init_array.00000 > >> > >> when compiling libgcc/config/rs6000/morestack.S. > >> > >> Since commit r13-6545 touched that file recently, which was > >> suspected to be responsible for this warning, I did some > >> investigation and found this is a warning staying for a long > >> time. For section .init_stack*, it's preferred to use > >> section type SHT_INIT_ARRAY. So this patch is use > >> "@init_array" to replace "@progbits". > >> > >> Although the warning is trivial, Segher suggested me to > >> post this to fix it, in order to avoid any possible > >> misunderstanding/confusion on the warning. > >> > >> As Alan confirmed, this doesn't require a premise check > >> on if the existing binutils supports "@init_array" or not, > >> "because if you want split-stack to work, you must link > >> with gold, any version of binutils that has gold has an > >> assembler that understands @init_array". (Thanks Alan!) > >> > >> Bootstrapped and regtested on x86_64-redhat-linux > >> and powerpc64{,le}-linux-gnu. > >> > >> Is it ok for trunk when next stage 1 comes? > >> > >> BR, > >> Kewen > >> ----- > >> libgcc/ChangeLog: > >> > >> * config/i386/morestack.S: Use @init_array rather than > >> @progbits for section type of section .init_array. > >> * config/rs6000/morestack.S: Likewise. > >> * config/s390/morestack.S: Likewise. > > > > s390 parts are ok. I did run a bootstrap and regression. Looks all good= . Thanks! > > Thanks for testing this on s390, really appreciate! > > Hi Ian & Uros, > > Do you have any concerns on this, or does it look good to you? LGTM, but morestack.S is mostly used for Go, so I'd defer to Ian for the final approval. Uros.