From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tb7S=CG=gmail.com=ubizjak@sourceware.org>
Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30])
	by sourceware.org (Postfix) with ESMTPS id 5F8ED3858D33
	for <gcc-patches@gcc.gnu.org>; Sun, 18 Jun 2023 11:19:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F8ED3858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-6300f31c3ecso4655206d6.3
        for <gcc-patches@gcc.gnu.org>; Sun, 18 Jun 2023 04:19:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1687087156; x=1689679156;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=nroFV456ZEtzHnlhv9SETWVcK14X1vyANCBhq5yjf9c=;
        b=RQORYY52n/vIHfBMYIBprfrjczv4JAzGpIclijy1g6Cy5wHbMi5AswQaHD7uV5onjR
         74UQ35k78lX897kucpWX8mKRqIrZbtip8Q7NxBQexsOSZlMp+p1o8a+zWw1PLJtLsrxd
         KmM4/OYXjaw+XFNF/LnJI1wmC7/YSdTqML1S4rIXNCSuT2ppsqmb68M6GbOS2GxaxqHr
         xhzb5WMtObuXnZitWDMB1M04o/tdGksFJ7VUyoSVNfNa5c019kwjNlhBGw1QZYJEozai
         R+WfTP6yb6t61uKTv+sP/ElqkcJJ6BOpdgf0B6oTQxjJwqvsyjpWVG6Z6q1l17nPVVZp
         GohA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1687087156; x=1689679156;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=nroFV456ZEtzHnlhv9SETWVcK14X1vyANCBhq5yjf9c=;
        b=FgZ0q1w3vqAcgYuviUPOaBR651BgBLTsuVz1Vh9lu3rY5nAnNbvcVv/fh4vcODGpvm
         VWFrdjWDhSUUP+qhNkAWE7zSrEMQ+OMzq4bU6o90rZraMfF7909NX1d+9zBO3Oa8Jm8x
         1f1rWMVBhQVSGX3hq3BV8aCYLSgui2ZDAhRqAU/In1vFVaa6YOCd8pJV6bmbXpHNCH7A
         rZuod1QcZDM1jwi7LDeP0v8Qdxpy+2RZPAj6IzF/5/PZilIDw8Vn7VSzmKUeIZhMHE3d
         32rkybO5DZzIdcOTAZjTDEskhLAEut14vUh6QMOB2CESt9yl9ygQU4Of8lNiWeTPjQIj
         CVdQ==
X-Gm-Message-State: AC+VfDx1lVLppcWc6kbwGK65crMUYngboH/qunUPHcqMyx0lcAQoreF8
	Dy7dffFrNL/U03iNx2OgWKeiQEkn0RB24/f6dbE=
X-Google-Smtp-Source: ACHHUZ4qbJW8K9NLaq2K22Doh3s1tHkv5umyp11LpuvrZJBCj95Dm0W2hvjJTNci9HMhtRLzanA+3gDtTOXFws8S43E=
X-Received: by 2002:a05:6214:27c6:b0:62f:eae4:b2ca with SMTP id
 ge6-20020a05621427c600b0062feae4b2camr7779423qvb.12.1687087155622; Sun, 18
 Jun 2023 04:19:15 -0700 (PDT)
MIME-Version: 1.0
References: <000f01d9a1d5$6d676960$48363c20$@nextmovesoftware.com>
In-Reply-To: <000f01d9a1d5$6d676960$48363c20$@nextmovesoftware.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Sun, 18 Jun 2023 13:19:06 +0200
Message-ID: <CAFULd4ZjtWf4YuddjsBaOF45XXeJm-z=ZZeHUeYGExwsiRuXQA@mail.gmail.com>
Subject: Re: [x86 PATCH] Refactor new ix86_expand_carry to set the carry flag.
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Sun, Jun 18, 2023 at 1:10=E2=80=AFPM Roger Sayle <roger@nextmovesoftware=
.com> wrote:
>
>
> This patch refactors the three places in the i386.md backend that we
> set the carry flag into a new ix86_expand_carry helper function, that
> allows Jakub's recently added uaddc<mode>5 and usubc<mode>5 expanders
> to take advantage of the recently added support for the stc instruction.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=3Dunix{-m32}
> with no new failures.  Ok for mainline?
>
>
> 2023-06-18  Roger Sayle  <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
>         * config/i386/i386-expand.cc (ix86_expand_carry): New helper
>         function for setting the carry flag.
>         (ix86_expand_builtin) <handlecarry>: Use it here.
>         * config/i386/i386-protos.h (ix86_expand_carry): Prototype here.
>         * config/i386/i386.md (uaddc<mode>5): Use ix86_expand_carry.
>         (usubc<mode>5): Likewise.

OK.

Thanks,
Uros.

>
> Thanks in advance,
> Roger
> --
>