From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-322628-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 26784 invoked by alias); 16 Jul 2012 14:53:11 -0000
Received: (qmail 26763 invoked by uid 22791); 16 Jul 2012 14:53:09 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-gh0-f175.google.com (HELO mail-gh0-f175.google.com) (209.85.160.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jul 2012 14:52:56 +0000
Received: by ghbz2 with SMTP id z2so5222273ghb.20        for <gcc-patches@gcc.gnu.org>; Mon, 16 Jul 2012 07:52:56 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.66.73.70 with SMTP id j6mr23420796pav.5.1342450375499; Mon, 16 Jul 2012 07:52:55 -0700 (PDT)
Received: by 10.66.11.130 with HTTP; Mon, 16 Jul 2012 07:52:55 -0700 (PDT)
In-Reply-To: <CAMe9rOpVZXrq3K8OHoXgAHGgaB9N7c4POcFu61vpK_CwuLLgYA@mail.gmail.com>
References: <CAGs3RfsPi=d_QQZeMX7g6D+yqgXeLn9r9roa-qWpPXdHe86JBQ@mail.gmail.com>	<CAMe9rOpVZXrq3K8OHoXgAHGgaB9N7c4POcFu61vpK_CwuLLgYA@mail.gmail.com>
Date: Mon, 16 Jul 2012 14:53:00 -0000
Message-ID: <CAFULd4Zoi6z7sAj9mvT4VqQebqqkPEa77PRq=xsww_L+1MV-Jw@mail.gmail.com>
Subject: Re: [PATCH, i386, PR53877] New intrinsics for LZCNT
From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>, gcc-patches List <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-07/txt/msg00665.txt.bz2

On Mon, Jul 16, 2012 at 4:32 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Jul 16, 2012 at 7:14 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>> Hello guys,
>>
>> Here is a tiny patch which adds two new intrinsics which were
>> introduced in recent spec [1].
>> They're aliased to the existing __lzcnt_*  and live under same CPUID.
>>
>> ChangeLog entry is:
>> 2012-07-16  Kirill Yukhin  <kirill.yukhin@intel.com>
>>
>>         PR target/53877
>>         * config/i386/lzcntintrin.h (_lzcnt_u32): New.
>>         (_lzcnt_u64): Ditto.
>>
>> Is it OK for trunk?
>>
>
> I think we should add a testcase for each.  Also it should
> also be applied on 4.7.

This patch just calls __builtin_clz{,ll}, for which we already have
test coverage. Also, please note a couple of sse-*.c testcases that
check compilation of all intrinsics in one shot.

So, OK for mainline and 4.7.

Thanks,
Uros.