From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 4D4E33858D3C for ; Tue, 21 May 2024 13:04:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D4E33858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D4E33858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716296684; cv=none; b=rFxmU5Ymc2hW1hHvddqOc0vlkrkAUATMSnTJG75pR7lxBvifD8CgHp6KceTwqKccKSXKRJLSxzL+mV8JqO1AiyVVoll53vLTGjEKemAHpP3+uPI2O7y3yluGnZoXoWmKxLU0/hgHWhuVCnDaTb4oNanqgojf7YowcDGPsrP2MME= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716296684; c=relaxed/simple; bh=00Gy3vtyQZ4eJqW+n6toPdcBilA5lmoeOfV5Pm/t3dw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=TwJ6brxUbgJBQULOo8w7yhMafnWom2RfxP6cMahXqQjRgMHf5FJTbrtjfsMFRnSV1QZMtATuttT+AevJN0e5ZOdOM6w/6MppEwZ5m/zkNhIN51coUYMu8ju2uLgBx/mriUCxszxUrGhaddmM4/L3Xq4ZBrEcQmzrCocR4DPB0K0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2e73359b979so14931351fa.1 for ; Tue, 21 May 2024 06:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716296679; x=1716901479; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aAgkJG8UnI+E8/kCdIYNfqUWzQ/fZRfZ/8w7+C0ykzo=; b=QnHt9CIcIjXJnDtGc7gBJE652XvPYVh+MVjgB31v3nzSK18O/KAOOLDK/7Onr4BQaw 6A3XFJ2G7NcFZYdWOxNnKvdmaEFhISAMK13HhyEmE8nkFRxApQ5NIEgWY3JkjrDWOj/a Z/H2zI48xSP6WL8qKjOEPB8PS8O5+mFAK1NNVeXx3X78/xWcCSdcqlfM95anW3JpSXW2 relOYVy7gz/rHA1yneeVKObggIDL4T6sR3e+fOUPSREf/dKUizYWjdmG2F9I2v6QaNwz aYLtdo3wpyvfFf74O6+fpqEerzKJL2z3SPUBeoFoO7mOaurPz0SDCFTL5qPT98grHfqT N1lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716296679; x=1716901479; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aAgkJG8UnI+E8/kCdIYNfqUWzQ/fZRfZ/8w7+C0ykzo=; b=erQ8nfQIb7JZfpfcGbEMmi6LVzeC9ZvPFdXsVWbcE0as2vDWbZYHmPFU2LqSub/uhF NjG4m83ItJPjVOC0NQJ+6lC9XdnEUwtz2GedohgPW5Ui5SFv7ZFgzhSzwDGJ5RZCzTlk kL5/QaMBDFc1QcUD30bpQjWqfys6Auz8TfRbxHpYMnIO7uBcSOdy5bqpOO7lq7LvYJQy QhdhLtobSvDHA5HvhVzA4roGb8DRY1v/bMVdQMe2QO9PllEwj1QRIB3UgpI0kcH68fgR W6QUcRffNW8UJvoroNEbs0c1H7xhUe7l479oAIWpSqU01U1xBo1ZdZMJZ5fwxjC4iyot BGCw== X-Gm-Message-State: AOJu0YwDkfs6KPhndXkjRgJv2gTNTpoRaXOyd8ogK79WXiMmYrT7vlK0 pPCNu9RWAFpqGDGr9F7Q+n3NcmqOaLQRl73vL4FMB3f+1DpibVr57xhs30CqvkRHYVylFwYgH6A 2bprceZN2yTJRanlZNw+Fayt+r+I= X-Google-Smtp-Source: AGHT+IHG8VPUUg1UlzX5lHKGMydUArPFLwpmrKATY1m4BEHkyH/wc/z6DvYkduaVck0gTsx+FTHihOvI2ndk6FP4KzA= X-Received: by 2002:a2e:9b8b:0:b0:2e5:59a:591d with SMTP id 38308e7fff4ca-2e51fd3fe2emr226446791fa.4.1716296678468; Tue, 21 May 2024 06:04:38 -0700 (PDT) MIME-Version: 1.0 References: <20240521090109.2436971-1-haochen.jiang@intel.com> In-Reply-To: <20240521090109.2436971-1-haochen.jiang@intel.com> From: Uros Bizjak Date: Tue, 21 May 2024 15:04:26 +0200 Message-ID: Subject: Re: [PATCH v3] i386: Disable ix86_expand_vecop_qihi2 when !TARGET_AVX512BW To: Haochen Jiang Cc: gcc-patches@gcc.gnu.org, hongtao.liu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 21, 2024 at 11:01=E2=80=AFAM Haochen Jiang wrote: > > Hi all, > > This is the v3 patch to fix PR115069. The new testcase has passed. > > Changes in v3: > - Simplify the testcase. > > Changes in v2: > - Add a testcase. > - Change the comment for the early exit. > > Thx, > Haochen > > Since vpermq is really slow, we should avoid using it for permutation > when vpmovwb is not available (needs AVX512BW) for ix86_expand_vecop_qihi= 2 > and fall back to ix86_expand_vecop_qihi. > > gcc/ChangeLog: > > PR target/115069 > * config/i386/i386-expand.cc (ix86_expand_vecop_qihi2): > Do not enable the optimization when AVX512BW is not enabled. > > gcc/testsuite/ChangeLog: > > PR target/115069 > * gcc.target/i386/pr115069.c: New. LGTM, with a nit below. Thanks, Uros. > --- > gcc/config/i386/i386-expand.cc | 7 +++++++ > gcc/testsuite/gcc.target/i386/pr115069.c | 10 ++++++++++ > 2 files changed, 17 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/i386/pr115069.c > > diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand= .cc > index a6132911e6a..f7939761879 100644 > --- a/gcc/config/i386/i386-expand.cc > +++ b/gcc/config/i386/i386-expand.cc > @@ -24323,6 +24323,13 @@ ix86_expand_vecop_qihi2 (enum rtx_code code, rtx= dest, rtx op1, rtx op2) > bool op2vec =3D GET_MODE_CLASS (GET_MODE (op2)) =3D=3D MODE_VECTOR_INT= ; > bool uns_p =3D code !=3D ASHIFTRT; > > + /* Without VPMOVWB (provided by AVX512BW ISA), the expansion uses the > + generic permutation to merge the data back into the right place. T= his > + permutation results in VPERMQ, which is slow, so better fall back t= o > + ix86_expand_vecop_qihi. */ > + if (!TARGET_AVX512BW) > + return false; > + > if ((qimode =3D=3D V16QImode && !TARGET_AVX2) > || (qimode =3D=3D V32QImode && (!TARGET_AVX512BW || !TARGET_EVEX51= 2)) > /* There are no V64HImode instructions. */ > diff --git a/gcc/testsuite/gcc.target/i386/pr115069.c b/gcc/testsuite/gcc= .target/i386/pr115069.c > new file mode 100644 > index 00000000000..7f1ff209f26 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr115069.c > @@ -0,0 +1,10 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -mavx2" } */ > +/* { dg-final { scan-assembler-not "vpermq" } } */ > + > +typedef char v16qi __attribute__((vector_size(16))); > + > +v16qi foo (v16qi a, v16qi b) { > + return a * b; > +} > + Please remove the trailing line. > -- > 2.31.1 >