From: Uros Bizjak <ubizjak@gmail.com>
To: liuhongt <hongtao.liu@intel.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [x86] Remove unused mmx_pinsrw.
Date: Fri, 20 Oct 2023 10:18:57 +0200 [thread overview]
Message-ID: <CAFULd4Zr3=vo8RSqQW1miow-DPP1m-hgM8htDdOh6aaOCxiBZQ@mail.gmail.com> (raw)
In-Reply-To: <20231020065401.1086359-1-hongtao.liu@intel.com>
On Fri, Oct 20, 2023 at 8:54 AM liuhongt <hongtao.liu@intel.com> wrote:
>
> When I'm working on enable more 32/64-bit vectorization for _Float16,
> I notice there's 1 redundant define_expand, the patch removed the expander.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Ok for trunk?
>
> gcc/ChangeLog:
>
> * config/i386/mmx.md (mmx_pinsrw): Removed.
Please use present tense in the ChangeLog (like, you are commanding
what to do here).
OK.
Thanks,
Uros.
> ---
> gcc/config/i386/mmx.md | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
> index 491a0a51272..d1e1f733566 100644
> --- a/gcc/config/i386/mmx.md
> +++ b/gcc/config/i386/mmx.md
> @@ -4574,20 +4574,6 @@ (define_insn "*mmx_pinsrd"
> (set_attr "prefix" "orig,vex")
> (set_attr "mode" "TI")])
>
> -(define_expand "mmx_pinsrw"
> - [(set (match_operand:V4HI 0 "register_operand")
> - (vec_merge:V4HI
> - (vec_duplicate:V4HI
> - (match_operand:SI 2 "nonimmediate_operand"))
> - (match_operand:V4HI 1 "register_operand")
> - (match_operand:SI 3 "const_0_to_3_operand")))]
> - "(TARGET_MMX || TARGET_MMX_WITH_SSE)
> - && (TARGET_SSE || TARGET_3DNOW_A)"
> -{
> - operands[2] = gen_lowpart (HImode, operands[2]);
> - operands[3] = GEN_INT (1 << INTVAL (operands[3]));
> -})
> -
> (define_insn "*mmx_pinsrw"
> [(set (match_operand:V4HI 0 "register_operand" "=y,x,YW")
> (vec_merge:V4HI
> --
> 2.31.1
>
prev parent reply other threads:[~2023-10-20 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 6:54 liuhongt
2023-10-20 8:18 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4Zr3=vo8RSqQW1miow-DPP1m-hgM8htDdOh6aaOCxiBZQ@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).