From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by sourceware.org (Postfix) with ESMTPS id E03C93858CDB for ; Sun, 4 Sep 2022 19:36:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E03C93858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x834.google.com with SMTP id l5so4986538qtv.4 for ; Sun, 04 Sep 2022 12:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=fIkZHeWIGyHqZQXSHo02G22wb65utuxewefV1Hmx5tA=; b=NZ07/QlqG1I7E/anSS3cyaOad9lvPs9mbchhdtNLFoDheht/x7JCNglXw29dXHdUz+ j3NSM4xafLmIfLBYHat7ousUhrPtctT+atRuBCb84G66p0sSIb+P4LMaiDpiYC6h6QMG cf5R+bK4Bl8vWxxEOrvuFDdabPSyE2aiAEJBfmzYP3tiNpL1nnloyHps+TMMbnra5MK3 nLDqCKcu40RTv70gZ9kSX3+bc/s8jLuPqPAhJLxdJAqVxjmxkCGZEci3BMleVYfauhaH UAlvjcwqFAgMmph+7NQVRPCW5NxlR7Em89EQTgsNtLSBjbvPvkbxBRa+XQvp4iJNrXp5 vcfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=fIkZHeWIGyHqZQXSHo02G22wb65utuxewefV1Hmx5tA=; b=jaaarQqdhZeCpP+pBgmHu2z3BOrZGtbIiUy28qDNp6muMmfHAP74jvW1SJd7JspFyt OQSmenLoOxsl8Bxopr5W7zh9cv60mUzVrcXAgJE34dp7Jn7A5CW9kwC7FX3lV8Zeuye5 /gg/It3dXQrxtUqoMr0XXHj89tdWBQ7+GQBg6r9z18oTy/DPPbZSrC/Xmx6NNAIfuMwe hal70mzaU/bFKAhyebEeM6vvJA/amaCCXBjoQUQ+CagdHtejlF1URXk7ZIXmnVRjoiHJ BLvPt/bQbfX1H+TYxj26hwnwaC1dCepDdU0HCopxoE2HKkVCVS0sen02+/AiVp5LoN/j Bf9Q== X-Gm-Message-State: ACgBeo1xAgP2bY/LopE1v5S83W855guoKPH2ZFyajliJ4uhyQuIDKxWw 9/9Y/+xF/AI9jirmIIZjic1lxNhZZmZeaiTV916MzS5miBaRRw== X-Google-Smtp-Source: AA6agR7DFVxFMbG6dUCEyUYpE+HPp+MUtsMIQ7ohzLY36qcHjtfkO2QYQwGHcOAw8TD4ao2IrhJczhNUTkdqKBo2zi8= X-Received: by 2002:a05:622a:205:b0:343:282:3d0e with SMTP id b5-20020a05622a020500b0034302823d0emr36591106qtx.436.1662320213955; Sun, 04 Sep 2022 12:36:53 -0700 (PDT) MIME-Version: 1.0 References: <20220823160946.19927-1-amonakov@ispras.ru> In-Reply-To: <20220823160946.19927-1-amonakov@ispras.ru> From: Uros Bizjak Date: Sun, 4 Sep 2022 21:36:42 +0200 Message-ID: Subject: Re: [PATCH] i386: avoid zero extension for crc32q To: gcc-patches@gcc.gnu.org Cc: Alexander Monakov Content-Type: multipart/mixed; boundary="000000000000db42cd05e7df155e" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000db42cd05e7df155e Content-Type: text/plain; charset="UTF-8" On Tue, Aug 23, 2022 at 6:10 PM Alexander Monakov via Gcc-patches wrote: > > The crc32q instruction takes 64-bit operands, but ignores high 32 bits > of the destination operand, and zero-extends the result from 32 bits. > > Let's model this in the RTL pattern to avoid zero-extension when the > _mm_crc32_u64 intrinsic is used with a 32-bit type. > > PR target/106453 > > gcc/ChangeLog: > > * config/i386/i386.md (sse4_2_crc32di): Model that only low 32 > bits of operand 0 are consumed, and the result is zero-extended > to 64 bits. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/pr106453.c: New test. OK with a nit and a couple of changes to the testcase dg-directives. > --- > gcc/config/i386/i386.md | 6 +++--- > gcc/testsuite/gcc.target/i386/pr106453.c | 13 +++++++++++++ > 2 files changed, 16 insertions(+), 3 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/pr106453.c > > diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md > index 58fcc382f..b5760bb23 100644 > --- a/gcc/config/i386/i386.md > +++ b/gcc/config/i386/i386.md > @@ -23823,10 +23823,10 @@ > > (define_insn "sse4_2_crc32di" > [(set (match_operand:DI 0 "register_operand" "=r") > - (unspec:DI > - [(match_operand:DI 1 "register_operand" "0") > + (zero_extend:DI (unspec:SI > + [(match_operand:SI 1 "register_operand" "0") > (match_operand:DI 2 "nonimmediate_operand" "rm")] > - UNSPEC_CRC32))] > + UNSPEC_CRC32)))] Usually the (unspec) part comes in the next line. > "TARGET_64BIT && TARGET_CRC32" > "crc32{q}\t{%2, %0|%0, %2}" > [(set_attr "type" "sselog1") > diff --git a/gcc/testsuite/gcc.target/i386/pr106453.c b/gcc/testsuite/gcc.target/i386/pr106453.c > new file mode 100644 > index 000000000..bab5b1cb2 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr106453.c > @@ -0,0 +1,13 @@ > +/* { dg-do compile } */ > +/* { dg-options "-msse4.2 -O2 -fdump-rtl-final" } */ > +/* { dg-final { scan-rtl-dump-not "zero_extendsidi" "final" } } */ This part can use scan-asembler-not directive, with a -dp compiler option: +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-options "-O2 -mcrc32 -dp" } */ +/* { dg-final { scan-assembler-not "zero_extendsidi" } } */ Also, the mainline compiler can use -mcrc32. Please find all these suggestions implemented in the attached patch. Thanks, Uros. --000000000000db42cd05e7df155e Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l7nqi2180 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvaTM4Ni9pMzg2Lm1kIGIvZ2NjL2NvbmZpZy9pMzg2L2kz ODYubWQKaW5kZXggMWFlZjFhZjU5NGQuLjU3NzcxZWQ4NGY1IDEwMDY0NAotLS0gYS9nY2MvY29u ZmlnL2kzODYvaTM4Ni5tZAorKysgYi9nY2MvY29uZmlnL2kzODYvaTM4Ni5tZApAQCAtMjM4MjMs MTAgKzIzODIzLDExIEBAIChkZWZpbmVfaW5zbiAic3NlNF8yX2NyYzMyPG1vZGU+IgogCiAoZGVm aW5lX2luc24gInNzZTRfMl9jcmMzMmRpIgogICBbKHNldCAobWF0Y2hfb3BlcmFuZDpESSAwICJy ZWdpc3Rlcl9vcGVyYW5kIiAiPXIiKQotCSh1bnNwZWM6REkKLQkgIFsobWF0Y2hfb3BlcmFuZDpE SSAxICJyZWdpc3Rlcl9vcGVyYW5kIiAiMCIpCi0JICAgKG1hdGNoX29wZXJhbmQ6REkgMiAibm9u aW1tZWRpYXRlX29wZXJhbmQiICJybSIpXQotCSAgVU5TUEVDX0NSQzMyKSldCisJKHplcm9fZXh0 ZW5kOkRJCisJICAodW5zcGVjOlNJCisJICAgIFsobWF0Y2hfb3BlcmFuZDpTSSAxICJyZWdpc3Rl cl9vcGVyYW5kIiAiMCIpCisJICAgICAobWF0Y2hfb3BlcmFuZDpESSAyICJub25pbW1lZGlhdGVf b3BlcmFuZCIgInJtIildCisJICAgIFVOU1BFQ19DUkMzMikpKV0KICAgIlRBUkdFVF82NEJJVCAm JiBUQVJHRVRfQ1JDMzIiCiAgICJjcmMzMntxfVx0eyUyLCAlMHwlMCwgJTJ9IgogICBbKHNldF9h dHRyICJ0eXBlIiAic3NlbG9nMSIpCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy50YXJn ZXQvaTM4Ni9wcjEwNjQ1My5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2kzODYvcHIxMDY0 NTMuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uYmQyZTcyODJjZjYK LS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvaTM4Ni9wcjEwNjQ1 My5jCkBAIC0wLDAgKzEsMTMgQEAKKy8qIHsgZGctZG8gY29tcGlsZSB7IHRhcmdldCB7ICEgaWEz MiB9IH0gfSAqLworLyogeyBkZy1vcHRpb25zICItTzIgLW1jcmMzMiAtZHAiIH0gKi8KKy8qIHsg ZGctZmluYWwgeyBzY2FuLWFzc2VtYmxlci1ub3QgInplcm9fZXh0ZW5kc2lkaSIgfSB9ICovCisK KyNpbmNsdWRlIDxpbW1pbnRyaW4uaD4KKyNpbmNsdWRlIDxzdGRpbnQuaD4KKwordWludDMyX3Qg Zih1aW50MzJfdCBjLCB1aW50NjRfdCAqcCwgc2l6ZV90IG4pCit7CisgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBuOyBpKyspCisgICAgICAgIGMgPSBfbW1fY3JjMzJfdTY0KGMsIHBbaV0pOwor ICAgIHJldHVybiBjOworfQo= --000000000000db42cd05e7df155e--