From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67542 invoked by alias); 14 May 2017 10:25:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67532 invoked by uid 89); 14 May 2017 10:25:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-ua0-f194.google.com Received: from mail-ua0-f194.google.com (HELO mail-ua0-f194.google.com) (209.85.217.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 14 May 2017 10:25:54 +0000 Received: by mail-ua0-f194.google.com with SMTP id j17so8319690uag.1 for ; Sun, 14 May 2017 03:25:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NjQvl0x4L1rA5r8h4shKsWSKUSualSwxQ3fMg/iWrUk=; b=BOfKwsB9sdOnWsxlitRDahbrOuC0vltwa+jT6dIIsj8a+ZfOeBA7J5KNlhgYPeGTfX PlTnKFXKkcF3JZfzt5DK9kA4Ewn7EDtLa6JKarl99DWFVMmjr9YPzU+TyKabCGqRQFuZ wunaf4i++cphIUXKD4Y8Sp8OTOWCIhKKqdVvzeNi51A+Mq9wDMrURVaT7qkBwQzsi5FZ TJnFoifc5LWTVxldIgJjUXDjgAA/EReavqKJjMFThUa67M/4geSEexo7pkzGYFGuUy4i vwvhkpqePcrO5wv4ULSFcAjp0DofCDRQgkzZB9oFAktB3B+iSgyvTZyrFtliRL1sEqts gC3g== X-Gm-Message-State: AODbwcDI8Mbe5/dajROtoOHrDJ1s7TxLAJPl96j2sKPec2cu4DFhInuw rudCwO/rZ6E4pk2vVihap9hjXEQLFw== X-Received: by 10.176.75.29 with SMTP id h29mr258338uaf.40.1494757555837; Sun, 14 May 2017 03:25:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.48.200 with HTTP; Sun, 14 May 2017 03:25:55 -0700 (PDT) In-Reply-To: <9aa7427e-6cfc-b603-2ec4-1f0e02ae294d@pobox.com> References: <9aa7427e-6cfc-b603-2ec4-1f0e02ae294d@pobox.com> From: Uros Bizjak Date: Sun, 14 May 2017 10:27:00 -0000 Message-ID: Subject: Re: [PATCH] [i386] Recompute the frame layout less often To: Daniel Santos Cc: Bernd Edlinger , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-05/txt/msg01120.txt.bz2 On Sun, May 14, 2017 at 11:16 AM, Daniel Santos wrote: > On 05/14/2017 02:42 AM, Bernd Edlinger wrote: >> >> Hi, >> >> >> this patch uses the new TARGET_COMPUTE_FRAME_LAYOUT hook in the i386 >> backend to avoid re-computing the frame layout when not really >> necessary. >> >> It simplifies the logic in ix86_compute_frame_layout by removing >> the use_fast_prologue_epilogue_nregs, which is no longer necessary, >> because the frame layout can no longer change spontaneously. >> >> >> Bootstrapped and reg-tested on x86_64-pc-linux-gnu. >> Is it OK for trunk? >> >> >> Thanks >> Bernd. > > > I think Uros is about to commit my improvements to ms to sysv abi calls, > which is a large change and will conflict with your patch. I've added > several new fields to struct ix86_frame that will need to be merged (and > moved to i386.h). I believe that my only explicit check of > crtl->stack_realign_finalized is during pro/epilogue expand, and not in > ix86_compute_frame_layout. A former incarnation of my patches needed > ix86_compute_frame_layout to be called *after* it was set, but I believe > that is no longer the case, and so shouldn't conflict, but retesting should > certainly be done. Yes, the mcall-ms2sysv-xlogues patch was committed to mainline, please re-test and re-send the patch. Uros.