From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110422 invoked by alias); 6 Feb 2018 14:35:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110409 invoked by uid 89); 6 Feb 2018 14:35:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-io0-f170.google.com Received: from mail-io0-f170.google.com (HELO mail-io0-f170.google.com) (209.85.223.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 14:35:47 +0000 Received: by mail-io0-f170.google.com with SMTP id n7so2705911iob.0 for ; Tue, 06 Feb 2018 06:35:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=n1ezvXsXgis2/nw+ghWyXOOpYyD4wzopNaSpGfUNDJA=; b=BOAjscL2ki+ngfsnNJm1FMBpnEB6JKLjpazFfmuzlPM1xBuvezOHUlZIxB4ROtJ6eo EpLKTKcaGLgZQbQLauGYd05bnheu75H8HUw0PQcw5GY+RbMfS8ZR2BGNHQXt4QXVcAeX LmrPCJaAVSf7rgaMMj/6OKcL03Ux0+3AAfR0ZjVE3kt/lHACT7j+IJfKQ/CmmwATnqVx YhJIPH9QLlW0tBtYuaOjtNEe/6REZb2yt7xp84HWpQz4PfYQMkkJo8NVIyKJeyOt6gHL frn+tqhLxngS/rdukZCfHFfclyVJtfb8R5uek1ZK5MHjO1a8SPEhKD2OVIQJRTn3/KRG Hp+g== X-Gm-Message-State: APf1xPBF1W3GYwT0UVyfkqnqgDFcqJG9EMWsdk+3CnZqKJ2Q9g2pcKge CQrKWUOW7sO1765wgfvkAMz63qnUJeR8BiwPOhM= X-Google-Smtp-Source: AH8x224fwcpm/yFR3zhEnTrNY8YOhzZYdkHFSuxruf7LAddQAiK0Sxez6n/sW+8dHxva2nqlIN88YBRDM01TTwVXSq0= X-Received: by 10.107.242.14 with SMTP id q14mr3014708ioh.211.1517927744945; Tue, 06 Feb 2018 06:35:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.163.146 with HTTP; Tue, 6 Feb 2018 06:35:44 -0800 (PST) In-Reply-To: References: <87k1vra2oh.fsf@redhat.com> <7def0fb4-1415-b277-278c-778fe12ea5dc@redhat.com> From: Uros Bizjak Date: Tue, 06 Feb 2018 14:35:00 -0000 Message-ID: Subject: Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection To: "Tsimbalist, Igor V" Cc: "gcc-patches@gcc.gnu.org" , Nick Clifton , "hjl.tools@gmail.com" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-02/txt/msg00237.txt.bz2 On Tue, Feb 6, 2018 at 3:08 PM, Tsimbalist, Igor V wrote: >> -----Original Message----- >> From: Nick Clifton [mailto:nickc@redhat.com] >> Sent: Tuesday, February 6, 2018 1:16 PM >> To: Tsimbalist, Igor V ; hjl.tools@gmail.com >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: PR 84154: Fix checking -mibt and -mshstk options for control >> flow protection >> >> Hi Igor, >> >> >> Attached is a potential patch for PR 84145: >> >> >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145 >> >> > Coincidentally, I have worked on the same patch. >> >> Great minds, etc :-) >> >> > Please look at the patch, I uploaded it to the bug. The main differences are >> > >> > - updated the output messages to be more informative; >> > - updated the tests and add couple of new tests to check the messages; >> > - fixed a typo in the doc file related to fcf-protection; >> > >> > I am ok with the changes in i386.c but would like to update the messages. >> Could you incorporate my changes and proceed? Or would you like me to >> finish the fix? >> >> If you are happy to finish the fix then please do so. Your fix is >> more thorough than mine, so I am happy to see it go on. Although >> I should say that I am not an x86 maintainer, so I cannot approve >> it. > > Here is the updated patch. Please note the subject should say PR 84145. > > Ok for trunk? LGTM. Thanks, Uros.