From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
liuhongt <hongtao.liu@intel.com>
Subject: Re: [PATCH] x86: Require AVX for F16C and VAES
Date: Sat, 11 Jun 2022 21:24:16 +0200 [thread overview]
Message-ID: <CAFULd4a625B3AReSazCwH8dOxzMW80T0D=jes4ARfqYjgPxb5g@mail.gmail.com> (raw)
In-Reply-To: <YqONLwdJ0Eo68NlW@gmail.com>
On Fri, Jun 10, 2022 at 8:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Since F16C and VAES are only usable with AVX, require AVX for F16C and
> VAES.
>
> OK for master and release branches?
>
> Thanks.
>
> H.J.
> ---
> libgcc/105920
> * common/config/i386/cpuinfo.h (get_available_features): Require
> AVX for F16C and VAES.
OK.
Thanks,
Uros.
> ---
> gcc/common/config/i386/cpuinfo.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/common/config/i386/cpuinfo.h b/gcc/common/config/i386/cpuinfo.h
> index adc02bc3d98..bbced8a23b9 100644
> --- a/gcc/common/config/i386/cpuinfo.h
> +++ b/gcc/common/config/i386/cpuinfo.h
> @@ -651,8 +651,6 @@ get_available_features (struct __processor_model *cpu_model,
> set_feature (FEATURE_MOVBE);
> if (ecx & bit_AES)
> set_feature (FEATURE_AES);
> - if (ecx & bit_F16C)
> - set_feature (FEATURE_F16C);
> if (ecx & bit_RDRND)
> set_feature (FEATURE_RDRND);
> if (ecx & bit_XSAVE)
> @@ -663,6 +661,8 @@ get_available_features (struct __processor_model *cpu_model,
> set_feature (FEATURE_AVX);
> if (ecx & bit_FMA)
> set_feature (FEATURE_FMA);
> + if (ecx & bit_F16C)
> + set_feature (FEATURE_F16C);
> }
>
> /* Get Advanced Features at level 7 (eax = 7, ecx = 0/1). */
> @@ -683,6 +683,8 @@ get_available_features (struct __processor_model *cpu_model,
> set_feature (FEATURE_AVX2);
> if (ecx & bit_VPCLMULQDQ)
> set_feature (FEATURE_VPCLMULQDQ);
> + if (ecx & bit_VAES)
> + set_feature (FEATURE_VAES);
> }
> if (ebx & bit_BMI2)
> set_feature (FEATURE_BMI2);
> @@ -705,8 +707,6 @@ get_available_features (struct __processor_model *cpu_model,
> set_feature (FEATURE_PKU);
> if (ecx & bit_RDPID)
> set_feature (FEATURE_RDPID);
> - if (ecx & bit_VAES)
> - set_feature (FEATURE_VAES);
> if (ecx & bit_GFNI)
> set_feature (FEATURE_GFNI);
> if (ecx & bit_MOVDIRI)
> --
> 2.36.1
>
prev parent reply other threads:[~2022-06-11 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 18:27 H.J. Lu
2022-06-11 19:24 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4a625B3AReSazCwH8dOxzMW80T0D=jes4ARfqYjgPxb5g@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hongtao.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).