* Re: [PATCH] Fix for PR ipa/64503
@ 2015-01-07 12:44 Uros Bizjak
2015-01-08 17:04 ` Jakub Jelinek
0 siblings, 1 reply; 10+ messages in thread
From: Uros Bizjak @ 2015-01-07 12:44 UTC (permalink / raw)
To: gcc-patches; +Cc: Martin Liska, Jakub Jelinek
Hello!
>>>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it works.
>>>> I would like to ask Uros to test it on an aplha machine before we install the patch.
>>>
>>> Yes, this works for me on all IPA tests that were failing previously [1].
>>>
>>> I am restarting the bootstrap + regtest, it will take ~10 hours, but I
>>> don't expect any surprises there.
>>
>> The patch was bootstrapped and regression tested on
>> alphaev68-linux-gnu [2] and everything was OK.
>
> Thanks for testing. May I take this as approval of the patch.
> I don't know, if you have a permission to accept my patch ;)
Unfortunately, I have no approval power here. Luckilly, I know someone
who has ;)
Uros.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-07 12:44 [PATCH] Fix for PR ipa/64503 Uros Bizjak
@ 2015-01-08 17:04 ` Jakub Jelinek
2015-01-08 18:42 ` Uros Bizjak
2015-01-08 19:34 ` Mike Stump
0 siblings, 2 replies; 10+ messages in thread
From: Jakub Jelinek @ 2015-01-08 17:04 UTC (permalink / raw)
To: Uros Bizjak; +Cc: gcc-patches, Martin Liska
On Wed, Jan 07, 2015 at 01:43:59PM +0100, Uros Bizjak wrote:
> Hello!
>
> >>>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it works.
> >>>> I would like to ask Uros to test it on an aplha machine before we install the patch.
> >>>
> >>> Yes, this works for me on all IPA tests that were failing previously [1].
> >>>
> >>> I am restarting the bootstrap + regtest, it will take ~10 hours, but I
> >>> don't expect any surprises there.
> >>
> >> The patch was bootstrapped and regression tested on
> >> alphaev68-linux-gnu [2] and everything was OK.
> >
> > Thanks for testing. May I take this as approval of the patch.
> > I don't know, if you have a permission to accept my patch ;)
>
> Unfortunately, I have no approval power here. Luckilly, I know someone
> who has ;)
I don't know how portable scalbnl actually is in reality, so it would be
nice to hear from port maintainers whether say newlib, android, darwin,
cygwin, aix etc. have it.
Jakub
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-08 17:04 ` Jakub Jelinek
@ 2015-01-08 18:42 ` Uros Bizjak
2015-01-08 19:05 ` Jakub Jelinek
2015-01-08 19:34 ` Mike Stump
1 sibling, 1 reply; 10+ messages in thread
From: Uros Bizjak @ 2015-01-08 18:42 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches, Martin Liska
On Thu, Jan 8, 2015 at 6:04 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Jan 07, 2015 at 01:43:59PM +0100, Uros Bizjak wrote:
>> Hello!
>>
>> >>>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it works.
>> >>>> I would like to ask Uros to test it on an aplha machine before we install the patch.
>> >>>
>> >>> Yes, this works for me on all IPA tests that were failing previously [1].
>> >>>
>> >>> I am restarting the bootstrap + regtest, it will take ~10 hours, but I
>> >>> don't expect any surprises there.
>> >>
>> >> The patch was bootstrapped and regression tested on
>> >> alphaev68-linux-gnu [2] and everything was OK.
>> >
>> > Thanks for testing. May I take this as approval of the patch.
>> > I don't know, if you have a permission to accept my patch ;)
>>
>> Unfortunately, I have no approval power here. Luckilly, I know someone
>> who has ;)
>
> I don't know how portable scalbnl actually is in reality, so it would be
> nice to hear from port maintainers whether say newlib, android, darwin,
> cygwin, aix etc. have it.
Newlib has it.
Other than that:
exp2(), exp2f(), exp2l():
_XOPEN_SOURCE >= 600 || _ISOC99_SOURCE || _POSIX_C_SOURCE >= 200112L;
or cc -std=c99
scalbln(), scalblnf(), scalblnl():
_XOPEN_SOURCE >= 600 || _ISOC99_SOURCE ||
_POSIX_C_SOURCE >= 200112L;
or cc -std=c99
Since we are replacing exp2 with scalbln, we have the same
requirements as before, at least we won't regress here.
Uros.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-08 18:42 ` Uros Bizjak
@ 2015-01-08 19:05 ` Jakub Jelinek
0 siblings, 0 replies; 10+ messages in thread
From: Jakub Jelinek @ 2015-01-08 19:05 UTC (permalink / raw)
To: Uros Bizjak; +Cc: gcc-patches, Martin Liska
On Thu, Jan 08, 2015 at 07:42:32PM +0100, Uros Bizjak wrote:
> > I don't know how portable scalbnl actually is in reality, so it would be
> > nice to hear from port maintainers whether say newlib, android, darwin,
> > cygwin, aix etc. have it.
>
> Newlib has it.
>
> Other than that:
>
> exp2(), exp2f(), exp2l():
> _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE || _POSIX_C_SOURCE >= 200112L;
> or cc -std=c99
>
> scalbln(), scalblnf(), scalblnl():
> _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE ||
> _POSIX_C_SOURCE >= 200112L;
> or cc -std=c99
>
> Since we are replacing exp2 with scalbln, we have the same
> requirements as before, at least we won't regress here.
The patch is ok then. If it is missing somewhere, we can always check for
it in configure and add a val *= pow (2.0, exp); fallback that should be
more portable.
Jakub
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-08 17:04 ` Jakub Jelinek
2015-01-08 18:42 ` Uros Bizjak
@ 2015-01-08 19:34 ` Mike Stump
1 sibling, 0 replies; 10+ messages in thread
From: Mike Stump @ 2015-01-08 19:34 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Uros Bizjak, gcc-patches, Martin Liska
On Jan 8, 2015, at 9:04 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> I don't know how portable scalbnl actually is in reality, so it would be
> nice to hear from port maintainers whether say newlib, android, darwin,
> cygwin, aix etc. have it.
darwin has it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Fix for PR ipa/64503
@ 2015-01-06 17:49 Martin Liška
2015-01-06 18:25 ` Uros Bizjak
0 siblings, 1 reply; 10+ messages in thread
From: Martin Liška @ 2015-01-06 17:49 UTC (permalink / raw)
To: GCC Patches; +Cc: hubicka >> Jan Hubicka, ubizjak
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Hello.
There's suggested patch for PR ipa/64503 that was tested on x86_64 and it works.
I would like to ask Uros to test it on an aplha machine before we install the patch.
Thanks,
Martin
[-- Attachment #2: 0001-Fix-for-ipa-PR64503.patch --]
[-- Type: text/x-patch, Size: 982 bytes --]
From d4738c61467e53d04b295cfc029ab89707ac29ce Mon Sep 17 00:00:00 2001
From: mliska <mliska@suse.cz>
Date: Tue, 6 Jan 2015 12:25:51 +0100
Subject: [PATCH] Fix for ipa/PR64503
gcc/ChangeLog:
2015-01-06 Martin Liska <mliska@suse.cz>
PR ipa/64503
* sreal.c (sreal::dump): Change unsigned format to signed for
m_exp value.
(sreal::to_double): Replace exp2 with scalbln.
---
gcc/sreal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/sreal.c b/gcc/sreal.c
index 82ebcb8..622fc2d 100644
--- a/gcc/sreal.c
+++ b/gcc/sreal.c
@@ -58,7 +58,7 @@ along with GCC; see the file COPYING3. If not see
void
sreal::dump (FILE *file) const
{
- fprintf (file, "(%" PRIu64 " * 2^%d)", m_sig, m_exp);
+ fprintf (file, "(%" PRIi64 " * 2^%d)", m_sig, m_exp);
}
DEBUG_FUNCTION void
@@ -122,7 +122,7 @@ sreal::to_double () const
{
double val = m_sig;
if (m_exp)
- val *= exp2 (m_exp);
+ val = scalbln (val, m_exp);
return val;
}
--
2.1.2
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-06 17:49 Martin Liška
@ 2015-01-06 18:25 ` Uros Bizjak
2015-01-07 10:55 ` Uros Bizjak
0 siblings, 1 reply; 10+ messages in thread
From: Uros Bizjak @ 2015-01-06 18:25 UTC (permalink / raw)
To: Martin Liška; +Cc: GCC Patches, hubicka >> Jan Hubicka
On Tue, Jan 6, 2015 at 6:49 PM, Martin Liška <mliska@suse.cz> wrote:
> Hello.
>
> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it
> works.
> I would like to ask Uros to test it on an aplha machine before we install
> the patch.
Yes, this works for me on all IPA tests that were failing previously [1].
I am restarting the bootstrap + regtest, it will take ~10 hours, but I
don't expect any surprises there.
[1] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00400.html
Thanks,
Uros.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-06 18:25 ` Uros Bizjak
@ 2015-01-07 10:55 ` Uros Bizjak
2015-01-07 11:35 ` Martin Liška
2015-01-09 5:18 ` Jeff Law
0 siblings, 2 replies; 10+ messages in thread
From: Uros Bizjak @ 2015-01-07 10:55 UTC (permalink / raw)
To: Martin Liška; +Cc: GCC Patches, hubicka >> Jan Hubicka
On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it
>> works.
>> I would like to ask Uros to test it on an aplha machine before we install
>> the patch.
>
> Yes, this works for me on all IPA tests that were failing previously [1].
>
> I am restarting the bootstrap + regtest, it will take ~10 hours, but I
> don't expect any surprises there.
The patch was bootstrapped and regression tested on
alphaev68-linux-gnu [2] and everything was OK.
[2] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00577.html
Thanks,
Uros.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-07 10:55 ` Uros Bizjak
@ 2015-01-07 11:35 ` Martin Liška
2015-01-09 5:18 ` Jeff Law
1 sibling, 0 replies; 10+ messages in thread
From: Martin Liška @ 2015-01-07 11:35 UTC (permalink / raw)
To: gcc-patches
On 01/07/2015 11:55 AM, Uros Bizjak wrote:
> On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
>>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it
>>> works.
>>> I would like to ask Uros to test it on an aplha machine before we install
>>> the patch.
>>
>> Yes, this works for me on all IPA tests that were failing previously [1].
>>
>> I am restarting the bootstrap + regtest, it will take ~10 hours, but I
>> don't expect any surprises there.
>
> The patch was bootstrapped and regression tested on
> alphaev68-linux-gnu [2] and everything was OK.
Hi.
Thanks for testing. May I take this as approval of the patch.
I don't know, if you have a permission to accept my patch ;)
Thanks,
Martin
>
> [2] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00577.html
>
> Thanks,
> Uros.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix for PR ipa/64503
2015-01-07 10:55 ` Uros Bizjak
2015-01-07 11:35 ` Martin Liška
@ 2015-01-09 5:18 ` Jeff Law
1 sibling, 0 replies; 10+ messages in thread
From: Jeff Law @ 2015-01-09 5:18 UTC (permalink / raw)
To: Uros Bizjak, Martin Liška; +Cc: GCC Patches, hubicka >> Jan Hubicka
On 01/07/15 03:55, Uros Bizjak wrote:
> On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
>>> There's suggested patch for PR ipa/64503 that was tested on x86_64 and it
>>> works.
>>> I would like to ask Uros to test it on an aplha machine before we install
>>> the patch.
>>
>> Yes, this works for me on all IPA tests that were failing previously [1].
>>
>> I am restarting the bootstrap + regtest, it will take ~10 hours, but I
>> don't expect any surprises there.
>
> The patch was bootstrapped and regression tested on
> alphaev68-linux-gnu [2] and everything was OK.
>
> [2] https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00577.html
I'll approve the patch. scalbln is part of the ISO C standard as well
as IEEE 1003.1, so I think we can rely on it. If there's a host
without, then we'll have to figure something out if/when the issue is
reported.
jeff
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-09 5:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-07 12:44 [PATCH] Fix for PR ipa/64503 Uros Bizjak
2015-01-08 17:04 ` Jakub Jelinek
2015-01-08 18:42 ` Uros Bizjak
2015-01-08 19:05 ` Jakub Jelinek
2015-01-08 19:34 ` Mike Stump
-- strict thread matches above, loose matches on Subject: below --
2015-01-06 17:49 Martin Liška
2015-01-06 18:25 ` Uros Bizjak
2015-01-07 10:55 ` Uros Bizjak
2015-01-07 11:35 ` Martin Liška
2015-01-09 5:18 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).