From: Uros Bizjak <ubizjak@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [x86_64 PATCH] Use [(const_int 0)] idiom consistently in i386.md
Date: Wed, 10 May 2023 21:50:15 +0200 [thread overview]
Message-ID: <CAFULd4a9VFugk3XP+c7BaJSB+q87Pg93WaBDwJfFscOhLO6RNw@mail.gmail.com> (raw)
In-Reply-To: <000001d98374$7971dad0$6c559070$@nextmovesoftware.com>
On Wed, May 10, 2023 at 9:20 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> Hi Uros,
> This cleans up the use of [(clobber (const_int 0))] in the i386 backend.
> My apologies I must have copied this idiom from one of the other targets:
> aarch64.md, arm.md, thumb1.md, avr.md, or sparc.md.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=unix{-m32}
> with no new failures. Ok for mainline?
>
>
> 2023-05-10 Roger Sayle <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
> * config/i386/i386.md (*concat<mode><dwi>3_1): Use preferred
> [(const_int 0)] idiom, instead of [(clobber (const_int 0))].
> (*concat<mode><dwi>3_2): Likewise.
> (*concat<mode><dwi>3_3): Likewise.
> (*concat<mode><dwi>3_4): Likewise.
> (*concat<mode><dwi>3_5): Likewise.
> (*concat<mode><dwi>3_6): Likewise.
> (*concat<mode><dwi>3_7): Likewise.
OK, even as an obvious patch.
Thanks,
Uros.
>
>
> Thanks,
> Roger
> --
>
prev parent reply other threads:[~2023-05-10 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 19:20 Roger Sayle
2023-05-10 19:50 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4a9VFugk3XP+c7BaJSB+q87Pg93WaBDwJfFscOhLO6RNw@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).