From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 4E4AE385781F for ; Wed, 12 Jul 2023 09:38:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E4AE385781F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fb8574a3a1so10491237e87.1 for ; Wed, 12 Jul 2023 02:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689154687; x=1691746687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NwCm9sSbB/qn2qrhaUpzISmIOZRmR08LRw+ciNOXk1I=; b=eO3JtuCzkX62b1Qzd9wbvLhZ03ZtedBpjvz0bhZeVBvl3YN4YF6jMaHAOc1av/lpCH 5lrj9xHs89gWz15F6VJ3VgFXimqCMskqrq/gzixnIMs3DU5qiW2ByXBTgg7PQMkbQCFv HNJJY+RvM7ww54z/m5ihKZyQpvpctKTYTURl7wmjVeFKNHZoDohVGMWHsbnPn1vF5bjq SluDvuGBsdBBaV563n5blqoIX6aUedaYdJpB77s+rAWVM3IlnXyd9SfCjsJF3/IT4GPk WoVEr+HX7l1cR+CkVZl4H9xDuXv2ioFk1YNbIQXLKfrlzqbU9xhtALFuzl/W0o/rNJBk AHwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689154687; x=1691746687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NwCm9sSbB/qn2qrhaUpzISmIOZRmR08LRw+ciNOXk1I=; b=Kr1/j6iN1mHOWPXwoRi1TW1v752Cxd2F8RQ37u5gdXI6Jd2BEFkG8b/K0K+U6FEXq1 9HzeUeE9+6qKQNUn+JqFKI8Q0jtTIzOkfVBJmIrqXp+n6qBvIVLFajeaQjc9ToET+YZB T9Veiv/J7GbD+XE/8h+eY8StK2MMNehH/CwMeqCtY7mq3v8SSoecn2cZr0zhnWvzT0M1 DK+t4kQ1wHswKc+S++8yVpFa3uH/edx5ip6Ex3y4VbHbEzfRA/a6n7Cm6u+DAfVQgfdm pmYmUZZ4leU0m3+QdgJ7ShY/Q+p78RHb6ipaoZUndatdnE9M5BqgvjhBLmJr2svN7pli /Mfg== X-Gm-Message-State: ABy/qLYIW5+bJVOaQqcF+yPrPRoFCUFZLulOYzQPCM2AznrhN4KM0aux lSD+4W6uwKKZ0WBjYpv6QJs4HM/jpgRdFI0XBN1+QbBzPcY= X-Google-Smtp-Source: APBJJlHBKoFnu4lXz58tgShRX6pwTbiUijhw7MjqTidw5xciCQm48U72JWwMt8WaBdfEdIMa1fVC00k12/He8oH61Dc= X-Received: by 2002:ac2:5fc9:0:b0:4fa:ad2d:6c58 with SMTP id q9-20020ac25fc9000000b004faad2d6c58mr12310443lfg.61.1689154686387; Wed, 12 Jul 2023 02:38:06 -0700 (PDT) MIME-Version: 1.0 References: <02a401d9b433$47f0de80$d7d29b80$@nextmovesoftware.com> In-Reply-To: <02a401d9b433$47f0de80$d7d29b80$@nextmovesoftware.com> From: Uros Bizjak Date: Wed, 12 Jul 2023 11:37:55 +0200 Message-ID: Subject: Re: [x86 PATCH] Fix FAIL of gcc.target/i386/pr91681-1.c To: Roger Sayle Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 11, 2023 at 10:07=E2=80=AFPM Roger Sayle wrote: > > > The recent change in TImode parameter passing on x86_64 results in the > FAIL of pr91681-1.c. The issue is that with the extra flexibility, > the combine pass is now spoilt for choice between using either the > *add3_doubleword_concat or the *add3_doubleword_zext > patterns, when one operand is a *concat and the other is a zero_extend. > The solution proposed below is provide an *add3_doubleword_concat_ze= xt > define_insn_and_split, that can benefit both from the register allocation > of *concat, and still avoid the xor normally required by zero extension. > > I'm investigating a follow-up refinement to improve register allocation > further by avoiding the early clobber in the =3D&r, and handling (custom) > reloads explicitly, but this piece resolves the testcase failure. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check, both with and without --target_board=3Dunix{-m32} > with no new failures. Ok for mainline? > > > 2023-07-11 Roger Sayle > > gcc/ChangeLog > PR target/91681 > * config/i386/i386.md (*add3_doubleword_concat_zext): New > define_insn_and_split derived from *add3_doubleword_concat > and *add3_doubleword_zext. OK. Thanks, Uros. > > > Thanks, > Roger > -- >