From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id E4F0E3857356 for ; Tue, 5 Dec 2023 11:20:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4F0E3857356 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4F0E3857356 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701775215; cv=none; b=aLGJ3r8vnFMnfYSYjBvf1AK74qQBK58dnn/Mtho1k2h/5aDqDuJzfdrRAbFaL2WT8uUWXTVWwJKNMfuJsGfQ/1chKHCiU0EjzHBTV1mAGiE1a3i3kytxSgPOFHagLqWd4ElxTGEBBFsUxXgHpfDUWIHkIkcAg8yaPugtlEedpos= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701775215; c=relaxed/simple; bh=+IKtruBUPWUBIPh2oKkArVvVIGzj+XJXBsKgWfV6qJc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=dLnLDwt9fhgwKRGYnetyn8rTUV8B57erEBHsUu7F3RebNruw5clx8BOy+sIIP9w3lP+i0m3d8RyxbFcNU6voVxx3/Z4VaoJKqKdt/TrxCEI8hFEP4oRZljPGU1ufsvY2KWCzgtsbekXKnIDQUN+mEgFEMyMlBCkan7swMcMNmD0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54cff638658so1377656a12.1 for ; Tue, 05 Dec 2023 03:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701775212; x=1702380012; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6NbKZGN+5IuqXHeGwQjL2JF6alU1Qw85DxlY877hknI=; b=SnfHh0Kluuo73OyleLzKaXAxn4B6iLsmgvErSIH9A6YRtOAt3m5Zq7jLaP1nD6Zfw7 2011DqydpS18P97Qx4y5APaSb/Zy2TyGrgKdUqcA+tcimkkNkXHf83zUQs2Ijfymq+Jl tTKNps+Pl1kg//B4cBE8oi50RrX8pur+2u0GjGW8sNgokpPHrIB2yTlIpdHhZa+4vB+B GZHapousPnI4asaXIiH4d1GS2UdBa0/O+YoLQk7gtrBJbVNcgQO6i39NEF6mYU4CMarL A0tXB7IaAExWBwiduM8gMuEPNH6gJbxITInDxBNYIoiDpukzHhuRd/S0XGVrDGIGAeI0 pv2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701775212; x=1702380012; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6NbKZGN+5IuqXHeGwQjL2JF6alU1Qw85DxlY877hknI=; b=QPDaOJLfN0JAsKiqQMrTYuVCcXaMIqYB41cSGctEtx91uJ/GVEt9/97+OHxMTR+2m/ 1b/s4BBtvwnyNO++X40pr+yAckBfhB5LbL7mt6upQmJTCJRalR2lF0IPg6Ib7M6gTvz5 turPF0W6GrEFiK4EPNAtO7GZV9EGbYSbyu9vKwZPNcGJC/bjW2jRkJlqq0XFo0EFjlOM 9uOIEtsgfZbve2JdyEmGRce7jdAwIskW9HhWzYVYW8gfzCFqVa+oUKmrE7LZFgTPM6lf +WVJFKwjh0mHfyyynmnnXIKHykkTgWgtrYAoBuOjeCkoYmQxQRr/rbeECErjoB5KbRmh n0sA== X-Gm-Message-State: AOJu0YxjbIrfF4jw6qO0VUGE6Yr3D7/nWbKUMM6Gh6iInFwfjeHSnHF0 z1F2dcIwfMuvTcC3JHOO0t9uppNuFm719h+COQ084lajD/0= X-Google-Smtp-Source: AGHT+IGSMVl55+uhTsKFl77lMvVI6wAEGYCBxcCAQ/1OV8tjSgimvwWCWAICZED7aJ1HQiauR335mP5VCpO2kRhJS5o= X-Received: by 2002:a50:d0d0:0:b0:54c:f1cd:57b with SMTP id g16-20020a50d0d0000000b0054cf1cd057bmr1310923edf.32.1701775212415; Tue, 05 Dec 2023 03:20:12 -0800 (PST) MIME-Version: 1.0 References: <20231205022948.504790-1-hongyu.wang@intel.com> <20231205022948.504790-4-hongyu.wang@intel.com> In-Reply-To: <20231205022948.504790-4-hongyu.wang@intel.com> From: Uros Bizjak Date: Tue, 5 Dec 2023 12:20:00 +0100 Message-ID: Subject: Re: [PATCH 03/17] [APX NDD] Support APX NDD for optimization patterns of add To: Hongyu Wang Cc: gcc-patches@gcc.gnu.org, hongtao.liu@intel.com, Kong Lingling Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 5, 2023 at 3:29=E2=80=AFAM Hongyu Wang = wrote: > > From: Kong Lingling > > gcc/ChangeLog: > > * config/i386/i386.md: (addsi_1_zext): Add new alternatives for > NDD and adjust output templates. > (*add_2): Likewise. > (*addsi_2_zext): Likewise. > (*add_3): Likewise. > (*addsi_3_zext): Likewise. > (*adddi_4): Likewise. > (*add_4): Likewise. > (*add_5): Likewise. > (*addv4): Likewise. > (*addv4_1): Likewise. > (*add3_cconly_overflow_1): Likewise. > (*add3_cc_overflow_1): Likewise. > (*addsi3_zext_cc_overflow_1): Likewise. > (*add3_cconly_overflow_2): Likewise. > (*add3_cc_overflow_2): Likewise. > (*addsi3_zext_cc_overflow_2): Likewise. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/apx-ndd.c: Add more test. > --- > gcc/config/i386/i386.md | 310 +++++++++++++++--------- > gcc/testsuite/gcc.target/i386/apx-ndd.c | 53 ++-- > 2 files changed, 232 insertions(+), 131 deletions(-) > > diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md > index cb227d19f40..2a73f6dcaec 100644 > --- a/gcc/config/i386/i386.md > +++ b/gcc/config/i386/i386.md > @@ -6476,13 +6476,15 @@ (define_insn "*add_1" > ;; patterns constructed from addsi_1 to match. > > (define_insn "addsi_1_zext" > - [(set (match_operand:DI 0 "register_operand" "=3Dr,r,r") > + [(set (match_operand:DI 0 "register_operand" "=3Dr,r,r,r,r") > (zero_extend:DI > - (plus:SI (match_operand:SI 1 "nonimmediate_operand" "%0,r,r") > - (match_operand:SI 2 "x86_64_general_operand" "rBMe,0,l= e")))) > + (plus:SI (match_operand:SI 1 "nonimmediate_operand" "%0,r,r,r,r= m") > + (match_operand:SI 2 "x86_64_general_operand" "rBMe,0,l= e,rBMe,re")))) > (clobber (reg:CC FLAGS_REG))] > - "TARGET_64BIT && ix86_binary_operator_ok (PLUS, SImode, operands)" > + "TARGET_64BIT && ix86_binary_operator_ok (PLUS, SImode, operands, > + TARGET_APX_NDD)" > { > + bool use_ndd =3D (which_alternative =3D=3D 3 || which_alternative =3D= =3D 4); Can get_attr_isa (insn) =3D=3D ISA_APX_NDD be used instead? Uros.