From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by sourceware.org (Postfix) with ESMTPS id 95478394FC21 for ; Thu, 29 Apr 2021 06:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 95478394FC21 Received: by mail-qt1-x834.google.com with SMTP id f12so48467912qtf.2 for ; Wed, 28 Apr 2021 23:40:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WWSFys9wHUkewuUHqgD5sWwP8DpqAxD+Xr+Oyb1jUxI=; b=P9J+mQIQ5A/eTwKmNWaDPBlwI2qEFue5VoR8IPELq5AP9K9o2CgseBahJT4HFfN7Pl Pp4MWV4M98ZDgNqpIj7yxCEgygF2b8K8O2gqmR0XICNjxolb91MeawdaYJyGgj2z8OO1 +ZqHeK3WKPMSOYCDJux+LwXBzn6myonUrCAPqiWlrE4RObJxOL1JZdyOSVOBgK+NkxL4 hfbM5ov6DgTUaOgYFbb0xjeffT4Ntwj9nbJnj/UEsgyNoRU4EfOJ9JNEoGdZ9XD08lCQ tLDLxYvDNzCYV8ttv3YvGC1k8eyOLCavn50YduV37G2Z18+lYnmnXFB1JexXcK1HpCLS SxsA== X-Gm-Message-State: AOAM533mj0sbJvRtRqMdnyGapBHg6gqGy3HDc8A6PZvRY796c7fXunbP kKy0sekjjOlfpkgxDmSzzEb/7QG2/E6TEa+DwRo= X-Google-Smtp-Source: ABdhPJzVeGHPE+bVcsovsaqcB40szBIG2WoYfUtcaZMyV02sN1yt773FdzbQ8HOICO+Vmwvq5cAuFVozQWda9BglRKc= X-Received: by 2002:ac8:4d5e:: with SMTP id x30mr30940875qtv.51.1619678417201; Wed, 28 Apr 2021 23:40:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Thu, 29 Apr 2021 08:40:06 +0200 Message-ID: Subject: Re: add ASM_OUTPUT_MAX_SKIP_ALIGN to i386.h To: Alexandre Oliva Cc: "gcc-patches@gcc.gnu.org" , Jan Hubicka Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 06:40:19 -0000 On Thu, Apr 29, 2021 at 6:10 AM Alexandre Oliva wrote: > > On Apr 28, 2021, Uros Bizjak wrote: > > > On a related note, while looking at gcc/config.gcc, I noticed that > > there are two identical code blocks under ${target} i[34567]86-*-* and > > x86-64-*-*. As much as I have eyeballed the code, I can't find the > > difference, so perhaps these two blocks should have been merged? > > They are equivalent indeed, despite a slight reordering of one > assignment that is of no significance. > > Here's a patch that implements this change. Regstrapped on > x86_64-linux-gnu. Ok to install? > > > merge ix86- and x86_64-*-* in config.gcc > > Uroz observed that i[34567]86-*-* and x86_64-*-* cpu_type-setting Uros ... but no need to credit me. > target cases were equivalent. I've verified that this was the case, > and combined them. > > > for gcc/ChangeLog > > * config.gcc: Merged x86 and x86_64 cpu_type-setting cases. OK. Thanks, Uros. > --- > gcc/config.gcc | 40 +--------------------------------------- > 1 file changed, 1 insertion(+), 39 deletions(-) > > diff --git a/gcc/config.gcc b/gcc/config.gcc > index e49e40fbfa1bf..92fad8e20ca20 100644 > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -379,7 +379,7 @@ fido-*-*) > extra_headers=math-68881.h > extra_options="${extra_options} m68k/m68k-tables.opt" > ;; > -i[34567]86-*-*) > +i[34567]86-*-* | x86_64-*-*) > cpu_type=i386 > c_target_objs="i386-c.o" > cxx_target_objs="i386-c.o" > @@ -417,44 +417,6 @@ i[34567]86-*-*) > hresetintrin.h keylockerintrin.h avxvnniintrin.h > mwaitintrin.h" > ;; > -x86_64-*-*) > - cpu_type=i386 > - c_target_objs="i386-c.o" > - cxx_target_objs="i386-c.o" > - d_target_objs="i386-d.o" > - extra_options="${extra_options} fused-madd.opt" > - extra_objs="x86-tune-sched.o x86-tune-sched-bd.o x86-tune-sched-atom.o x86-tune-sched-core.o i386-options.o i386-builtins.o i386-expand.o i386-features.o" > - target_gtfiles="\$(srcdir)/config/i386/i386-builtins.c \$(srcdir)/config/i386/i386-expand.c \$(srcdir)/config/i386/i386-options.c" > - extra_headers="cpuid.h mmintrin.h mm3dnow.h xmmintrin.h emmintrin.h > - pmmintrin.h tmmintrin.h ammintrin.h smmintrin.h > - nmmintrin.h bmmintrin.h fma4intrin.h wmmintrin.h > - immintrin.h x86intrin.h avxintrin.h xopintrin.h > - ia32intrin.h cross-stdarg.h lwpintrin.h popcntintrin.h > - lzcntintrin.h bmiintrin.h bmi2intrin.h tbmintrin.h > - avx2intrin.h avx512fintrin.h fmaintrin.h f16cintrin.h > - rtmintrin.h xtestintrin.h rdseedintrin.h prfchwintrin.h > - adxintrin.h fxsrintrin.h xsaveintrin.h xsaveoptintrin.h > - avx512cdintrin.h avx512erintrin.h avx512pfintrin.h > - shaintrin.h clflushoptintrin.h xsavecintrin.h > - xsavesintrin.h avx512dqintrin.h avx512bwintrin.h > - avx512vlintrin.h avx512vlbwintrin.h avx512vldqintrin.h > - avx512ifmaintrin.h avx512ifmavlintrin.h avx512vbmiintrin.h > - avx512vbmivlintrin.h avx5124fmapsintrin.h avx5124vnniwintrin.h > - avx512vpopcntdqintrin.h clwbintrin.h mwaitxintrin.h > - clzerointrin.h pkuintrin.h sgxintrin.h cetintrin.h > - gfniintrin.h cet.h avx512vbmi2intrin.h > - avx512vbmi2vlintrin.h avx512vnniintrin.h > - avx512vnnivlintrin.h vaesintrin.h vpclmulqdqintrin.h > - avx512vpopcntdqvlintrin.h avx512bitalgintrin.h > - pconfigintrin.h wbnoinvdintrin.h movdirintrin.h > - waitpkgintrin.h cldemoteintrin.h avx512bf16vlintrin.h > - avx512bf16intrin.h enqcmdintrin.h serializeintrin.h > - avx512vp2intersectintrin.h avx512vp2intersectvlintrin.h > - tsxldtrkintrin.h amxtileintrin.h amxint8intrin.h > - amxbf16intrin.h x86gprintrin.h uintrintrin.h > - hresetintrin.h keylockerintrin.h avxvnniintrin.h > - mwaitintrin.h" > - ;; > ia64-*-*) > extra_headers=ia64intrin.h > extra_options="${extra_options} g.opt fused-madd.opt" > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Vim, Vi, Voltei pro Emacs -- GNUlius Caesar