From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com
 [IPv6:2607:f8b0:4864:20::733])
 by sourceware.org (Postfix) with ESMTPS id BA43B38485BE
 for <gcc-patches@gcc.gnu.org>; Thu, 30 Jun 2022 06:20:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA43B38485BE
Received: by mail-qk1-x733.google.com with SMTP id z7so13719737qko.8
 for <gcc-patches@gcc.gnu.org>; Wed, 29 Jun 2022 23:20:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=HmQnQzXS4h1vNaTwfojVPFAiiAy0ScQZcxuN4cSo39o=;
 b=Cf+9fdJWgaxbytYr6Gg2qRzgFfoAybZMlRtz+bwSxa74Lducy5ogx44w4H+YFvedQ/
 1vHBeSY4YJm/Bnu9SSeKQdCd4SjPlLYGvecKWLuL8KRtcmFuCMZ059O18MBxh86LZMc2
 BxiOpi7kYQEumtA8BtjPy9i/CxncPXnLa9NYJcPT8Ujb9idI0p3SJl9mUV86UfHu/gIe
 raisEDpfPfuJ8zGfZSgPmbXYmoxUGplEWpeO6hMdhaPT+PE+qQk5bG2PgY9y1JRXZYYq
 Tr+78JiY2USUf0wc2DkNtJ86U5PfscaLw8aaNSvVCybWW7g7AOOS/A63W8c9fx/r7Eq9
 +EWg==
X-Gm-Message-State: AJIora9mu5S93u3u+6qyeAXDOyMovlmbieUQ14SXJS1bFKT1Ku4u+sd8
 1nnF2HCwlqx3wrLTe7D0+72f/yRSqpAOVczGGQI=
X-Google-Smtp-Source: AGRyM1sVIyogZeDFZ8/1jDeMRJg0JXXLTBCWE9oc2dRr4+07OrUKvdzZ/gc9c6h0hmZh4Ac65dw9p3rqYwUuoxvPCOY=
X-Received: by 2002:a37:9c92:0:b0:6af:4532:34f4 with SMTP id
 f140-20020a379c92000000b006af453234f4mr5172724qke.674.1656570014912; Wed, 29
 Jun 2022 23:20:14 -0700 (PDT)
MIME-Version: 1.0
References: <20220630055907.50030-1-haochen.jiang@intel.com>
In-Reply-To: <20220630055907.50030-1-haochen.jiang@intel.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Thu, 30 Jun 2022 08:20:03 +0200
Message-ID: <CAFULd4aJ_a+zQh_L5eeAiBpiGAY8gcLuK9psQ6fXftc4k-TJig@mail.gmail.com>
Subject: Re: [PATCH] i386: Extend cvtps2pd to memory
To: Haochen Jiang <haochen.jiang@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
 Hongtao Liu <hongtao.liu@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2022 06:20:17 -0000

On Thu, Jun 30, 2022 at 7:59 AM Haochen Jiang <haochen.jiang@intel.com> wrote:
>
> Hi all,
>
> This patch aims to fix the cvtps2pd insn, which should also work on
> memory operand but currently does not. After this fix, when loop == 2,
> it will eliminate movq instruction.
>
> Regtested on x86_64-pc-linux-gnu. Ok for trunk?
>
> BRs,
> Haochen
>
> gcc/ChangeLog:
>
>         PR target/43618
>         * config/i386/sse.md (extendv2sfv2df2): New define_expand.
>         (sse2_cvtps2pd_load<mask_name>): Rename extendvsdfv2df2.
>
> gcc/testsuite/ChangeLog:
>
>         PR target/43618
>         * gcc.target/i386/pr43618-1.c: New test.

This patch could be as simple as:

diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 8cd0f617bf3..c331445cb2d 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -9195,7 +9195,7 @@
(define_insn "extendv2sfv2df2"
  [(set (match_operand:V2DF 0 "register_operand" "=v")
       (float_extend:V2DF
-         (match_operand:V2SF 1 "register_operand" "v")))]
+         (match_operand:V2SF 1 "nonimmediate_operand" "vm")))]
  "TARGET_MMX_WITH_SSE"
  "%vcvtps2pd\t{%1, %0|%0, %1}"
  [(set_attr "type" "ssecvt")

Uros.