From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-335483-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 30646 invoked by alias); 14 Jan 2013 18:41:10 -0000
Received: (qmail 30498 invoked by uid 22791); 14 Jan 2013 18:41:07 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-oa0-f45.google.com (HELO mail-oa0-f45.google.com) (209.85.219.45)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 18:40:57 +0000
Received: by mail-oa0-f45.google.com with SMTP id i18so4248221oag.4        for <gcc-patches@gcc.gnu.org>; Mon, 14 Jan 2013 10:40:56 -0800 (PST)
MIME-Version: 1.0
Received: by 10.60.29.226 with SMTP id n2mr51351153oeh.132.1358188856689; Mon, 14 Jan 2013 10:40:56 -0800 (PST)
Received: by 10.182.153.201 with HTTP; Mon, 14 Jan 2013 10:40:56 -0800 (PST)
In-Reply-To: <20130114180601.GA30577@one.firstfloor.org>
References: <CAFULd4Ztbccsq9h50Tp-0JGHr4CoFJ2QByf0WgS4Ed92_09=Rw@mail.gmail.com>	<20130113203603.GS30577@one.firstfloor.org>	<CAFULd4YbA_JPrHgmDRfaA8mHKvRuLitnVkGtzeMMo2FCexkTXw@mail.gmail.com>	<20130113221251.GW30577@one.firstfloor.org>	<CAFULd4ae7eqmyha0UrtL-ECNh_k9KXv0eYp9B1==Y+ELYNcMRA@mail.gmail.com>	<20130113222946.GX30577@one.firstfloor.org>	<CAFULd4bWUhZ2ZLJA7Cs+oxxdPvfHbzcmMDgB7b11ZhZbD6JF1g@mail.gmail.com>	<20130114180601.GA30577@one.firstfloor.org>
Date: Mon, 14 Jan 2013 18:41:00 -0000
Message-ID: <CAFULd4aM6JurfvdO8RLCwE1Mz2jVGKSFZ5YT4cyGXB9MKNXQ8g@mail.gmail.com>
Subject: Re: [PATCH 2/2] Support __ATOMIC_HLE_RELEASE for __atomic_clear/store_n
From: Uros Bizjak <ubizjak@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2013-01/txt/msg00726.txt.bz2

On Mon, Jan 14, 2013 at 7:06 PM, Andi Kleen <andi@firstfloor.org> wrote:
>> This cannot happen, we reject code that sets both __HLE* flags.
>
> BTW I found more HLE bugs, it looks like some of the fetch_op_*
> patterns do not match always and fall back to cmpxchg, which
> does not generate HLE code correctly. Not fully sure what's
> wrong, can you spot any obvious problems? You changed the
>
> (define_insn "atomic_<logic><mode>"
>
> pattern last.

I don't think this is a target problem, these insns work as expected
and are covered by extensive testsuite in gcc.target/i386/hle-*.c.

Uros.