public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: Kirill Yukhin <kirill.yukhin@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, i386] Merge SSE and AVX ptest patterns.
Date: Tue, 04 Aug 2015 12:06:00 -0000	[thread overview]
Message-ID: <CAFULd4aN9GxLOMErwpHq2vnH0ToTE9=YvR3ZsFgDKSGpVWKGfA@mail.gmail.com> (raw)
In-Reply-To: <20150804115838.GB32256@msticlxl57.ims.intel.com>

On Tue, Aug 4, 2015 at 1:58 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
> I've merged ptest insn patterns from AVX and SSE.
> I've also extended mode iterator to allow any 128/256 bit mode
> for the insn as it register-wide, which may help implementing
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg02788.html
>
>
> Bootstrapped and regtested.
>
> If no objections, I'll commit it into main trunk tomorrow morning (Moscow time).
>
> gcc/
>         * config/i386/i386.c (bdesc_args): Rename CODE_FOR_sse4_1_ptest into
>         CODE_FOR_sse4_1_ptestv2di and CODE_FOR_avx_vtestps256 into
>         CODE_FOR_avx_ptestv4di.
>         * config/i386/sse.md (define_mode_iterator V_AVX): New.
>         (define_mode_attr sse4_1): Extend to other 128/256-bit modes.
>         (define_insn "avx_ptest256"): Merge this ...
>         (define_insn "sse4_1_ptest"): And this ...
>         (define_insn "<sse4_1>_ptest<mode>"): Into this. Use V_AVX iterator.
>
> +   (set (attr "btver2_decode")
> +     (if_then_else
> +       (and (eq_attr "alternative" "2")
> +           (match_test "<sseinsnmode>mode==OImode"))
> +     (const_string "vector")
> +     (const_string "*")))

"vector" does not depend on alternative, but only on
<sseinsnsmode>mode. So the and above should be removed.

Uros.

  reply	other threads:[~2015-08-04 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 11:59 Kirill Yukhin
2015-08-04 12:06 ` Uros Bizjak [this message]
2015-08-04 12:33   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFULd4aN9GxLOMErwpHq2vnH0ToTE9=YvR3ZsFgDKSGpVWKGfA@mail.gmail.com' \
    --to=ubizjak@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kirill.yukhin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).