From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by sourceware.org (Postfix) with ESMTPS id 2696A3858CDB for ; Sun, 6 Nov 2022 19:53:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2696A3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-36cbcda2157so87021987b3.11 for ; Sun, 06 Nov 2022 11:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BHXrYzW2r9OCTj7unIL65a2UNuu4xmep7xghpeEhQqM=; b=B41wyeJoBQzwRWwclYmVDlaZ5YeTKBsTmsgdjhp1h0rmqEN8LTttiUwlUseF0Xm+nL C0RzcDKMqYj58BLrKXNU3weIslbf0JRNBZPoyO94nnr5m7JarBY1QAJbG2CjdJV0kUEh IpXfcQzz2xTpY31xOVea1AYjf6oxgdb/pJx9n0nYiSF4mMWH5ZicsObjbUpO/j1cK8Gv EVUnkuKreGd5V0sM4kb9nqCSZVmHQleG8LBJjjgzh7P0vsEXcb0xcgqjNoANACTUa29r LFT6ZPl7H7oDrbaV9mDdVo/Ys8CspSHPIjfaaRWc+vv6zOkuARxcCUVj7MoQKsqQz0qe xYEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BHXrYzW2r9OCTj7unIL65a2UNuu4xmep7xghpeEhQqM=; b=lSa/o5Qcha7yq+cvDlteZ5ilxGuoroUtkMVUemdv3IqXHKQSH+Q/8sHV+b88C4b5f6 jkVgHfU8CjZcO2MqvtkUK8tdxEmyMtgxwPv4kgmlAj3K4jEyigaezb6ax2OxX9bY7nRS +rRJ0gVMyRa/40AfLK4wA6NSV6NkguNJgj4SsgtIBKoJk73PlfZZsFH7MzxN+Q3JFQmN pUXUcxyIHSxrHegIeLbsM+RMua6T87FLSFOt9dZWOSzoIoho3a+7aaM6YAu+vi7XPLo1 BYxzRfF+S0LczDUzDOgMVmQ4Zcrrbtlf5PiS/B8UkRgR45obAJ4DzLGMIHrWoMawth/I ycug== X-Gm-Message-State: ACrzQf2aeF5XZXGIdD5iXRPinznYuiUxWwfAglg0QY1YQw3TV8Y2L6jA RFGeZgDCQtY7Rg0bsWJR65TroZJcpE8EPgtBy5Q= X-Google-Smtp-Source: AMsMyM6nPAKFiauhHEmlVk+Kq34ofP5ExLSewaCWa/ciWPpPP29f2wK+MHajpc519CqnE0Vtbg02NajJn5cJPDmNZhw= X-Received: by 2002:a81:6c8f:0:b0:373:5443:420d with SMTP id h137-20020a816c8f000000b003735443420dmr25371122ywc.495.1667764414381; Sun, 06 Nov 2022 11:53:34 -0800 (PST) MIME-Version: 1.0 References: <546be11b-5bb6-e312-e309-291787d25018@linux.ibm.com> <5066b86d-81a8-5a81-cbbb-4b2b8f57ad98@linux.ibm.com> In-Reply-To: From: Uros Bizjak Date: Sun, 6 Nov 2022 20:53:23 +0100 Message-ID: Subject: Re: optabs: Variable index vec_set To: Richard Biener Cc: Robin Dapp , GCC Patches Content-Type: multipart/mixed; boundary="0000000000007d2e9a05ecd2a900" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007d2e9a05ecd2a900 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Nov 5, 2022 at 12:25 PM Richard Biener wrote: > > On Wed, Nov 2, 2022 at 1:46 PM Uros Bizjak wrote: > > > > On Wed, Nov 2, 2022 at 1:45 PM Robin Dapp wrote: > > > > > > > IIRC, I was trying to "fix" modeless operand by giving it a mode, b= ut > > > > since it made no difference for x86, I later dropped the patch. > > > > However, operand with a known mode is preferred, so if it works for > > > > you, just include my patch in your submission. My patch is somehow > > > > trivial if we want operand to have known mode. > > > > > > I'd prefer to push it separately as my patch changes several things i= n > > > the s390 backend that are kind of unrelated. Is it OK to do an x86 > > > bootstrap and regtest and push it if everything looks good? You can = of > > > course also do it yourself :) > > > > It is a middle-end patch, someone will have to approve it. > > The patch is OK Thanks, pushed with the following ChangeLog: optabs: Use operand[2] mode in can_vec_set_var_idx_p Use operand[2] mode in can_vec_set_var_idx_p when checking vec_set_optab. This change allows non-VOID index operand in vec_set_optab. 2022-11-06 Uro=C5=A1 Bizjak gcc/ChangeLog: * optabs.cc (can_vec_set_var_idx_p): Use operand[2] mode when checking vec_set_optab. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Uros. --0000000000007d2e9a05ecd2a900 Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_la5ruxi00 ZGlmZiAtLWdpdCBhL2djYy9vcHRhYnMuY2MgYi9nY2Mvb3B0YWJzLmNjCmluZGV4IGMyYTZmOTcx ZDc0Li45ZmM5YjFmYzZlOSAxMDA2NDQKLS0tIGEvZ2NjL29wdGFicy5jYworKysgYi9nY2Mvb3B0 YWJzLmNjCkBAIC00MzQ0LDEyICs0MzQ0LDE3IEBAIGNhbl92ZWNfc2V0X3Zhcl9pZHhfcCAobWFj aGluZV9tb2RlIHZlY19tb2RlKQogICAgIHJldHVybiBmYWxzZTsKIAogICBtYWNoaW5lX21vZGUg aW5uZXJfbW9kZSA9IEdFVF9NT0RFX0lOTkVSICh2ZWNfbW9kZSk7CisKICAgcnR4IHJlZzEgPSBh bGxvY2FfcmF3X1JFRyAodmVjX21vZGUsIExBU1RfVklSVFVBTF9SRUdJU1RFUiArIDEpOwogICBy dHggcmVnMiA9IGFsbG9jYV9yYXdfUkVHIChpbm5lcl9tb2RlLCBMQVNUX1ZJUlRVQUxfUkVHSVNU RVIgKyAyKTsKLSAgcnR4IHJlZzMgPSBhbGxvY2FfcmF3X1JFRyAoVk9JRG1vZGUsIExBU1RfVklS VFVBTF9SRUdJU1RFUiArIDMpOwogCiAgIGVudW0gaW5zbl9jb2RlIGljb2RlID0gb3B0YWJfaGFu ZGxlciAodmVjX3NldF9vcHRhYiwgdmVjX21vZGUpOwogCisgIGNvbnN0IHN0cnVjdCBpbnNuX2Rh dGFfZCAqZGF0YSA9ICZpbnNuX2RhdGFbaWNvZGVdOworICBtYWNoaW5lX21vZGUgaWR4X21vZGUg PSBkYXRhLT5vcGVyYW5kWzJdLm1vZGU7CisKKyAgcnR4IHJlZzMgPSBhbGxvY2FfcmF3X1JFRyAo aWR4X21vZGUsIExBU1RfVklSVFVBTF9SRUdJU1RFUiArIDMpOworCiAgIHJldHVybiBpY29kZSAh PSBDT0RFX0ZPUl9ub3RoaW5nICYmIGluc25fb3BlcmFuZF9tYXRjaGVzIChpY29kZSwgMCwgcmVn MSkKIAkgJiYgaW5zbl9vcGVyYW5kX21hdGNoZXMgKGljb2RlLCAxLCByZWcyKQogCSAmJiBpbnNu X29wZXJhbmRfbWF0Y2hlcyAoaWNvZGUsIDIsIHJlZzMpOwo= --0000000000007d2e9a05ecd2a900--