public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH, i386]: Extend Load+RegOp to Mov+MemOp peephole2 to all integer modes
Date: Fri, 29 Apr 2016 06:14:00 -0000	[thread overview]
Message-ID: <CAFULd4aPeY6rVZBjmV7MU7QTqyzMotO94ogZHdN-ceJpfQcTCA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hello!

2016-04-29  Uros Bizjak  <ubizjak@gmail.com>

    * config/i386/i386.md (Load+RegOp to Mov+MemOp peephole2):
    Use SWI mode iterator.  Use general_reg_operand predicate.
    (Load+RegOp to Mov+MemOp peephole2 with vector regs): Split
    peephole to MMX and SSE part.  Use mmx_reg_operand and sse_reg_operand
    predicates.

Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

Committed to mainline SVN.

Uros.

[-- Attachment #2: p.diff.txt --]
[-- Type: text/plain, Size: 2850 bytes --]

Index: i386.md
===================================================================
--- i386.md	(revision 235619)
+++ i386.md	(working copy)
@@ -17905,20 +17905,20 @@
 		   (match_op_dup 3 [(match_dup 2) (match_dup 0)]))
 	      (clobber (reg:CC FLAGS_REG))])])
 
-;; Prefer Load+RegOp to Mov+MemOp.  Watch out for cases when the memory address
-;; refers to the destination of the load!
+;; Prefer Load+RegOp to Mov+MemOp.  Watch out for cases when
+;; the memory address refers to the destination of the load!
 
 (define_peephole2
-  [(set (match_operand:SI 0 "register_operand")
-        (match_operand:SI 1 "register_operand"))
+  [(set (match_operand:SWI 0 "general_reg_operand")
+	(match_operand:SWI 1 "general_reg_operand"))
    (parallel [(set (match_dup 0)
-                   (match_operator:SI 3 "commutative_operator"
+		   (match_operator:SWI 3 "commutative_operator"
                      [(match_dup 0)
-                      (match_operand:SI 2 "memory_operand")]))
+		      (match_operand:SWI 2 "memory_operand")]))
               (clobber (reg:CC FLAGS_REG))])]
   "REGNO (operands[0]) != REGNO (operands[1])
-   && GENERAL_REGNO_P (REGNO (operands[0]))
-   && GENERAL_REGNO_P (REGNO (operands[1]))"
+   && (<MODE>mode != QImode
+       || any_QIreg_operand (operands[1], QImode))"
   [(set (match_dup 0) (match_dup 4))
    (parallel [(set (match_dup 0)
                    (match_op_dup 3 [(match_dup 0) (match_dup 1)]))
@@ -17926,21 +17926,29 @@
   "operands[4] = replace_rtx (operands[2], operands[0], operands[1], true);")
 
 (define_peephole2
-  [(set (match_operand 0 "register_operand")
-        (match_operand 1 "register_operand"))
+  [(set (match_operand 0 "mmx_reg_operand")
+	(match_operand 1 "mmx_reg_operand"))
    (set (match_dup 0)
                    (match_operator 3 "commutative_operator"
                      [(match_dup 0)
                       (match_operand 2 "memory_operand")]))]
-  "REGNO (operands[0]) != REGNO (operands[1])
-   && ((MMX_REGNO_P (REGNO (operands[0]))
-        && MMX_REGNO_P (REGNO (operands[1]))) 
-       || (SSE_REGNO_P (REGNO (operands[0]))
-           && SSE_REGNO_P (REGNO (operands[1]))))"
+  "REGNO (operands[0]) != REGNO (operands[1])"
   [(set (match_dup 0) (match_dup 2))
    (set (match_dup 0)
         (match_op_dup 3 [(match_dup 0) (match_dup 1)]))])
 
+(define_peephole2
+  [(set (match_operand 0 "sse_reg_operand")
+	(match_operand 1 "sse_reg_operand"))
+   (set (match_dup 0)
+	(match_operator 3 "commutative_operator"
+	  [(match_dup 0)
+	   (match_operand 2 "memory_operand")]))]
+  "REGNO (operands[0]) != REGNO (operands[1])"
+  [(set (match_dup 0) (match_dup 2))
+   (set (match_dup 0)
+	(match_op_dup 3 [(match_dup 0) (match_dup 1)]))])
+
 ; Don't do logical operations with memory outputs
 ;
 ; These two don't make sense for PPro/PII -- we're expanding a 4-uop

                 reply	other threads:[~2016-04-29  6:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFULd4aPeY6rVZBjmV7MU7QTqyzMotO94ogZHdN-ceJpfQcTCA@mail.gmail.com \
    --to=ubizjak@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).