From: Uros Bizjak <ubizjak@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: alexander.nesterovskiy@intel.com
Subject: Re: [patch, i386] false dependencies fix
Date: Thu, 03 May 2018 09:01:00 -0000 [thread overview]
Message-ID: <CAFULd4aQT2ALkA8mXg1n-okvCPj-2_EFtdgFHrnLtnRA6ypdEw@mail.gmail.com> (raw)
> This patch fixes false dependencies for vmovss, vmovsd, vrcpss, vrsqrtss, vsqrtss and vsqrtsd
> instructions.
>
> Tested on x86-64/Linux, no new test fails, some SPEC 2006/2017 performance gains.
> Please let me know if something is wrong here and should be changed.
Your submission needs a ChangeLog entry. Please see [1]
case MODE_DF:
if (TARGET_AVX && REG_P (operands[0]) && REG_P (operands[1]))
- return "vmovsd\t{%1, %0, %0|%0, %0, %1}";
+ return "%vmovsd\t{%d1, %0|%0, %d1}";
return "%vmovsd\t{%1, %0|%0, %1}";
No need to change "v" to "%v". We are always in AVX domain here.
Otherwise OK. Please resubmit the patch with the ChangeLog entry.
[1] https://gcc.gnu.org/contribute.html
Thanks,
Uros.
next reply other threads:[~2018-05-03 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 9:01 Uros Bizjak [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-28 7:16 Uros Bizjak
2018-06-28 13:56 ` Jeff Law
2018-06-29 0:04 ` Jeff Law
2018-05-02 9:55 Nesterovskiy, Alexander
2018-06-28 4:29 ` Jeff Law
2018-06-28 8:57 ` Nesterovskiy, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4aQT2ALkA8mXg1n-okvCPj-2_EFtdgFHrnLtnRA6ypdEw@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=alexander.nesterovskiy@intel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).