From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13069 invoked by alias); 3 May 2018 09:01:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10494 invoked by uid 89); 3 May 2018 09:00:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=submission, resubmit X-HELO: mail-it0-f45.google.com Received: from mail-it0-f45.google.com (HELO mail-it0-f45.google.com) (209.85.214.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 May 2018 09:00:26 +0000 Received: by mail-it0-f45.google.com with SMTP id p3-v6so21013476itc.0 for ; Thu, 03 May 2018 02:00:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=l/rvay0mnwFo0NVbsFhicpe3oIzjtBDL7zTD2IHmLio=; b=oQPQtRKkC6gvY5uTzX3onhCvF3IjqFz8vd7aarAOLc90iKsawS+/nY8/kVIE0vg6sP Up68NcYG0xqLvrDHll5uWx+K59eGsk/suY252Ctb28BtpJRaGn3uwGQCtraVxh79jtww mW+0C4eqCTX3xX8uodTwXHo7oQrXUgHPrNf0b+jmBJG1LJN/9Wd3i23BEB6CC7QjtOoW JT3QXb1EWymYfk4y/+LY0t6wqZvZwtmjb6aPUxN1g12fk2mqvZgts+GE9A+k8Wk6BLPR Siwr1uxWj+foDe0HwD4nYw+tDGh4XJ2rNVeICxdGasKmb4IyCyE9GC4oXrcSzgW3giuh Bq+g== X-Gm-Message-State: ALQs6tDXWDSnXGWW8ajnb3nKO8NjSIy3dEwkYZaDPz+VYvGbujm/XFzK 27M8xI5nF1dco/NOmH7S1KXMlyueeG2cCPAG3M31aHMd X-Google-Smtp-Source: AB8JxZptpTM+QRmHn1NO+RRc33Odsuw74f3lsTaibVo7xipYdEB6WYCURoxRKG7unyV2+NNs6Hu7IBTlCnV5Gjf8a8s= X-Received: by 2002:a24:c301:: with SMTP id s1-v6mr24820341itg.100.1525338024806; Thu, 03 May 2018 02:00:24 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:a30b:0:0:0:0:0 with HTTP; Thu, 3 May 2018 02:00:24 -0700 (PDT) From: Uros Bizjak Date: Thu, 03 May 2018 09:01:00 -0000 Message-ID: Subject: Re: [patch, i386] false dependencies fix To: "gcc-patches@gcc.gnu.org" Cc: alexander.nesterovskiy@intel.com Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-05/txt/msg00133.txt.bz2 > This patch fixes false dependencies for vmovss, vmovsd, vrcpss, vrsqrtss, vsqrtss and vsqrtsd > instructions. > > Tested on x86-64/Linux, no new test fails, some SPEC 2006/2017 performance gains. > Please let me know if something is wrong here and should be changed. Your submission needs a ChangeLog entry. Please see [1] case MODE_DF: if (TARGET_AVX && REG_P (operands[0]) && REG_P (operands[1])) - return "vmovsd\t{%1, %0, %0|%0, %0, %1}"; + return "%vmovsd\t{%d1, %0|%0, %d1}"; return "%vmovsd\t{%1, %0|%0, %1}"; No need to change "v" to "%v". We are always in AVX domain here. Otherwise OK. Please resubmit the patch with the ChangeLog entry. [1] https://gcc.gnu.org/contribute.html Thanks, Uros.