From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 118E3383D82F for ; Wed, 11 May 2022 08:27:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 118E3383D82F Received: by mail-qk1-x72c.google.com with SMTP id a76so1737267qkg.12 for ; Wed, 11 May 2022 01:27:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=434ZEy6w1OG7GQvEj7Kcoc5/js/HXj6tzvO1Opwn0Ec=; b=s9yN99o7pSKgAsOPGLnorj0jAL2ra8NSwm0WBpkJ9J4DIsKB8G0jHxfS/Du4V6mhrQ gIVBU1iavh170rwCAoBSnoEbSUZ6FIxFC4TwdtRZ+CGH7a+69j8nKxvqsE9rlVzVIWti gi7/IsIZfJaAWVS2fXiZ4Tc8lNKoLJkxaHdwQJY1bewzWLf9DrWVDS5t31q6OTA0mNCP WexKGHIOfrWurkKNInqs03WZMpY953orSECXwF9/BQcrzuf08pykeoYPtLkUImsed7r6 MdgzwD7+RWX+7MyiRuI/8Kd/38+0BIZBO23BQbYsSxUB96YGvZM8haPoK1RqPfmJVJ5g /FqA== X-Gm-Message-State: AOAM531efQLj2hqVoURPVsNop0bponVzDfZkldjdvcjqGASrKTVE0pgM pnNV0b5MsQeJhxdx3MDx0EkO0yFpo0jgxwtW3qk= X-Google-Smtp-Source: ABdhPJzk2Zo15u1RL98/TUYfNlk4QEi7ullvQxxFnTWuB4kaN1TTe/fvClcYy1EwiiEhiGsjNn7hdJ/3I8vfGrhAuWo= X-Received: by 2002:a05:620a:2903:b0:6a0:4d8f:8b88 with SMTP id m3-20020a05620a290300b006a04d8f8b88mr16186495qkp.328.1652257644388; Wed, 11 May 2022 01:27:24 -0700 (PDT) MIME-Version: 1.0 References: <20211214102828.GU2646553@tucnak> <80d628c2-ea0d-c542-b0bb-399d83b7292d@suse.cz> <20211214161219.GX2646553@tucnak> <7d1f146e-b196-a5dd-b4b9-23d4ac68b572@suse.cz> <879ec827-1d81-dbdc-b978-a366d28eb175@suse.cz> <8126b287-c55b-0e7a-032b-5211b4cfbbc2@suse.cz> In-Reply-To: From: Uros Bizjak Date: Wed, 11 May 2022 10:27:13 +0200 Message-ID: Subject: Re: [PATCH] i386: simplify cpu_feature handling To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Jakub Jelinek , Stefan Kneifel , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 08:27:27 -0000 On Wed, May 11, 2022 at 10:19 AM Martin Li=C5=A1ka wrote: > > On 5/2/22 09:57, Martin Li=C5=A1ka wrote: > > On 3/31/22 09:01, Martin Li=C5=A1ka wrote: > >> @Jakub: May I install it once stage1 opens? > > > > May I please ping this? > > > > Thanks, > > Martin > > > >> > >> Cheers, > >> Martin > >> > >> On 1/3/22 12:43, Martin Li=C5=A1ka wrote: > >>> PING: Jakub? > >>> > >>> On 12/15/21 10:57, Martin Li=C5=A1ka wrote: > >>>> On 12/14/21 17:12, Jakub Jelinek wrote: > >>>>> I'd use INT_TYPE_SIZE - 1 instead of 31. Otherwise LGTM. > >>>> > >>>> Installed with that change, thanks. > >>>> > >>>> Moreover, I'm suggesting a simplification: > >>>> > >>>> The patch removes unneeded loops for cpu_features2 and CONVERT_EXPR > >>>> that can be simplified with NOP_EXPR. > >>>> > >>>> Survives i386.exp tests, may I install the patch after testing or > >>>> is it a stage1 material? > >>>> > >>>> Thanks, > >>>> Martin > >>> > >> > > > > CCing Uros. > > May I install the patch? Can you please attach the latest version of the patch? I only found the version from Dec. 15. 2021, which I'm not sure is the latest, Thanks, Uros.