From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by sourceware.org (Postfix) with ESMTPS id 1FD053858D28 for ; Sat, 11 Mar 2023 09:17:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FD053858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-536bbe5f888so145083617b3.8 for ; Sat, 11 Mar 2023 01:17:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678526232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7k6LlV4QVCl1EKCNIJ7PCrce/wwgrORWgPCJ+dawEt0=; b=JzVT1LUNkptvXwh+ZW5xxtEQ7EN2e4wZALVbt3k/bbaBIzU8udUs1MelgmA3mM/yK+ oDlTVOtg2gNtvs6AtUiKVJspFj0V78x1wnEGfAwWtFojKW9MlUxskcsO/01SA6k8D1cn ihBbCQyybiwet+HAr/SrEP4UGQMYzATIU81W99W7GRJoSPIz6tYNQoC3oYkLKV3gG6y8 bHSrT9ur+ANbk8nNhF3qxJaq7L+mR/49q5jhRa5BqaOjebZnhBgk0ZyEI2BB7pl4I/o0 SLsZxPv+H5qnx0Ygm//CiN1Fv7heNqSTfatIpHPLcmSMALkSXkd/yhNpXYWazWL+4sOY b2kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678526232; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7k6LlV4QVCl1EKCNIJ7PCrce/wwgrORWgPCJ+dawEt0=; b=TTAt/MPVQHseK3d8c+s8gDwq6kIZKfCVnsO4uWBhBPQne1ihp4yZ3aXeMKhz8ZneUH R9V+LapSdGueLY7rbv21SEWDBUsZgAb1+rBhI8x2bfGqkPhEqJ5fZ91FkzJTkMD2YNNr TwfsSeoAxQoMBII4RwpPsJ/0oOEQbqqQjFVunJ4srvmaYBPPbHgj+OVlG1cyPKmZZ0rV nwK192Ve4uvWYgzNMgCV0nmEEN5vljSTpaCqdr1tjOUy8A2h2ILVXpxJ0ytr7/o6nkEt QmyotBinu0RaBB7b7bX63pDaRZzepmrxhUoO5rem/oD2YsCDTxLtYmRTPN7wF9pPlZK+ wydw== X-Gm-Message-State: AO0yUKXkigLaqXUyvqKX6SgFMxVHLZTRRUWtlA0qMHw7b541Yn/Topn0 kqhnWJDJnwOjyrB/X1cK4cdjs0e+wFy7yGxF3Mg= X-Google-Smtp-Source: AK7set9ZmqyCKg3LtdBZFxcjJyqidn0QB9t/mIEwRKQgae+zVTGTIG31M6+iqRWpB7D/EbWHSSRplSMMMuRt2vpFsT0= X-Received: by 2002:a81:ac4d:0:b0:541:6961:8457 with SMTP id z13-20020a81ac4d000000b0054169618457mr888232ywj.2.1678526232378; Sat, 11 Mar 2023 01:17:12 -0800 (PST) MIME-Version: 1.0 References: <86jzzo4guq.fsf@pew.airs.com> In-Reply-To: <86jzzo4guq.fsf@pew.airs.com> From: Uros Bizjak Date: Sat, 11 Mar 2023 10:17:05 +0100 Message-ID: Subject: Re: Patch ping: Re: [PATCH] libgcc, i386, optabs, v2: Add __float{, un}tibf to libgcc and expand BF -> integral through SF intermediate [PR107703] To: Ian Lance Taylor Cc: Jakub Jelinek , "Joseph S. Myers" , Richard Biener , Jeff Law , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Mar 10, 2023 at 7:11=E2=80=AFPM Ian Lance Taylor wro= te: > > Jakub Jelinek writes: > > > On Wed, Mar 01, 2023 at 01:32:43PM +0100, Jakub Jelinek via Gcc-patches= wrote: > >> On Wed, Nov 16, 2022 at 12:51:14PM +0100, Jakub Jelinek via Gcc-patche= s wrote: > >> > On Wed, Nov 16, 2022 at 10:06:17AM +0100, Jakub Jelinek via > >> > Gcc-patches wrote: > >> > > Thoughts on this? I guess my preference would be the BF -> SF -> = TI > >> > > path because we won't need to waste > >> > > 32: 0000000000015e10 321 FUNC GLOBAL DEFAULT 13 > >> > > __fixbfti@@GCC_13.0.0 > >> > > 89: 0000000000015f60 299 FUNC GLOBAL DEFAULT 13 > >> > > __fixunsbfti@@GCC_13.0.0 > >> > > If so, I'd need to cut the fix parts of the patch below and > >> > > do something in the middle-end. > >> > > >> > Here is adjusted patch that does that. > >> > > >> > 2022-11-16 Jakub Jelinek > >> > > >> > PR target/107703 > >> > * optabs.cc (expand_fix): For conversions from BFmode to integral= , > >> > use shifts to convert it to SFmode first and then convert SFmode > >> > to integral. > >> > > >> > * soft-fp/floattibf.c: New file. > >> > * soft-fp/floatuntibf.c: New file. > >> > * config/i386/libgcc-glibc.ver: Export __float{,un}tibf @ GCC_13.= 0.0. > >> > * config/i386/64/t-softfp (softfp_extras): Add floattibf and > >> > floatuntibf. > >> > (CFLAGS-floattibf.c, CFLAGS-floatunstibf.c): Add -msse2. > >> > >> I'd like to ping the libgcc non-i386 part of this patch, Uros said the= i386 > >> part is ok but that one depends on the generic libgcc changes. > >> I'll ping the optabs.cc change separately. > >> > >> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606398.html > >> with more info in > >> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606382.html > > > > I'd like to ping this again. I've posted the previously added > > bfloat16 changes as well as the above 2 new files to libc-alpha as well > > https://sourceware.org/pipermail/libc-alpha/2023-March/146246.html > > if it makes the review easier. > > > The libgcc parts of this are fine. Thanks. Also OK for the x86 part. Thanks, Uros.