From: Uros Bizjak <ubizjak@gmail.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: "Peryt, Sebastian" <sebastian.peryt@intel.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Koval, Julia" <julia.koval@intel.com>,
"kirill.yukhin@gmail.com" <kirill.yukhin@gmail.com>
Subject: Re: [PATCH] Match x86 family machine constraints section with constarints.md
Date: Wed, 24 May 2017 13:40:00 -0000 [thread overview]
Message-ID: <CAFULd4aWd9x12usyWNv2UBMjOt=ZUw6d=gpUUpvkLFP6MFWLbg@mail.gmail.com> (raw)
In-Reply-To: <59245666.1070802@codesourcery.com>
On Tue, May 23, 2017 at 5:33 PM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On 04/28/2017 03:30 AM, Peryt, Sebastian wrote:
>>
>> Hi,
>>
>> Thank you for your comments. I edited my patch accordingly. As for some of
>> your doubts:
>> - REX is the opcode prefix to access 64-bit register extensions
>> introduced in IA-32e mode.
>> - EVEX is the encoding prefix which applies to SIMD operating instructions
>> operating on XMM, YMM and ZMM registers. It was introduced with AVX-512
>> instructions.
>> - "number factor of four" that means that sources start in a multiple of 4
>> boundary. This is used for some of instructions.
>>
>> Also I'd like to add that this whole patch is strictly based on docstring
>> parts of constraints that are present in config/i386/constraints.md but not
>> in documentation (md.texi file). There is no new (new as in nonexistent in
>> code) content.
>>
>> I'm also adding Kirill Yukhin to CC, because I believe he is the correct
>> person that can catch any technical errors if any has slipped-in.
>
>
> The grammar/markup/etc are OK now, but I can't comment on technical
> correctness of the information.
LGTM.
Thanks,
Uros.
next prev parent reply other threads:[~2017-05-24 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 15:37 Peryt, Sebastian
2017-04-27 21:03 ` Sandra Loosemore
2017-04-28 9:31 ` Peryt, Sebastian
2017-05-23 9:18 ` Peryt, Sebastian
2017-05-23 15:49 ` Sandra Loosemore
2017-05-24 13:40 ` Uros Bizjak [this message]
2017-05-25 6:50 ` Peryt, Sebastian
2017-05-25 19:56 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4aWd9x12usyWNv2UBMjOt=ZUw6d=gpUUpvkLFP6MFWLbg@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=julia.koval@intel.com \
--cc=kirill.yukhin@gmail.com \
--cc=sandra@codesourcery.com \
--cc=sebastian.peryt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).