From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR target/66746: Failure to compile #include <x86intrin.h> with -miamcu
Date: Wed, 08 Jul 2015 17:56:00 -0000 [thread overview]
Message-ID: <CAFULd4a_Ynp9w4krYMFz2MsD-T_LzF1FdqEx59SmYtUoLBQoxw@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOrSRz=EMwfUgSQhA8HJmReTOYaU_biOTtEtboDgMQ6wMQ@mail.gmail.com>
On Wed, Jul 8, 2015 at 6:43 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> x86intrin.h has useful intrinsics for instructions for IA MCU. This
>>> patch adds __iamcu__ check to x86intrin.h and ia32intrin.h.
>>>
>>> OK for trunk?
>>>
>>> H.J.
>>> ---
>>> gcc/
>>>
>>> PR target/66746
>>> * config/i386/ia32intrin.h (__crc32b): Don't define if __iamcu__
>>> is defined.
>>> (__crc32w): Likewise.
>>> (__crc32d): Likewise.
>>> (__rdpmc): Likewise.
>>> (__rdtscp): Likewise.
>>> (_rdpmc): Likewise.
>>> (_rdtscp): Likewise.
>>> * config/i386/x86intrin.h: Only include ia32intrin.h if __iamcu__
>>> is defined.
>>>
>>> gcc/testsuite/
>>>
>>> PR target/66746
>>> * gcc.target/i386/pr66746.c: New file.
>>
>> OK.
>>
>
> It is OK to include <adxintrin.h> for IA MCU since GCC can generate ADX
> intrinsics with alternative instuctions if ADX isn't enabled.
>
> OK for trunk?
>
> H.J.
> ---
> PR target/66746
> * config/i386/x86intrin.h: Include <adxintrin.h> if
> __iamcu__ is defined.
Ok if tested properly.
Thanks,
Uros.
prev parent reply other threads:[~2015-07-08 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 3:53 H.J. Lu
2015-07-03 6:16 ` Uros Bizjak
2015-07-08 16:43 ` H.J. Lu
2015-07-08 17:56 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4a_Ynp9w4krYMFz2MsD-T_LzF1FdqEx59SmYtUoLBQoxw@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).