From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com
 [IPv6:2607:f8b0:4864:20::744])
 by sourceware.org (Postfix) with ESMTPS id D17ED3846405
 for <gcc-patches@gcc.gnu.org>; Tue, 18 Aug 2020 06:09:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D17ED3846405
Received: by mail-qk1-x744.google.com with SMTP id d14so17268377qke.13
 for <gcc-patches@gcc.gnu.org>; Mon, 17 Aug 2020 23:09:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=tfSyM62xoRKEf4ZqeQ1Edc37tugXiwEAks7rVOhxz3s=;
 b=YZEpjGGjD5iXiLiXoBOZPPiwycRcL5d/A7l352G7LHMFhaB8oN8eUYS3eFnpRi8u6A
 HHtz8p8jOVwq9J3wCcYAhehDLRzdTe8ns9jsK3fqT91BTrNle8huxd3URMmXdBZ2mm9m
 XL0IQveOeT4Pv4bAdO4Xmf65G+AS/x+7QSsqG9/ln+4S8/rA9ePLHVOdVr2FQPnd7Uq7
 b21IyOyjaHFntqF0gQbAt+WZZ2zz01ntgkTzO3rYaOZZl5HsL1zka3bnShga4fOHJmLZ
 zohnY02zmc8r3HZ9KImvttQwcoQ2MPgsr5ci3evgW8DAw3klGeYosFsRmF5sM0/MM2zA
 SBUg==
X-Gm-Message-State: AOAM5308NE5ssv3x34vP8QpXISSyCvzboLu3Mtpu2svcioxUlpSBC0VB
 U4cwSphX7OWk78Yy1Pjov4K164rakCL8rVMzt1o=
X-Google-Smtp-Source: ABdhPJyHEYYA1knweekfZXWyIws6LBDkp5EgMHbkE5IKcM0KqtdDa0vSvnobSu0HUQD3dpo/cUZCf2X5OiXlpb20Fig=
X-Received: by 2002:a37:97c6:: with SMTP id z189mr16052841qkd.74.1597730973364; 
 Mon, 17 Aug 2020 23:09:33 -0700 (PDT)
MIME-Version: 1.0
References: <CAMZc-bwNfCzuhFSDFOjmFsSyX1+bPtFA5gcZq55wy4tKw==mWQ@mail.gmail.com>
 <CAFULd4bPLk+J4O=JTWHkGANV2W6c929HbKg6ihoReNUeoFpy6g@mail.gmail.com>
 <CAMZc-bzdFfOp1nLCY3cH78WZr1DXdvqMqg6bVycw__FPioRBHA@mail.gmail.com>
In-Reply-To: <CAMZc-bzdFfOp1nLCY3cH78WZr1DXdvqMqg6bVycw__FPioRBHA@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Tue, 18 Aug 2020 08:09:22 +0200
Message-ID: <CAFULd4abP44Ji-=XwvszXzNQoyu7heqtMJy+5Gus0rrrLakixw@mail.gmail.com>
Subject: Re: [PATCH]Don't use pinsr for struct initialization.
To: Hongtao Liu <crazylht@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 06:09:34 -0000

On Tue, Aug 18, 2020 at 4:23 AM Hongtao Liu <crazylht@gmail.com> wrote:
>
> On Fri, Aug 14, 2020 at 5:57 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > On Fri, Aug 14, 2020 at 8:03 AM Hongtao Liu <crazylht@gmail.com> wrote:
> > >
> > > Hi:
> > >   For struct initialization, when it fits in a TImode, gcc will use
> > > pinsr insn which causes poor codegen described in PR93897 and PR96562.
> >
> > You should probably remove TImode handling also from ix86_expand_pextr.
> >
>
> Yes, but i failed to construct a testcase to cover this part.
> Anyway, the regression test for i386/x86-64 backend is ok, bootstrap is ok.
> I also run the patch on SPEC2017, no big impact.
>
> > Uros.
> >
> > >   Bootstrap is ok, regression test is ok for i386/x86-64 backend.
> > >   Ok for trunk?
> > >
> > > ChangeLog
> > > gcc/
> > >         PR target/96562
> > >         PR target/93897
> > >         * config/i386/i386-expand.c (ix86_expand_pinsr): Don't use
> > >         pinsr for TImode.
> > >
> > > gcc/testsuite/
> > >         * gcc.target/i386/pr96562-1.c: New test.
> > >
> > > --
> > > BR,
> > > Hongtao
>
> Update patch.

OK for mainline and backports.

Thanks,
Uros.