From: Uros Bizjak <ubizjak@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Jakub Jelinek <jakub@redhat.com>,
Stefan Kneifel <stefan.kneifel@bluewin.ch>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] i386: simplify cpu_feature handling
Date: Wed, 11 May 2022 10:57:10 +0200 [thread overview]
Message-ID: <CAFULd4acz6jcm5WX7Fk5JkK3XfrmPy0q8q_poXH=fFr4sZw1+g@mail.gmail.com> (raw)
In-Reply-To: <aafe211d-a991-89f2-06eb-3c6b17bb80b7@suse.cz>
On Wed, May 11, 2022 at 10:50 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 5/11/22 10:27, Uros Bizjak wrote:
> > On Wed, May 11, 2022 at 10:19 AM Martin Liška <mliska@suse.cz> wrote:
> >>
> >> On 5/2/22 09:57, Martin Liška wrote:
> >>> On 3/31/22 09:01, Martin Liška wrote:
> >>>> @Jakub: May I install it once stage1 opens?
> >>>
> >>> May I please ping this?
> >>>
> >>> Thanks,
> >>> Martin
> >>>
> >>>>
> >>>> Cheers,
> >>>> Martin
> >>>>
> >>>> On 1/3/22 12:43, Martin Liška wrote:
> >>>>> PING: Jakub?
> >>>>>
> >>>>> On 12/15/21 10:57, Martin Liška wrote:
> >>>>>> On 12/14/21 17:12, Jakub Jelinek wrote:
> >>>>>>> I'd use INT_TYPE_SIZE - 1 instead of 31. Otherwise LGTM.
> >>>>>>
> >>>>>> Installed with that change, thanks.
> >>>>>>
> >>>>>> Moreover, I'm suggesting a simplification:
> >>>>>>
> >>>>>> The patch removes unneeded loops for cpu_features2 and CONVERT_EXPR
> >>>>>> that can be simplified with NOP_EXPR.
> >>>>>>
> >>>>>> Survives i386.exp tests, may I install the patch after testing or
> >>>>>> is it a stage1 material?
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Martin
> >>>>>
> >>>>
> >>>
> >>
> >> CCing Uros.
> >>
> >> May I install the patch?
> >
> > Can you please attach the latest version of the patch? I only found
> > the version from Dec. 15. 2021, which I'm not sure is the latest,
> >
> > Thanks,
> > Uros.
>
> Sure, there's the rebased version of the patch.
LGTM.
Thanks,
Uros.
prev parent reply other threads:[~2022-05-11 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 9:55 [PATCH] i386: Fix emissing of __builtin_cpu_supports Martin Liška
2021-12-14 10:28 ` Jakub Jelinek
2021-12-14 15:07 ` Martin Liška
2021-12-14 16:12 ` Jakub Jelinek
2021-12-15 9:57 ` [PATCH] i386: simplify cpu_feature handling Martin Liška
2021-12-16 20:58 ` Stefan Kneifel
2021-12-17 8:50 ` Martin Liška
2022-01-03 11:43 ` Martin Liška
2022-03-31 7:01 ` Martin Liška
2022-05-02 7:57 ` Martin Liška
2022-05-11 8:19 ` Martin Liška
2022-05-11 8:27 ` Uros Bizjak
2022-05-11 8:50 ` Martin Liška
2022-05-11 8:57 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4acz6jcm5WX7Fk5JkK3XfrmPy0q8q_poXH=fFr4sZw1+g@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
--cc=stefan.kneifel@bluewin.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).