From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id F0616388A414 for ; Wed, 11 May 2022 08:57:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0616388A414 Received: by mail-qt1-x82e.google.com with SMTP id p4so1471167qtq.12 for ; Wed, 11 May 2022 01:57:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=O+PYqYzqmeQSdu6WV3WdLUbTI2HCc4e0/Nk0CymfTAQ=; b=gfSaBcQ4/0sdeWHXkFgzw7oOKCm1a/EqM/JmkMjoxFkCy4BUMc5+5Ef7Wq8POJOp0r pVzpu/8WXKutnWdi1zLnaJdW6kN83zNQxJeARmolzYZgNSN/EhKS3szF67FWxog3v86K pE/TcllQgk/WCe7+PWkCo78cBO/vHH386KMAhq6u5lt4V6Sw6LIiWtX/NQzsaQgS5ss0 WlncR7Y9QD0rYLjjI+XuW22tfg9p+Xv/k2pvTUZyJjRL7bTjoiv3WBvN2SsUaCLimNkN 9XYr4VTl1iUT8b848drbKcbH8JwN8NfDwb9bpFgWv4Vw14Z9bzEZHqHuHORz3M89YQMI PhdA== X-Gm-Message-State: AOAM532qfFfpJMgCN++Lc/DQzPYm/4QhGXHFrv7EkSvOYbi0qwkVFaqM 8lYLehF/3VywfbFSEKsfIWaRLgXpUGlT0tmkbOg= X-Google-Smtp-Source: ABdhPJzn8We3W2ohyrhxACRxeQuOUXAtYi4Q4nFzSDw5L2b3dDv1dQhxddQ2LRBlZAr/2GKZwrm/KcMGQxj5iwcvAdo= X-Received: by 2002:ac8:5a82:0:b0:2f3:bac5:6158 with SMTP id c2-20020ac85a82000000b002f3bac56158mr22892795qtc.57.1652259441800; Wed, 11 May 2022 01:57:21 -0700 (PDT) MIME-Version: 1.0 References: <20211214102828.GU2646553@tucnak> <80d628c2-ea0d-c542-b0bb-399d83b7292d@suse.cz> <20211214161219.GX2646553@tucnak> <7d1f146e-b196-a5dd-b4b9-23d4ac68b572@suse.cz> <879ec827-1d81-dbdc-b978-a366d28eb175@suse.cz> <8126b287-c55b-0e7a-032b-5211b4cfbbc2@suse.cz> In-Reply-To: From: Uros Bizjak Date: Wed, 11 May 2022 10:57:10 +0200 Message-ID: Subject: Re: [PATCH] i386: simplify cpu_feature handling To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Jakub Jelinek , Stefan Kneifel , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 08:57:24 -0000 On Wed, May 11, 2022 at 10:50 AM Martin Li=C5=A1ka wrote: > > On 5/11/22 10:27, Uros Bizjak wrote: > > On Wed, May 11, 2022 at 10:19 AM Martin Li=C5=A1ka wro= te: > >> > >> On 5/2/22 09:57, Martin Li=C5=A1ka wrote: > >>> On 3/31/22 09:01, Martin Li=C5=A1ka wrote: > >>>> @Jakub: May I install it once stage1 opens? > >>> > >>> May I please ping this? > >>> > >>> Thanks, > >>> Martin > >>> > >>>> > >>>> Cheers, > >>>> Martin > >>>> > >>>> On 1/3/22 12:43, Martin Li=C5=A1ka wrote: > >>>>> PING: Jakub? > >>>>> > >>>>> On 12/15/21 10:57, Martin Li=C5=A1ka wrote: > >>>>>> On 12/14/21 17:12, Jakub Jelinek wrote: > >>>>>>> I'd use INT_TYPE_SIZE - 1 instead of 31. Otherwise LGTM. > >>>>>> > >>>>>> Installed with that change, thanks. > >>>>>> > >>>>>> Moreover, I'm suggesting a simplification: > >>>>>> > >>>>>> The patch removes unneeded loops for cpu_features2 and CONVERT_EXP= R > >>>>>> that can be simplified with NOP_EXPR. > >>>>>> > >>>>>> Survives i386.exp tests, may I install the patch after testing or > >>>>>> is it a stage1 material? > >>>>>> > >>>>>> Thanks, > >>>>>> Martin > >>>>> > >>>> > >>> > >> > >> CCing Uros. > >> > >> May I install the patch? > > > > Can you please attach the latest version of the patch? I only found > > the version from Dec. 15. 2021, which I'm not sure is the latest, > > > > Thanks, > > Uros. > > Sure, there's the rebased version of the patch. LGTM. Thanks, Uros.