From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106045 invoked by alias); 9 Jul 2015 06:01:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106031 invoked by uid 89); 9 Jul 2015 06:01:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f54.google.com Received: from mail-oi0-f54.google.com (HELO mail-oi0-f54.google.com) (209.85.218.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Jul 2015 06:01:22 +0000 Received: by oibp128 with SMTP id p128so21102468oib.3 for ; Wed, 08 Jul 2015 23:01:20 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.43.133 with SMTP id w5mr12906823obl.65.1436421680226; Wed, 08 Jul 2015 23:01:20 -0700 (PDT) Received: by 10.60.147.170 with HTTP; Wed, 8 Jul 2015 23:01:20 -0700 (PDT) In-Reply-To: <20150708211624.GA17573@intel.com> References: <20150708211624.GA17573@intel.com> Date: Thu, 09 Jul 2015 06:01:00 -0000 Message-ID: Subject: Re: [PATCH] PR target/66817: Check int_size_in_bytes in ix86_return_in_memory From: Uros Bizjak To: "H.J. Lu" Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00675.txt.bz2 On Wed, Jul 8, 2015 at 11:16 PM, H.J. Lu wrote: > ix86_return_in_memory should check negative return from int_size_in_bytes, > similar to other ports. > > Tested on Linux/x86-64. OK for trunk? > > Thanks. > > > H.J. > --- > gcc/ > > PR target/66817 > * config/i386/i386.c (ix86_return_in_memory): Return true > if int_size_in_bytes returns negative for IA MCU. > > gcc/testsuite/ > > PR target/66817 > * gcc.target/i386/pr66817.c: New test. OK. Thanks, Uros. > --- > gcc/config/i386/i386.c | 2 +- > gcc/testsuite/gcc.target/i386/pr66817.c | 27 +++++++++++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.target/i386/pr66817.c > > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > index 55a32ac..54ee6f3 100644 > --- a/gcc/config/i386/i386.c > +++ b/gcc/config/i386/i386.c > @@ -8682,7 +8682,7 @@ ix86_return_in_memory (const_tree type, const_tree fntype ATTRIBUTE_UNUSED) > /* Intel MCU psABI returns scalars and aggregates no larger than 8 > bytes in registers. */ > if (TARGET_IAMCU) > - return VECTOR_MODE_P (mode) || size > 8; > + return VECTOR_MODE_P (mode) || size < 0 || size > 8; > > if (mode == BLKmode) > return true; > diff --git a/gcc/testsuite/gcc.target/i386/pr66817.c b/gcc/testsuite/gcc.target/i386/pr66817.c > new file mode 100644 > index 0000000..7ec18b7 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr66817.c > @@ -0,0 +1,27 @@ > +/* { dg-do compile { target ia32 } } */ > +/* { dg-options "-O2 -mno-sse -mno-mmx -miamcu" } */ > + > +extern void abort (void); > +int > +main (int argc, char **argv) > +{ > + int size = 10; > + typedef struct > + { > + char val[size]; > + } > + block; > + block a, b; > + block __attribute__((noinline)) > + retframe_block () > + { > + return *(block *) &b; > + } > + b.val[0] = 1; > + b.val[9] = 2; > + a=retframe_block (); > + if (a.val[0] != 1 > + || a.val[9] != 2) > + abort (); > + return 0; > +} > -- > 2.4.3 >