* [PATCH] Use -fcf-protection=return in cet-intrin-4.c
@ 2018-02-06 21:02 H.J. Lu
2018-02-06 21:14 ` Tsimbalist, Igor V
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2018-02-06 21:02 UTC (permalink / raw)
To: gcc-patches; +Cc: Uros Bizjak, Igor Tsimbalist
Since -fcf-protection requires both -mshstk and -mibt, use
-fcf-protection=return with -mshstk in cet-intrin-4.c.
OK for trunk?
H.J.
--
PR target/84243
* gcc.target/i386/cet-intrin-4.c (dg-options): Use
-fcf-protection=return.
---
gcc/testsuite/gcc.target/i386/cet-intrin-4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
index 76ec160543f..437a4cd690c 100644
--- a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
+++ b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-O -fcf-protection -mshstk" } */
+/* { dg-options "-O -fcf-protection=return -mshstk" } */
/* { dg-final { scan-assembler "rdsspd|incsspd\[ \t]+(%|)eax" { target ia32 } } } */
/* { dg-final { scan-assembler "rdssp\[dq]\[ \t]+(%|)\[re]ax" { target { ! ia32 } } } } */
/* { dg-final { scan-assembler "incssp\[dq]\[ \t]+(%|)\[re]di" { target { ! ia32 } } } } */
--
2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] Use -fcf-protection=return in cet-intrin-4.c
2018-02-06 21:02 [PATCH] Use -fcf-protection=return in cet-intrin-4.c H.J. Lu
@ 2018-02-06 21:14 ` Tsimbalist, Igor V
2018-02-07 8:52 ` Uros Bizjak
0 siblings, 1 reply; 3+ messages in thread
From: Tsimbalist, Igor V @ 2018-02-06 21:14 UTC (permalink / raw)
To: H.J. Lu, gcc-patches; +Cc: Uros Bizjak, Tsimbalist, Igor V
> -----Original Message-----
> From: Lu, Hongjiu
> Sent: Tuesday, February 6, 2018 10:03 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Uros Bizjak <ubizjak@gmail.com>; Tsimbalist, Igor V
> <igor.v.tsimbalist@intel.com>
> Subject: [PATCH] Use -fcf-protection=return in cet-intrin-4.c
>
> Since -fcf-protection requires both -mshstk and -mibt, use
> -fcf-protection=return with -mshstk in cet-intrin-4.c.
>
> OK for trunk?
Ok from CET viewpoint.
Igor
> H.J.
> --
> PR target/84243
> * gcc.target/i386/cet-intrin-4.c (dg-options): Use
> -fcf-protection=return.
> ---
> gcc/testsuite/gcc.target/i386/cet-intrin-4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
> b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
> index 76ec160543f..437a4cd690c 100644
> --- a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
> +++ b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O -fcf-protection -mshstk" } */
> +/* { dg-options "-O -fcf-protection=return -mshstk" } */
> /* { dg-final { scan-assembler "rdsspd|incsspd\[ \t]+(%|)eax" { target ia32 } } }
> */
> /* { dg-final { scan-assembler "rdssp\[dq]\[ \t]+(%|)\[re]ax" { target { ! ia32 } }
> } } */
> /* { dg-final { scan-assembler "incssp\[dq]\[ \t]+(%|)\[re]di" { target { ! ia32 } }
> } } */
> --
> 2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Use -fcf-protection=return in cet-intrin-4.c
2018-02-06 21:14 ` Tsimbalist, Igor V
@ 2018-02-07 8:52 ` Uros Bizjak
0 siblings, 0 replies; 3+ messages in thread
From: Uros Bizjak @ 2018-02-07 8:52 UTC (permalink / raw)
To: Tsimbalist, Igor V; +Cc: H.J. Lu, gcc-patches
On Tue, Feb 6, 2018 at 10:14 PM, Tsimbalist, Igor V
<igor.v.tsimbalist@intel.com> wrote:
>> -----Original Message-----
>> From: Lu, Hongjiu
>> Sent: Tuesday, February 6, 2018 10:03 PM
>> To: gcc-patches@gcc.gnu.org
>> Cc: Uros Bizjak <ubizjak@gmail.com>; Tsimbalist, Igor V
>> <igor.v.tsimbalist@intel.com>
>> Subject: [PATCH] Use -fcf-protection=return in cet-intrin-4.c
>>
>> Since -fcf-protection requires both -mshstk and -mibt, use
>> -fcf-protection=return with -mshstk in cet-intrin-4.c.
>>
>> OK for trunk?
>
> Ok from CET viewpoint.
OK.
Thanks,
Uros.
> Igor
>
>> H.J.
>> --
>> PR target/84243
>> * gcc.target/i386/cet-intrin-4.c (dg-options): Use
>> -fcf-protection=return.
>> ---
>> gcc/testsuite/gcc.target/i386/cet-intrin-4.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
>> b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
>> index 76ec160543f..437a4cd690c 100644
>> --- a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
>> +++ b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c
>> @@ -1,5 +1,5 @@
>> /* { dg-do compile } */
>> -/* { dg-options "-O -fcf-protection -mshstk" } */
>> +/* { dg-options "-O -fcf-protection=return -mshstk" } */
>> /* { dg-final { scan-assembler "rdsspd|incsspd\[ \t]+(%|)eax" { target ia32 } } }
>> */
>> /* { dg-final { scan-assembler "rdssp\[dq]\[ \t]+(%|)\[re]ax" { target { ! ia32 } }
>> } } */
>> /* { dg-final { scan-assembler "incssp\[dq]\[ \t]+(%|)\[re]di" { target { ! ia32 } }
>> } } */
>> --
>> 2.14.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-07 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 21:02 [PATCH] Use -fcf-protection=return in cet-intrin-4.c H.J. Lu
2018-02-06 21:14 ` Tsimbalist, Igor V
2018-02-07 8:52 ` Uros Bizjak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).