From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id A69BF393BC3A for ; Wed, 10 Apr 2024 18:32:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A69BF393BC3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A69BF393BC3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712773984; cv=none; b=BONFJW24o9F4e4+N6I9goAR19VYL4htvS/YQJtNUqo9TOypWk3oesxk7rYNHR9Db5h+iqzWVM2YVM+XFmX2h/wcEn2yuOM75vRvrso96EjQBqasYsQ+qp0c8ScmlOBgawvKgAc/zkCGU4gP2ROcB0l78uc8wEhayU2W5Y7wr96U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712773984; c=relaxed/simple; bh=ZNWDMKEi+0y0y6o5AMkfO5dMUt8N+GjTt0Ojx0A0cqQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=M8OirsCQ6ekGrKXufJT/CK+j8U7rUya94TunOGlhYSdviiWLUawKztit6P06jVPe/+AcOVk8+slfc16LE9+pmV6DP8AMzrYOXgB6z10AcGJ1vkkveRB4+Ii5wkpjzxOwL2/b6Q93aXYnRlPgSJ9w7ESyIjK+82Je5T6lQ0ijwxY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2d886f17740so1109371fa.1 for ; Wed, 10 Apr 2024 11:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712773972; x=1713378772; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wNDXl3UhjjQNqLSDoD7PP2YYrI8JvaoIQecswC/rmoM=; b=m5JCUsLPDZZMZINWT3ROvAbM50xn49op2UPBYrDeIkuBpmH0/PGrWjKuHEgn4EhQZR 23bkkW8bRKq6SJPR7bhCVoXMLV5lUZ4xSuVcaAqm9NKKy+Wbz3LIgBg/msjqWcAFd1py ei4KyVW4AcqBRvaqJIi7Wk9zYtXLOwzQBGalcGzKsdMEwWNdCx5+/HwBYdQ8DwwuvobI 2jrnHobkJD567xzWkbwM/23pIer+n+wODbCXCeoeW3qNtTu3bP5JSz5Q6CQfFDIOXJCJ 1+jb75wdbqLkiJMZmWhxoytw+QPE0tkEFlAPq9Hb92gB4wQ+cLKA5vsggWRhTBw3gShX ArBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712773972; x=1713378772; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wNDXl3UhjjQNqLSDoD7PP2YYrI8JvaoIQecswC/rmoM=; b=jgWNj9CBSi/5Wm/A/4yKByDUST8Hu97NKNDUfz6iC65Wdfsiga5C7nKbYxbTw1U8Fw wIxCvJM1F1Vqy+Rw0tL+jxJJ2h0gqoMG/e5dGNGx0QENkJK3T/H31NLSW0QtxJzsmTFo 05e+M5SUoejhojGfnL93RuW87Hbl2WpCeZbYXXSTJqpuHu9RQWcL6kdv0Xi67AgSxVg/ 4qOkR88II/6Savr+aP8L0lPAfv/PFQpwS7aXzhQdco+xzjn7C3Y9fxIkemGgPEPxPy2r FqbHXyMyTsAiSnZKC++3DaIkhG0MZ9OdtsJOs8cE8r2X2pUgIJPgTTjg1LdDz5uCZr4G bY2Q== X-Gm-Message-State: AOJu0YzJykWxedcoH69eLtCYJ0BXax2hfqvAtgnFnwcSVmrezWNg6W/J gbs2XNb5cl9IUhjhsqwM/wMWuwfrmejLhQS7gBZjJCSML6Ssw8+3MDL4QHzz4TwcbX0Mt+bXsHu OXAETrwg59xAm27pN9YHttybUXLU= X-Google-Smtp-Source: AGHT+IGr91XJZeE4CR+FnDqJ3zHQ09Bh5NdhpWyuLXBlHmQ/jtOqyyfRP/lpYNZYyA33J14okT+4bgLZFsMfbSKVBmI= X-Received: by 2002:a2e:b049:0:b0:2d8:9c43:e7e5 with SMTP id d9-20020a2eb049000000b002d89c43e7e5mr139037ljl.1.1712773971619; Wed, 10 Apr 2024 11:32:51 -0700 (PDT) MIME-Version: 1.0 References: <20240410175227.GN19790@gate.crashing.org> In-Reply-To: <20240410175227.GN19790@gate.crashing.org> From: Uros Bizjak Date: Wed, 10 Apr 2024 20:32:39 +0200 Message-ID: Subject: Re: Combine patch ping To: Segher Boessenkool Cc: "gcc-patches@gcc.gnu.org" , Jeff Law , Richard Biener Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 10, 2024 at 7:56=E2=80=AFPM Segher Boessenkool wrote: > > On Sun, Apr 07, 2024 at 08:31:38AM +0200, Uros Bizjak wrote: > > If there are no further comments, I plan to commit the referred patch > > to the mainline on Wednesday. The latest version can be considered an > > obvious patch that solves certain oversight in the original > > implementation. > > This is never okay. You cannot commit a patch without approval, *ever*. > > That patch is also obvious -- obviously *wrong*, that is. There are > big assumptions everywhere in the compiler how a CC reg can be used. > This violates that, as explained elsewhere. Can you please elaborate what is wrong with this concrete patch. The part that the patch touches has several wrong assumptions, and the fixed "???" comment just emphasizes that. I don't see what is wrong with: (define_insn "@pushfl2" [(set (match_operand:W 0 "push_operand" "=3D<") (unspec:W [(match_operand 1 "flags_reg_operand")] UNSPEC_PUSHFL))] "GET_MODE_CLASS (GET_MODE (operands[1])) =3D=3D MODE_CC" "pushf{}" [(set_attr "type" "push") (set_attr "mode" "")]) it is just a push of the flags reg to the stack. If the push can't be described in this way, then it is the middle end at fault, we can't just change modes at will. Feel free to revert the patch, I will unassign myself from the PR. Uros.