From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ubizjak@gmail.com>
Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a])
	by sourceware.org (Postfix) with ESMTPS id B03003899435
	for <gcc-patches@gcc.gnu.org>; Tue, 13 Sep 2022 10:14:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B03003899435
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-3487d84e477so133684237b3.6
        for <gcc-patches@gcc.gnu.org>; Tue, 13 Sep 2022 03:14:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=EYk9N1gzIVY74qDROT+kWtDSyZwG+aJp/nB6t0V+/pc=;
        b=ZRPUDX07d1RKQGk5soEf3iMhOEgmz1cfrLpvrLo9iXnu8XoJtRVLF/YdakWEB9C80+
         NV/mGtC9XpkHVncUSqQdhB7GxNbgAkGmMsIFtWru2IWBQhXUk3mXK/nF9D7mPxxQFMHN
         LGAX6FesYZGD118EICJGbkWlBMyOpIjC7V4f8KGPnaElwaQI8RyDTLPeIJpCJT2rj6iP
         BgC84zYpW4iEI+Fcm2nC0pOtoaDgHYpdkJFEQ0up5+At+cPsVMXxz62e5LbiIa/iKHdS
         wmsE6thypUg1l4UzxWs/e82huXbwXH/D1uKGYiL94yRJa3QPlvpSfmppNAzZVNHZ3yLd
         Cs8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=EYk9N1gzIVY74qDROT+kWtDSyZwG+aJp/nB6t0V+/pc=;
        b=A0xQ+rgbUtau6S2ax2q74v4kN8D+QnMwqtEY1DC20cryUb740jNuMQosA2O7uD7mSp
         y1b9S+rxKVzZsE5IGXCwt9gVH2hGxJl3pkmE883zKtweVSGVR/8QhTRW5OXVDyEMCDA8
         JQ/jeTuKqxHIbuHXySVtWx+Pvu8CdfOqRk4Ex+FyVHhu9xSPzkzTlWDWIL0L83BIHmJu
         aLgcx4ilYzfIXzHKI1WHHb9TVdMZN9p+MUDeNZnudo227IdgBUlXfmVVDKQOahNOsHz9
         EyrsrYktcD4ftUf6Espr/Q2+OftOmY0zxKNcU2PXRN0LyNp5654mDaXhil+zaYHnbTE3
         gL5A==
X-Gm-Message-State: ACgBeo3NsH4f3KnlLkv58fJCpU9u8iLbd31jGDNwJXILyyqi7rKhsiKf
	Bqrm6qy+PeGYMNhl2fdj0kVEcjrVR5DXoNw7dYQ=
X-Google-Smtp-Source: AA6agR7cYYGmCd0+upVqsRGUTyD0ZT+NAMxXijoUHxpKezdG+LO/wbMAksOKRBWw//+a+PKX46HYHPhv+e75oyYRrdw=
X-Received: by 2002:a81:60c6:0:b0:345:7a55:20ce with SMTP id
 u189-20020a8160c6000000b003457a5520cemr25630922ywb.480.1663064091012; Tue, 13
 Sep 2022 03:14:51 -0700 (PDT)
MIME-Version: 1.0
References: <020401d8c757$2af45f10$80dd1d30$@nextmovesoftware.com>
In-Reply-To: <020401d8c757$2af45f10$80dd1d30$@nextmovesoftware.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Tue, 13 Sep 2022 12:14:39 +0200
Message-ID: <CAFULd4ajPAO6XnWtUDJDa1kRghg=oqH70CZxw35g94nroYHvWA@mail.gmail.com>
Subject: Re: [PATCH] PR target/106877: Robustify reg-stack to malformed asm.
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Sep 13, 2022 at 11:57 AM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch resolves PR target/106877 an ICE-on-invalid inline-asm
> regression.  An innocent upstream change means that the test case
> from PR inline-asm/84683 now hits a different assert in reg-stack.cc's
> move_for_stack_reg.  Fixed by duplicating Jakub's solution to PR 84683
> https://gcc.gnu.org/pipermail/gcc-patches/2018-March/495193.html
> at this second (similar) gcc_assert.
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap
> and make -k check, both with and without --target_board=unix{-m32},
> with no new failures.  Ok for mainline?
>
>
> 2022-09-13  Roger Sayle  <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
>         PR target/106877
>         * reg-stack.cc (move_for_stack_reg): Check for any_malformed_asm
>         in gcc_assert.
>
> gcc/testsuite/ChangeLog
>         PR target/106877
>         * g++.dg/ext/pr106877.C: New test case.

OK.

Thanks,
Uros.