Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

[Uros Bizjak <ubizjak@gmail.com>]

Hello!

> 2015-03-27  Caroline Tice  <cmtice@google.com>
>
>         * final.c (final_scan_insn): Change 'cold_function_name' to
>         'cold_partition_name' and make it a global variable; also output
>         assembly to give it a 'FUNC' type, if appropriate.
>         * varasm.c (cold_partition_name): Declare and initialize global
>         variable.
>         (assemble_start_function): Re-set value for cold_partition_name.
>         (assemble_end_function): Output assembly to calculate size of cold
>         partition, and associate size with name, if appropriate.
>         * varash.h (cold_partition_name): Add extern declaration for global
>         variable.
>         * testsuite/gcc.dg/tree-prof/cold_partition_label.c: Add dg-final-use
>         to scan assembly for cold partition name and size.

This patch caused PR 65929 [1].

Targets are (ab)using ASM_DECLARE_FUNCTION_NAME and
ASM_DECLARE_FUNCTION_SIZE for more things that their name suggests. As
shown in the PR, some directives that are generated through these
macros apply only to real functions, not to parts of function in the
middle of the function.

In the particular case in the PR, assembler doesn't tolerate nested
function declaration.

I suggest to revert the patch for now, until side effects of the patch
are resolved.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65929

Uros.