From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id B317A3858D33 for ; Thu, 23 May 2024 08:35:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B317A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B317A3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::234 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716453323; cv=none; b=pkRDFF9z+rMbxFkCySIPudEBbwxEUIgIF7eePbFc2PIdOLuupmv4+yiOC16kCH4C704aGQdAR+EtZ25EvHCQ4oJCRHefIxX1TJp2C6QTJ6GVNjtkxUuLcCm+rE9UMJTGe0WXg3EP8s6wgPLWqVuTjRr7rklJaemgMGMrSyTqenk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716453323; c=relaxed/simple; bh=HWbYiySYldF2rXkmXKo+BJA/Ki7GTQKiWlSBFAjwrJY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=YpzTkOCPYDiyuX52aZKF6ia4SwRmwGUiERFXsp6pCMK5cqHFHH13D0yVVhFTAA7TNtEn8q5EW6iGCzSXkh8Tuch+eb6yvtYjezZA8QzfzGJ19XItgN68atDcjzSMxEnnmeQAc1Gyrb2/yg+7psYLyL/eOS2rMrfT8RK/eBKsrlY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2e34e85ebf4so63965561fa.2 for ; Thu, 23 May 2024 01:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716453312; x=1717058112; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rMZhXrh/2vrXenCWsNUSIBC+H2ID+LIHC3OHMvmnXDE=; b=ddgHG5E8hedrPz4lqP9x03u5Rj8n5uk/2WLNbwno3lIm+NjwvxrGws7dMTlJEaccpU rs2hMvnTEENLYIlfiBCkwYVwbgpEA39BZsWS4qpEgaohVA5qV7t2Vd/OdVwMXhBQdKhu ZeEjvuIrl1SeO8Hepi3UIQAnZwgT88hOwQaT5WNeEJ6L6BsXn3X1Co4mV3VECivi+LBk k7NkbyQrwp5+c1XKBduYzU/CoeeDB+GBONRWvm/j0PtcXwDxbg1CQPKe9uQHj5N70UNo nK7SSazzFgHJ3/XDCCVkq7JPnqwCX3/ADr9pqJ+K8xp/JazklQVFY3VeYxTv/Q4OIjIt 7IZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716453312; x=1717058112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rMZhXrh/2vrXenCWsNUSIBC+H2ID+LIHC3OHMvmnXDE=; b=omsLVc14MJ4WoXqg1MNQn/Xl2UeXUrSD1pANiAlit8TX3bMfcAc8b2PRKQ722Lz1pI FjMhvpbHeqM709F7PCwNNcdP5oVYC4L0TSJ3OIhKKg8Y2KSgtBWP2Hv9s8+BQwIY+lS0 0Tzdw47QsJINKnKA5Rjd3HLqIni0rsb83eYJyPJWk7gPeSNBwANjzbVRdAMDTZENUQ9U ai1H4Fdh0ltSQlRIl/L7JqwkHqXYr3GzMTT7mabazn1dhCYdiGxY4osobAFGB9OBBJoc gqJd08p+XEsTimsWoSMI/jvGJwVGoQQTFs2gn/CUx0t5VND4OWrR+UUd/anrASuuTMsF zdpQ== X-Forwarded-Encrypted: i=1; AJvYcCVG6XI8UxmHgXBORv9qx3qmvQADIzwayKmk4gs6Sfm9+mlHjovIxyjynU0cVK6JDQYtNJSiRP7upB7dsgCjCg/+WI/DjzkQ1A== X-Gm-Message-State: AOJu0Yx9le/tj4sWLFaLoqiMWQkL36etWbSrLSSDccAjoWj6pEdOi7ws FDQcipG88ax66kymqF0Tj9JFTlRIudQ2se48EYcA9M+Tla0VNMVVBIwtHc+IED1gmITjuiluryu cbXWY6vBZ6yKc3xByta1n4ldiWCI= X-Google-Smtp-Source: AGHT+IHvEwlmDGjCWeTqV/j04dfNq2q5K2ZLWxY5ZXvZoQg+H4x3ARUvwats7JlQvXTMjeWoM7e02gjjPzYVLaCqVpM= X-Received: by 2002:a2e:9919:0:b0:2df:8bef:d900 with SMTP id 38308e7fff4ca-2e9495a2a63mr25668261fa.16.1716453311808; Thu, 23 May 2024 01:35:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Thu, 23 May 2024 10:35:00 +0200 Message-ID: Subject: Re: [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw To: Evgeny Karpov Cc: "hubicka@ucw.cz" , Richard Sandiford , "gcc-patches@gcc.gnu.org" , "Richard Earnshaw (lists)" , Maxim Kuvyrkov , Radek Barton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 22, 2024 at 4:32=E2=80=AFPM Evgeny Karpov wrote: > > Wednesday, May 22, 2024 1:06 PM > Richard Sandiford wrote: > > > This looks good to me apart from a couple of very minor comments below,= but > > please get approval from the x86 maintainers as well. In particular, t= hey might > > prefer to handle ix86_legitimize_pe_coff_symbol in some other way. > > Thanks, Richard, for the review! > The suggestions will be addressed in the next version. > > Jan and Uros, could you please review x86 refactoring for mingw part? Tha= nks. Yes, perhaps legitimize_pe_coff_symbol should be handled similar to how machopic_legitimize_pic_address is handled.and just use "#if TARGET_PECOFF" at call sites when calling functions from the new winnt-dll.h. This would also allow us to remove the early check for !TARGET_PECOFF in legitimize_pe_coff_symbol. Uros.