From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by sourceware.org (Postfix) with ESMTPS id B13F03858D1E for ; Wed, 19 Apr 2023 06:53:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B13F03858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id oo30so17598350qvb.12 for ; Tue, 18 Apr 2023 23:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681887233; x=1684479233; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EA/RNbhyGMTt48WRSHQaAQa418u56Z7yQEZ7jY7LuAw=; b=DXqVxW30sdjMnz0LWnrE5c6sdPd41w1VQaTrmNv8OwsGQB8afbIs8ypEY5o4DmOAT8 L3cRNK29vSaexGn1pd59lIUld09yBS5K6N4RUVoP9O6pVKnVqqno1W0blDebVYAO0Wp2 j7PkcntVFHma8koRLtD7qQ96msQEDn3mxT0+R/7rz65HBYLPHve0FrZox1eAIQeWSKxK leZu6lmGEhkMbaRK+N7hNVJSVYNxUyJmsKF95k6VZC0fEZJMOSWYtiRZnyybGxEh9dTt sHzYgjFd9FUGSf+2yi+CFMHXeJ6iGZPx4TKJGaQrBvM+PFFsqLcbf6JkOn+SJ6wMPPIs 1ajg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681887233; x=1684479233; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EA/RNbhyGMTt48WRSHQaAQa418u56Z7yQEZ7jY7LuAw=; b=jPVccBhqb1Gd0clUkmGCiySdPpO2EK6kwK+j3xzV5HuNnX8iE4Ll3b571SyOzXv1m+ X7FcZ86kz2igtBWW/xsIN/TymAckAszVfLe/OoYqXFI860vbGBWIOql0y4prCjuDL9db UpOXL9Goik1KR5XsNbYj3cPpagrRhjt8I/sbHzDQfPmwv4gnE7mukgtISOCMGDJBSNN3 2TsoJUJO/bBAitdDjHyjmCoNZJJl2kGGZxARkVgOoqRAFH/ZlpOQFO+TtjTkpgo770CU HLafTiplc1jbr9g2g5gl+CnUClqQsIpHehF1ha+GPJ9CwJZG0mjLYNU3qYsGjPjsIojM NRxg== X-Gm-Message-State: AAQBX9f41kXFaaDoDCy3UVubuQFl2fI7wP7pvDZuBnNxReLutpXMJ5xH ewBgD1X9o+KY16gnFfPAjZPG5y90xLNoj24nF7k= X-Google-Smtp-Source: AKy350ZukGkTRgwkph4ltrg52ir/HoEGv/JT2aX3e0U3Yb05ws/vG28tDhKUA+1U0tXgvYQJcYkolcLoftlNl+36xEc= X-Received: by 2002:ad4:5ecf:0:b0:5ef:642e:7cd2 with SMTP id jm15-20020ad45ecf000000b005ef642e7cd2mr23309314qvb.7.1681887233690; Tue, 18 Apr 2023 23:53:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Uros Bizjak Date: Wed, 19 Apr 2023 08:53:42 +0200 Message-ID: Subject: Re: [PATCH] Introduce VIRTUAL_REGISTER_P and VIRTUAL_REGISTER_NUM_P predicates To: Jakub Jelinek Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 18, 2023 at 7:20=E2=80=AFPM Jakub Jelinek wr= ote: > > On Mon, Apr 17, 2023 at 11:27:28PM +0200, Uros Bizjak via Gcc-patches wro= te: > > --- a/gcc/rtl.h > > +++ b/gcc/rtl.h > > @@ -1972,6 +1972,13 @@ set_regno_raw (rtx x, unsigned int regno, unsign= ed int nregs) > > /* 1 if the given register number REG_NO corresponds to a hard registe= r. */ > > #define HARD_REGISTER_NUM_P(REG_NO) ((REG_NO) < FIRST_PSEUDO_REGISTER) > > > > +/* 1 if the given register REG corresponds to a virtual register. */ > > +#define VIRTUAL_REGISTER_P(REG) (VIRTUAL_REGISTER_NUM_P (REGNO (REG))) > > + > > +/* 1 if the given register number REG_NO corresponds to a virtual regi= ster. */ > > +#define VIRTUAL_REGISTER_NUM_P(REG_NO) = \ > > + (IN_RANGE (REG_NO, FIRST_VIRTUAL_REGISTER, LAST_VIRTUAL_REGISTER)) > > Why the ()s around both definitions? > IN_RANGE adds its own and anything on top of that is just superfluous. Mainly to imitate the surrounding code (e.g. HARD_REGISTER_P) that is quite generous with brackets. I can remove external brackets from both definitions, but I'd remove them also from the HARD_REGISTER_P definition. Uros,